User:Standard8/MailNews Password Manager Migration: Difference between revisions

From MozillaWiki
Jump to navigation Jump to search
(Initial version mostly moved and updated from User:Standard8)
 
 
(10 intermediate revisions by the same user not shown)
Line 3: Line 3:
* Main Core changes in place (PW migration, nsIAuthPrompt handling).
* Main Core changes in place (PW migration, nsIAuthPrompt handling).
** May require further changes to PW migration routines
** May require further changes to PW migration routines
* LDAP URL Patch updated and submitted for review {{bug|419595}}
* Patches for SM Prefs, tools menu, front-end {{bug|390025}}
* Patches for SM Prefs, tools menu, front-end {{bug|390025}}
** May be out-of-date
** May be out-of-date
Line 8: Line 9:
* TB UI patch needs updating {{bug|239131}}
* TB UI patch needs updating {{bug|239131}}
* Backend-changes required (see below)
* Backend-changes required (see below)
== Backend changes/information ==
=== Protocols versus urls registered within MailNews ===
Ones I'm worried about:
{|border=1
! Protocol !! Handler !! Url !! Url derived from nsMsgMailNewsUrl? !! Status
|-
| ldap || <!--http://mxr.mozilla.org/comm-central/source/directory/xpcom/base/src/nsLDAPProtocolHandler.js--> nsLDAPProtocolHandler.js || nsLDAPUrl || No || patch in {{bug|419595}}
|-
| ldaps || <!--http://mxr.mozilla.org/comm-central/source/directory/xpcom/base/src/nsLDAPProtocolHandler.js--> nsLDAPProtocolHandler.js || nsLDAPUrl || No || patch in {{bug|419595}}
|-
| <strike>imap</strike> || <strike>[http://mxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapService.cpp nsImapService.cpp]</strike> || nsIMAPUrl || Yes || Complete
|-
| news || [http://mxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNntpService.cpp nsNntpService.cpp] || nsNewsUrl || Yes || {{Bug|470439}} fixes password migration. Protocol hander tests already in.
|-
| <strike>nntp</strike> || <strike>[http://mxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNntpService.cpp nsNntpService.cpp]</strike> || N/A || N/A || N/A
|-
| <strike>snews</strike> || <strike>[http://mxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNntpService.cpp nsNntpService.cpp]</strike> || N/A || N/A || N/A
|-
| <strike>mailto</strike> || <strike>[http://mxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsSmtpService.cpp nsSmtpService.cpp]</strike> || N/A || N/A || N/A
|-
| smtp || nsSmtpProtocolHandler.js || nsSmtpUrl || Yes || patch in {{bug|469807}}
|-
| smtps || nsSmtpProtocolHandler.js (patch in {{bug|469807}}) || nsSmtpUrl || Yes || patch in {{bug|469807}}
|-
| <strike>pop</strike> || <strike>[http://mxr.mozilla.org/seamonkey/source/mailnews/local/src/nsPop3Service.cpp nsPop3Service.cpp]</strike> || N/A || N/A || N/A
|-
| <strike>pops</strike> || N/A || N/A || N/A || N/A
|-
| <strike>mailbox</strike> || <strike>[http://mxr.mozilla.org/seamonkey/source/mailnews/local/src/nsMailboxService.cpp nsMailboxService.cpp]</strike> || nsMailboxUrl || Yes || Complete
|-
|}
Others:
* [http://mxr.mozilla.org/seamonkey/source/mailnews/addrbook/src/nsAddbookProtocolHandler.cpp addbook]
** Address book printing.
* [http://mxr.mozilla.org/seamonkey/source/mailnews/base/src/nsCidProtocolHandler.cpp cid]
** Something to do with [http://mxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgSend.cpp#2120 generating HTML]


== Current Problems ==
== Current Problems ==
Line 53: Line 96:
|news://localhost/ || news://localhost/ || username || PromptUsernameAndPassword
|news://localhost/ || news://localhost/ || username || PromptUsernameAndPassword
|}
|}
smtp needs migration for smtps and port.


== Misc Notes ==
== Misc Notes ==

Latest revision as of 13:46, 22 December 2008

Current Status

  • Main Core changes in place (PW migration, nsIAuthPrompt handling).
    • May require further changes to PW migration routines
  • LDAP URL Patch updated and submitted for review bug 419595
  • Patches for SM Prefs, tools menu, front-end bug 390025
    • May be out-of-date
  • Build config & installer patch on bug 239131, need to get reviews when a bit closer.
  • TB UI patch needs updating bug 239131
  • Backend-changes required (see below)

Backend changes/information

Protocols versus urls registered within MailNews

Ones I'm worried about:

Protocol Handler Url Url derived from nsMsgMailNewsUrl? Status
ldap nsLDAPProtocolHandler.js nsLDAPUrl No patch in bug 419595
ldaps nsLDAPProtocolHandler.js nsLDAPUrl No patch in bug 419595
imap nsImapService.cpp nsIMAPUrl Yes Complete
news nsNntpService.cpp nsNewsUrl Yes bug 470439 fixes password migration. Protocol hander tests already in.
nntp nsNntpService.cpp N/A N/A N/A
snews nsNntpService.cpp N/A N/A N/A
mailto nsSmtpService.cpp N/A N/A N/A
smtp nsSmtpProtocolHandler.js nsSmtpUrl Yes patch in bug 469807
smtps nsSmtpProtocolHandler.js (patch in bug 469807) nsSmtpUrl Yes patch in bug 469807
pop nsPop3Service.cpp N/A N/A N/A
pops N/A N/A N/A N/A
mailbox nsMailboxService.cpp nsMailboxUrl Yes Complete

Others:

Current Problems

  • News logins probably won't migrate properly.
  • Mail logins may not migrate properly if username has been changed since account was created (the uri uses the original account username) - or if they do, it'll be confusing to the user.
  • Need to check consistency of nsIURI::path for the mailnews uris.
  • Need to provide smtp protocol handler for mailnews (and any others that are missing).
  • Need secure version of LDAP protocol handler.
  • Some incorrect refcount or something causing cycle collector issues?

Notes to self

  • mailbox = pop3
  • ldap/ldaps is correct

Current formats of urls

Site Username nsIAuthPrompt Calls
imap://username@host username PromptPassword
ldap://localhost:389/dc=test <> PromptPassword
mailbox://username@host username PromptPassword
smtp://username@host <> PromptPassword and PromptUsernameAndPassword
news://localhost:119/#password
news://localhost:119/#username		 <>
<>		 Prompt and PromptPassword

Proposed new format

Hostname (site) httpRealm username nsIAuthPrompt Calls
imap://host imap://host username PromptPassword
ldap://localhost ldap://localhost/dc=test username +++ PromptPassword
mailbox://host mailbox://host username PromptPassword
smtp://host smtp://host username PromptPassword and PromptUsernameAndPassword
news://localhost/ news://localhost/ username PromptUsernameAndPassword

smtp needs migration for smtps and port.

Misc Notes

  • formSubmitURL is always not set.
  • httpRealm is always set as you must set on of httpRealm or formSubmitURL (in LDAP case we need this anyway).
  • +++ username for LDAP won't be used straight away as it needs other bugs fixing first.
Retrieved from "https://wiki.mozilla.org/index.php?title=User:Standard8/MailNews_Password_Manager_Migration&oldid=121576"