Services/Process/Code Review

Code Review Policy for Mozilla Services Code

Code review prior to landing is now required for _all_ changes to all production-oriented Mozilla Services code. This includes the Firefox Sync client code, the various pieces of server code, and anything else living in http://hg.mozilla.org/services.

Code Areas

Firefox Sync (add-on and library code)

Repositories Sync Client

Reviewers

• Philipp von Weitershausen
• Mike Connor
• Ed Lee

Server Code (PHP)

Repositories

• Sync Server
• Registration Server
• Registration Server (Secure)

Reviewers

• Toby Elliott
• Tarek Ziade
• Mike Connor

Primary Server Code (Python)

Repositories

• Core Functions (Shared)
• Registration Code
• Storage API Code
• Full Server server-full is a meta-package that pulls in all components needed for a standalone server

Reviewers

• Tarek Ziade
• Toby Elliott
• JR Conlin
• Ian Bicking

Key Exchange Server (Python)

Repositories

• Key Exchange

Reviewers

• Tarek Ziade
• Ian Bicking

System-review

System-review (similar to super-review in core Mozilla code) is designed to ensure the overall coherence and stability of the Weave ecosystem. Changes to any Weave code covered under this policy that impacts APIs, scalability, or client performance may require system-review, in addition to primary review. This review will generally not cover the details of the code, but will focus on the overall system performance aspects of the patches.

Mike Connor (mconnor@mozilla.com) is the only current system-reviewer