Services/Process/Code Review: Difference between revisions
Jump to navigation
Jump to search
No edit summary |
|||
| Line 11: | Line 11: | ||
'''Repositories''' | '''Repositories''' | ||
* [http://hg.mozilla.org/services/services-central/ services-central] | * [http://hg.mozilla.org/services/services-central/ services-central] | ||
* [http://hg.mozilla.org/services/fx-sync/ | * [http://hg.mozilla.org/services/fx-sync/ fx-sync (now defunct)] | ||
'''Reviewers''' | '''Reviewers''' | ||
| Line 17: | Line 17: | ||
* [mailto:rnewman@mozilla.com Richard Newman] | * [mailto:rnewman@mozilla.com Richard Newman] | ||
* [mailto:mconnor@mozilla.com Mike Connor] | * [mailto:mconnor@mozilla.com Mike Connor] | ||
=== Firefox Share (f.k.a. F1) === | |||
'''Repositories''' | |||
* [https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/ fx-share] | |||
'''Reviewers''' | |||
* [mailto:philipp@weitershausen.de Philipp von Weitershausen] | |||
* [mailto:mixedpuppy@gmail.com Shane Caraveo] | |||
=== Identity client === | |||
'''Repositories''' | |||
* XXX | |||
'''Reviewers''' | |||
* XXX | |||
=== Server Code (PHP) === | === Server Code (PHP) === | ||
| Line 55: | Line 72: | ||
* [mailto:jconlin@mozilla.com JR Conlin] | * [mailto:jconlin@mozilla.com JR Conlin] | ||
* [mailto:ianb@mozilla.com Ian Bicking] | * [mailto:ianb@mozilla.com Ian Bicking] | ||
=== Identity server === | |||
'''Repositories''' | |||
* TODO | |||
'''Reviewers''' | |||
* TODO | |||
Revision as of 21:42, 20 April 2011
Code Review Policy for Mozilla Services Code
Code review prior to landing is now required for _all_ changes to all production-oriented Mozilla Services code. This includes the Firefox Sync client code, the various pieces of server code, and anything else living in http://hg.mozilla.org/services.
All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers. Where it is unclear, the first reviewer should determine that a second review would be appropriate.
Code Areas
Firefox Sync
Repositories
Reviewers
Repositories
Reviewers
Identity client
Repositories
- XXX
Reviewers
- XXX
Server Code (PHP)
Repositories
Reviewers
Sync/Reg Server Code (Python)
Repositories
- Core Functions (Shared)
- Registration Code
- Storage API Code
- Full Server server-full is a meta-package that pulls in all components needed for a standalone server
Reviewers
Key Exchange Server (Python)
Repositories
Reviewers
Identity server
Repositories
- TODO
Reviewers
- TODO