DOM/WebIDL Review Checklist: Difference between revisions

DOM/WebIDL Review Checklist (view source)

236 bytes added , 29 September 2014

no edit summary

Confirmed users

657

edits

@@ Line 10: / Line 10: @@
 * Please take extra care reviewing things that are hidden behind <code>[Pref]</code>s.  If an API only has a <code>[Pref]</code> annotation, and it's supposed to be something only available to a subset of Firefox OS apps, they are probably doing things wrong, because <code>[Pref]</code> only gives us platform level granularity.  IOW, when they turn on the pref on b2g, the API will end up being exposed to all content there, which is usually not what we want.  Currently the only legitimate use case for only using <code>[Pref] without either <code>[CheckPermissions]</code> or <code>[AvailableIn]</code> is for APIs that are supposed to be exposed to all Web content but we're not turning them on yet for spec or implementation stability reasons.
 * Consider whether APIs are acceptable for prerendering.  See https://wiki.mozilla.org/Gecko:Prerendering/API_Review_Guidelines for more information.
+* Please refer to the [http://heycam.github.io/webidl/ WebIDL spec] or the [https://developer.mozilla.org/en/Mozilla/WebIDL_bindings documentation for our binding layer] in order to double check your understanding of the IDL as needed.