68
edits
Firefox/Projects/TabCandy/Work: Difference between revisions
→Landing
No edit summary |
|||
| Line 119: | Line 119: | ||
# If the patch fixes a bug or adds a feature (rather than, say, code clean-up, string changes, style changes, etc), it should have a unit test. | # If the patch fixes a bug or adds a feature (rather than, say, code clean-up, string changes, style changes, etc), it should have a unit test. | ||
# Regardless of whether you're adding a test, try all the browser chrome tests locally: '''make -C ''<objdir>'' mochitest-browser-chrome''' | # Regardless of whether you're adding a test, try all the browser chrome tests locally: '''make -C ''<objdir>'' mochitest-browser-chrome''' | ||
# Attach your patch to the bug and assign it for feedback from one of the Panorama team | # Attach your patch to the bug and assign it for feedback from one of the Panorama team (mitcho, raymondlee, seandunn) | ||
# Once you've got f+, mark it r? for review (dietrich, dolske, gavin | # Once you've got f+, mark it r? for review (generally to iangilman, but other potentials include dao, dietrich, dolske, gavin; ask in #tabcandy if you're not sure who to assign it to) | ||
# Once they've given you an r+, you'll need approval (unless it's already marked as a blocker, which means it's already approved for landing): | # Once they've given you an r+, you'll need approval (unless it's already marked as a blocker, which means it's already approved for landing, or if it's a test fix): | ||
## Mark it with a question mark under "approval 2.0", if the reviewer hasn't already done so | ## Mark it with a question mark under "approval 2.0", if the reviewer hasn't already done so | ||
## If it's a rush, poke someone to do the approval 2.0 (beltzner, johnath, dietrich, gavin, dolske are good candidates, or ask in #tabcandy if unsure who) | ## If it's a rush, poke someone to do the approval 2.0 (beltzner, johnath, dietrich, gavin, dolske are good candidates, or ask in #tabcandy if unsure who) | ||
| Line 131: | Line 131: | ||
# Once you've got your approval, make a fresh patch with the commit message giving the bug number and title (if you haven't already done that), and updated with [r=foo a=bar] | # Once you've got your approval, make a fresh patch with the commit message giving the bug number and title (if you haven't already done that), and updated with [r=foo a=bar] | ||
# Mark the bug for checkin, by adding the keyword "checkin-needed" to it. | # Mark the bug for checkin, by adding the keyword "checkin-needed" to it. | ||
# If it's urgent, poke someone who can land it, such as iangilman or ehsan | |||
# If it's urgent, poke someone who can land it | |||
Also, make sure to read http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed | Also, make sure to read http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed | ||