Security/Reviews/Gaia/SystemMessageHandler: Difference between revisions
Jump to navigation
Jump to search
No edit summary |
|||
| Line 13: | Line 13: | ||
====Components==== | ====Components==== | ||
==== Relevant Documentation ==== | |||
* Initial Discussion https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.webapi/o8bkwx0EtmM | |||
TODO I don't think there is more official documentation? | |||
==== Relevant Source Code ==== | ==== Relevant Source Code ==== | ||
* gecko/dom/messages/interfaces/nsIDOMNavigatorSystemMessages.idl | * gecko/dom/messages/interfaces/nsIDOMNavigatorSystemMessages.idl | ||
| Line 25: | Line 29: | ||
* gecko/dom/messages/SystemMessagePermissionsChecker.jsm | * gecko/dom/messages/SystemMessagePermissionsChecker.jsm | ||
Additional files that changed: | Additional files that changed to support the System Messages: | ||
* | * gecko/b2g/chrome/content/shell.js | ||
* | * gecko/b2g/chrome/content/shell.js | ||
* | * gecko/config/autoconf.mk.in | ||
* dom/base/ | * gecko/dom/base/Navigator.cpp | ||
* dom/base/ | * gecko/dom/base/Navigator.h | ||
* dom/base/ | * gecko/dom/base/nsDOMClassInfo.cpp | ||
* dom/base/ | * gecko/dom/base/nsDOMWindowUtils.cpp | ||
* dom/base/ | * gecko/dom/base/nsGlobalWindow.cpp | ||
* dom/base/ | * gecko/dom/base/nsGlobalWindow.h | ||
* | * gecko/dom/Makefile.in | ||
* | * gecko/toolkit/toolkit-makefiles.sh | ||
===Code Review Notes=== | ===Code Review Notes=== | ||
Revision as of 16:42, 15 February 2013
App Review Details
- System Component: System Message Handler
- Review Date: 15 Feb 2013
- Review Lead: Stefan Arentz
- Review Bug: bug 751025 [Security Review] System Message Handler
Overview
Architecture
Components
Relevant Documentation
- Initial Discussion https://groups.google.com/forum/?fromgroups#!topic/mozilla.dev.webapi/o8bkwx0EtmM
TODO I don't think there is more official documentation?
Relevant Source Code
- gecko/dom/messages/interfaces/nsIDOMNavigatorSystemMessages.idl
- gecko/dom/messages/interfaces/nsISystemMessagesInternal.idl
- gecko/dom/messages/SystemMessageInternal.js
- gecko/dom/messages/SystemMessageManager.js
- gecko/dom/messages/SystemMessageManager.manifest
- gecko/dom/messages/SystemMessagePermissionsChecker.jsm
Additional files that changed to support the System Messages:
- gecko/b2g/chrome/content/shell.js
- gecko/b2g/chrome/content/shell.js
- gecko/config/autoconf.mk.in
- gecko/dom/base/Navigator.cpp
- gecko/dom/base/Navigator.h
- gecko/dom/base/nsDOMClassInfo.cpp
- gecko/dom/base/nsDOMWindowUtils.cpp
- gecko/dom/base/nsGlobalWindow.cpp
- gecko/dom/base/nsGlobalWindow.h
- gecko/dom/Makefile.in
- gecko/toolkit/toolkit-makefiles.sh