Firefox OS/Comms/Dialer/Sprint/v2.1-S5

From MozillaWiki
< Firefox OS‎ | Comms‎ | Dialer‎ | Sprint
Revision as of 04:28, 16 September 2014 by Drs (talk | contribs) (→‎PTO)
Jump to navigation Jump to search

Bugs

Status

Dialer v2.1-S5 burndown chart.png

  • 0,0,0,0,0,0,0,0,0,0

Bugs Taken in Planning

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
983766 Cristian Rodriguez (:crdlc) [B2G][Dialer] Suggested phone numbers don't appear for Facebook contacts that have edited phone numbers --- No cf_feature-b2g [planned-sprint] RESOLVED FIXED
1029142 Gabriele Svelto [:gsvelto] Call log deletions don't persist after killing the app --- No cf_feature-b2g [planned-sprint c=3] RESOLVED DUPLICATE
1060730 Germán Toro del Valle (:gtorodelvalle) Turn updateICEContacts() into a Promise.all() barrier --- No cf_feature-b2g [planned-sprint] RESOLVED FIXED
1061616 Anthony Ricaud (:rik) call log is not showing recently dialled numbers 2.1+ No cf_feature-b2g [fromAutomation] [planned-sprint c=3][in-sprint=v2.1-S4][2.1-flame-test-run-2] VERIFIED FIXED
1061623 David Garcia [:davidg][retired] Write tests for ticker updates on the call screen --- No cf_feature-b2g [planned-sprint] RESOLVED FIXED

5 Total; 0 Open (0%); 4 Resolved (80%); 1 Verified (20%);

Bugs Taken but not Completed

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1060451 Doug Sherk (:drs) (inactive) Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js --- No cf_feature-b2g [planned-sprint c=6][in-sprint=v2.1-S5] RESOLVED FIXED
1068106 Doug Sherk (:drs) (inactive) Evaluate acquiring screen wake lock from callscreen when a call ends --- No cf_feature-b2g [planned-sprint c=1][in-sprint=v2.1-S5] RESOLVED WONTFIX

2 Total; 0 Open (0%); 2 Resolved (100%); 0 Verified (0%);

Bugs Taken During Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1061614 Gabriele Svelto [:gsvelto] Call log database upgrade path to schema 4 wrongly puts calls one week apart in the same group --- No cf_feature-b2g RESOLVED FIXED
1065147 Anthony Ricaud (:rik) [Dialer] DTMF volume is reduced significantly and cannot be increased after a call 2.1+ No cf_feature-b2g [caf priority: p2][2.1-flame-test-run-2][CR 726380] VERIFIED FIXED
1065302 Jorge Prudencio [:jorgep] Contact phone numbers and phone type should always be separated with a comma --- No cf_feature-b2g VERIFIED FIXED
1066869 (inactive after 6/18) Alive Kuo [:alive] [Contacts] Contact photo does not appear when receiving a call. 2.1+ No cf_feature-b2g [caf priority: p2][CR 723665][2.1-flame-test-run-2] VERIFIED FIXED
1069439 Doug Sherk (:drs) (inactive) ICE contacts don't show up on emergency call screen 2.1+ No cf_feature-b2g VERIFIED FIXED
1070825 Tzu-Lin Huang [:dwi2][:tzhuang] [Dialer] Connect multiple way calls with same number but difference extension number. 2.0M+ No cf_feature-b2g VERIFIED FIXED
1073534 Doug Sherk (:drs) (inactive) "cancel" is a non-localizable string in the audio output picker 2.1+ No cf_feature-b2g RESOLVED FIXED

7 Total; 0 Open (0%); 2 Resolved (28.57%); 5 Verified (71.43%);

All Issues for this Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
983766 Cristian Rodriguez (:crdlc) [B2G][Dialer] Suggested phone numbers don't appear for Facebook contacts that have edited phone numbers --- --- [planned-sprint] RESOLVED FIXED
1029142 Gabriele Svelto [:gsvelto] Call log deletions don't persist after killing the app --- --- [planned-sprint c=3] RESOLVED DUPLICATE
1060730 Germán Toro del Valle (:gtorodelvalle) Turn updateICEContacts() into a Promise.all() barrier --- --- [planned-sprint] RESOLVED FIXED
1061614 Gabriele Svelto [:gsvelto] Call log database upgrade path to schema 4 wrongly puts calls one week apart in the same group --- --- RESOLVED FIXED
1061616 Anthony Ricaud (:rik) call log is not showing recently dialled numbers 2.1+ --- [fromAutomation] [planned-sprint c=3][in-sprint=v2.1-S4][2.1-flame-test-run-2] VERIFIED FIXED
1061623 David Garcia [:davidg][retired] Write tests for ticker updates on the call screen --- --- [planned-sprint] RESOLVED FIXED
1065147 Anthony Ricaud (:rik) [Dialer] DTMF volume is reduced significantly and cannot be increased after a call 2.1+ --- [caf priority: p2][2.1-flame-test-run-2][CR 726380] VERIFIED FIXED
1065302 Jorge Prudencio [:jorgep] Contact phone numbers and phone type should always be separated with a comma --- --- VERIFIED FIXED
1066869 (inactive after 6/18) Alive Kuo [:alive] [Contacts] Contact photo does not appear when receiving a call. 2.1+ --- [caf priority: p2][CR 723665][2.1-flame-test-run-2] VERIFIED FIXED
1069439 Doug Sherk (:drs) (inactive) ICE contacts don't show up on emergency call screen 2.1+ --- VERIFIED FIXED
1070825 Tzu-Lin Huang [:dwi2][:tzhuang] [Dialer] Connect multiple way calls with same number but difference extension number. 2.0M+ --- VERIFIED FIXED
1073534 Doug Sherk (:drs) (inactive) "cancel" is a non-localizable string in the audio output picker 2.1+ --- RESOLVED FIXED

12 Total; 0 Open (0%); 6 Resolved (50%); 6 Verified (50%);

Bugs Redirected

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
983766 Cristian Rodriguez (:crdlc) [B2G][Dialer] Suggested phone numbers don't appear for Facebook contacts that have edited phone numbers --- --- [planned-sprint] RESOLVED FIXED
1029142 Gabriele Svelto [:gsvelto] Call log deletions don't persist after killing the app --- --- [planned-sprint c=3] RESOLVED DUPLICATE
1037868 Doug Sherk (:drs) (inactive) Create gaia-sim-picker component --- --- [planned-sprint c=6][in-sprint=v2.1-S2] RESOLVED FIXED
1060730 Germán Toro del Valle (:gtorodelvalle) Turn updateICEContacts() into a Promise.all() barrier --- --- [planned-sprint] RESOLVED FIXED
1061616 Anthony Ricaud (:rik) call log is not showing recently dialled numbers 2.1+ --- [fromAutomation] [planned-sprint c=3][in-sprint=v2.1-S4][2.1-flame-test-run-2] VERIFIED FIXED
1061623 David Garcia [:davidg][retired] Write tests for ticker updates on the call screen --- --- [planned-sprint] RESOLVED FIXED

6 Total; 0 Open (0%); 5 Resolved (83.33%); 1 Verified (16.67%);


Daily Standup Meetings

  • Current hosts: drs, gtorodelvalle, thills
  • Hosts rotate every week.
  1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
  2. Start by pinging everyone who should be participating.
  3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
  4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
  5. Move to individual updates. Go alphabetically, in descending order.
  6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
  7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
  8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Day 1: September 16

Blockers

  • bug 1061616 - call log is not showing recently dialled numbers
    • QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
  • bug 1065147 - [Dialer] DTMF volume is reduced significantly and cannot be increased after a call
    • New blocker, currently unassigned. Maybe Gabriele knows something about this.

drs

  • Admin:
    • Welcome back, Anthony.
    • The Etherpad is completely messed up. Please fix your sections by cutting and pasting the whole thing. Sorry about that!
  • Next steps:
    • bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
      • Going to investigate this.
    • bug 1066869 - [Contacts] Contact photo does not appear when receiving a call.
      • Going to investigate this.
    • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
      • Going to get this actionable again.
    • bug 1037868 - Create gaia-sim-picker component
      • Need to fix this after Anthony's high-level comments.
  • Done:
    • Did sprint planning, and followup work.
    • Contacted Bhavana about adding a "suggested landing" section to the B2G_Landing page to avoid what happened with 2.1 FL being earlier than anticipated.
    • bug 1053641 - [b2g][2.0] "call forwarding status" page string format has problem.
      • Review+ for Gabriele, landed.
    • bug 1054818 - [Sora][Call][Settings]The call time display abnormal after user change the system time.
      • Helped with figuring out how to stub Performance.now(). It's going to come back to me for review at some point.
    • bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
    • bug 1061398 - Incall keypad layout needs adjustment
      • Gave feedback for Paco. We need VD input from Carol before we can continue here.
    • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number” message
      • Review+ for Jorge.
    • bug 1059087 - [Contacts] No space between 'Carrier Name' and ‘Label'
      • Uplifted to v2.1, provided some help with bug 1030346, its dependency.

Rik

  • Catching up on your activites (email and such)
  • Comms sprint meeting
  • Will take a look at the 2.0 blocker, bug 1066869 Contact photo does not appear when receiving a call
  • Will work on the 2.1 blog post tomorrow

gtorodelvalle

  • Administrative:
    • SADLY I WON'T BE ABLE TO CONNECT TO THE DAILY LONG :( I will use Etherpad to report and please feel free to contact me via IRC any other time ;) Thanks!
    • Back from holidays. Spent yesterday to catch up with emails and messages.
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Helping Paco with this bug.
    • Left some comments in Github for Doug :)
    • We'll ask for a new review from Doug ASAP.

thills

  • bug 1024341 - Wakeup the device after call hangs up
    • Have some feedback from Carrie to make it pause for a bit on the duration screen.
    • I'm debugging on the CallScreen right now trying to understand where to make it pause. It seems that we are getting multiple CloseWindow calls. This seems to shutdown the app very quickly and causes some of the code in handled_call.js not to execute. Might need a discussion after the standup.

jpruden92

  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • <gtorodelvalle> feedback+.
    • Waiting to review.
    • Need to do changes.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
    • Changing the solution.
  • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
    • Patch made. Waiting to review.
    • Improving the solution. Modifying tests.
    • Need final review

pacorampas

  • Absent/no report

PTO

  • davidg: none
  • drs: Sep 26, tentative
  • gsvelto: none
  • gtorodelvalle: ?
  • jpruden92: ?
  • paco: ?
  • Rik: ?
  • thills: none

Retrospective

Retrospective Etherpad

Things we did well

  • <drs> This was a nice and relaxed sprint, and we didn't get many blockers.
  • <davidg> Managed to get bugs on time

Things we could do better

  • <drs> Dialer has ~550 bugs open at any given time: https://bugzilla.mozilla.org/buglist.cgi?component=Gaia%3A%3ADialer&list_id=11111500&product=Firefox%20OS&query_format=advanced&resolution=---&order=bug_id&limit=0
    • <drs> Thoughts on doing a bug bash? I know it's not fun, but a lot of these bugs are ancient and it will probably be as simple as resolving them or duping them.
    • <thills> I would like to do it. Would be good to set aside a time where we can all work on it at the same time.
  • <drs> We didn't do any demos this last sprint. I'm wondering if anyone sees any value in them. We asked this last time but maybe the answer has changed. If we decide to get back to doing them, I will really start pushing it this sprint for anything demoable.
    • <thills> do we have a blog to go along with this? I'm not sure it's for us directly, but others outside the team.
    • <drs> Anthony was going to, but I don't know if we got enough demos, or if he had time.
  • <davidg> A bug that was late-l10n was just landed at the very last moment, but it was ready much before.
    • <drs> Suggestions?
    • <davidg> When the bug get blocked by a deadlock discussion, just try to unlock it. Pretty much what we did at the end but earlier.
    • <drs> Yeah, sometimes it's hard to know the state of everything. I noticed that this was blocked a bit later because it didn't seem blocked on the surface a few days before. It would help if this was mentioned in daily meetings and notes.
    • <davidg> I should probably tried to propose a solution instead of just watch them argue :)
    • <drs> It's ok, it's hard to know what to do all the time. Just mention it in the daily. Either way it was ok, it would have just been nice to be unblocked sooner.

Action items

  • <drs> We have not been doing enough to get contributors engaged. I've talked with Francisco who actively sets himself as a mentor on many bugs and provides and plan and support for contributors. I'm going to begin doing this and I suggest that others do the same as well.
    • <gsvelto> I've set myself up as a mentor on a number of bugs but none dialer-related IIRC. Most of those are code cleanup & factoring out shared pieces as those are easy for new contributors and not high priority. We could start by filing some of those as there's many parts of the dialer that could use some love. Additionally if a bug needs an easy follow up it's always best to set it as a mentored one (e.g. remove a workaround, polish some unit-tests, etc...).
    • <davidg> Maybe we should invite Jorge and Francisco to join dailys
      • <drs> I did I think. I should double-check that.
  • <drs> Do a bug bash.
    • <drs> Have a 2.2 phone and 2.0 or 2.1 ready to test bugs.
  • <drs> Really push for demos and do a blog post.
  • <drs> Continue doing office hours.

Demos

Retrieved from "https://wiki.mozilla.org/index.php?title=Firefox_OS/Comms/Dialer/Sprint/v2.1-S5&oldid=1015181"