Webdev:Flux:Code Review Process

From MozillaWiki
Revision as of 20:11, 31 March 2011 by Aking (talk | contribs) (Creating checklist for code review)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigation Jump to search

Code review Checklist

  • README.md exists and has everything you need to get the app up and running
  • Uses requirements/prod.txt etc patterns
  • App starts in development mode
  • Spend a few minutes using the app
  • Can you understand the purpose of the application?
  • YSlow/Page Speed Scores
    • Shoot for an A
    • Any low hanging fruit to get it there?
    • JS/CSS jingo-minify
    • Sprites
  • w3 Validator
  • Firebug net tab - any 404 or 500
  • Review settings.py - anything stand out?
    • settings_local.py-dist exists?
    • email - uses Responsys or SocketLabs instead of local mail?
    • any exotic libraries or services
  • Review all typical Django code (urls, views, models, forms, etc)
  • Review app specific python code
  • pylint, pyflakes with generous settings (ignore 80 char etc)
  • l10n - templates use gettext?
  • Security - any obvious issues?
  • JavaScript - review code
    • good style?
    • No inline or obtrusive JS
    • jslint with generous settings
  • CSS good style
  • JS and CSS not minified in dev mode
  • Image - have no text embedded
Retrieved from "https://wiki.mozilla.org/index.php?title=Webdev:Flux:Code_Review_Process&oldid=295667"