Today’s meeting leader is: K88hudson
- 1 General Topics / Roundtable
- 2 Friends of the Firefox team
- 3 Project Updates
- 3.1 Accessibility
- 3.2 Add-ons / Web Extensions
- 3.3 Addon Manager & about:addons
- 3.4 WebExtensions Framework
- 3.5 Bugs fixed by contributors:
- 3.6 Applications
- 3.7 Firefox Accounts
- 3.8 Sync and Storage
- 3.9 Push
- 3.10 Developer Tools
- 3.11 Debugger
- 3.12 Console
- 3.13 Network Monitor
- 3.14 Remote Debugging
- 3.15 DEBTools
- 3.16 Documentation
- 3.17 Fission
- 3.18 Lint
- 3.19 New Tab Page
- 3.20 NodeJS
- 3.21 Password Manager
- 3.22 Performance
- 3.23 Performance Tools
- 3.24 Picture-in-Picture
- 3.25 Privacy/Security [read only]
- 3.26 Remote Debugging (Chromium Protocol)
- 3.27 Search and Navigation
- 3.28 User Journey
- 4 This week I learned
General Topics / Roundtable
Friends of the Firefox team
Resolved bugs (excluding employees)
Fixed more than one bug
- Florens Verschelde :fvsch
- Pranav pandey
New contributors (🌟 = first patch)
- (Will be filled out after the meeting)
Add-ons / Web Extensions
Addon Manager & about:addons
- As part of the QA verification on Bug 1602839 (meta issue related to locking down the add-ons sideload locations) we noticed that we were still accepting sideloading of extensions dropped into the application directory, Shane fixed this in Bug 1616545 (currently landed in Firefox 75, may be uplifted to 74 beta).
- The initial webpage that originated an addon installation is now stored in the addon db and sent as part of the abuse reports submitted by a user for the related extension (Bug 1610844)
- In Bug 1493620 Tomislav removed the creation of about:blank in the windowless browsers created to load the extension background pages
- In Bug 1614966 Shane moved the RemoteSettings prefs overriding out of ExtensionXPCShellUtils.jsm, which should make it simpler to re-use ExtensionTestUtils in xpcshell tests that would need RemoteSettings prefs to not be overwritten (e.g. see Bug 1612416)
Bugs fixed by contributors:
- saroyanm fixed a bug that was preventing browser.permissions.request to work correctly when called from an extension popup (Bug 1432083)
Sync and Storage
- The newly added "beforeinput" event is now also available as "Event Listener Breakpoints", thanks to farooqbckk
- The secondary footer in the Debugger was removed to save some space
- File tabs in Debugger can now be reordered with drag & drop, thanks to transfusion
- Command-Click to highlight and jump to a location, thanks to janelledement
Instant Evaluation keeps getting better (scheduled for 75)
📯 Call for Feedback: File in the meta bug
Oriol added support for Proxy and Reflect methods in bug 1615861
Logan added support for side-effects free DOM method (like querySelector for example)
Highlight DOM element results (bug 1614549)
Fixed issue with autocomplete case-insensitive matching in bug 1614841
[WIP] Display the autocomplete above the input so it doesn’t cover the instant evaluation result (bug 1609942)
- `print` and `pprint` console helpers were removed, as they’re not standard, provided little values in comparison to console APIs and are not defined in other browser DevTools (Bug 1613845 and 1613843 )
- There’s now a way to disable autocomplete directly in the UI (Bug 1593607)
- Autoclose brackets - The Console panel input now respects the Autoclose brackets option. Console automatically inserts the corresponding closing element for quotes & brackets (bug).
- Eugene added proper rendering of ES6 classes in the console and debugger (bug 1592277)
- Alex made the Multiprocess Browser Console faster to open (bug 1605763)
- Console also got a boost when dealing with lots of new messages at once (bug 1612571)
- Added autocompletion support for optional chaining operator (?.) that landed in Firefox 74 (bug 1594009)
- WebSocket Inspector supports WAMP protocol, including JSON, MsgPack and CBOR (bug). Available in the Network panel
- Resend request doesn’t forget headers anymore, thanks to thiago.arrais
- The left sidebar (request blocking and full text search) is now accessible with a side bar toggle, thanks to pranavpandey1998official
- Focused filter buttons now look less `active` to avoid confusion, thanks to vtsty.dev
- Blocking network URLs now allows wildcard (*) patterns, thanks to duncangleeddean
- A new Initiator column in the Network table shows the stack trace, thanks to tranfusion.
- Borders got added between columns in network requests list for readability
The Network panel introduced nice column borders for better readability.
- Temporary extensions loaded in GeckoView apps now also appear in about:debugging when connected to the device. Implemented by Luca Greco in bug 1596867.
- Historically, the framework part of the code that deals with client to server communication for DevTools has been called DebuggerClient and DebuggerServer.
This likely comes from the fact that the Debugger was probably the first tool to be based on a remote (client-server) architecture.
These objects have now been renamed to the more self-explanatory DevToolsClient and DevToolsServer.
- Julian tracked down an issue that had made the build for our documentation website fail for some time now (bug 1613368). The site was fine, but the latest updates were not being pushed to it. This is now fixed!
We'll continue improving the onboarding docs on that site, and turn it into a simple, easy to digest, single page that points to other up-to-date resources wherever possible, to avoid duplication.
- Honza improved the table of content for the DevTools docs on https://firefox-source-docs.mozilla.org/devtools/index.html
In time, we plan on moving our internal technical documentation over to this site instead of https://docs.firefox-dev.tools . Our firef-dev.tools site will only contain a one pager getting started guide for new contributors.
- Bernard Igiri has a patch up to port UnselectedTabHover to JSWindowActors
- Neil has a patch up to port RemotePageManager, and many of the pages that rely on it, to JSWindowActors
- hsivonen fixed the focus issue so you can click in form controls now.
- Adding a general fission test that is useful as a base for other fission tests that need to check that functionality works in different iframe setups.
ESLint is now on for the entire codebase (where possible): 🎉🎉🎉🎉🎉🎉 https://www.thebanners.uk/standard8/2020/02/14/eslint-now-turned-on-for-all-of-the-firefox-gecko-codebase/
A big, big, thank you to all who have participated and helped to roll this out, especially those that picked up the mentored bugs.
There's still more to do (enabling more of the "default" rules on various files.
New Tab Page
- Working on Pocket story collections, almost done, just some telemetry and metrics stuff left.
- Now ready to enable Pocket stories in the UK for 75
Show a dismissed login capture doorhanger when a user edits a password field (before submission)! (off-by-default until some follow-ups are landed)
We no longer consider a login modified if there is a <button> and we fixed tabbing from a field eligible for password generation.
The Fathom team is making progress on rules to identify new-password fields to offer password generation.
Initial support for OS authentication dialogs before accessing credentials is in review.
- dthayer has landed the work to write StartupCache’s file in a background thread and helped enable Fast shutdown on Nightly
- dthayer has also continued working on improving select dropdown performance
- emalysz switched DownloadPlatform to use a low-priority background thread
- Florian ensures we avoid running BrowserGlue idle tasks during shutdown
- gijs wrote a clang checker for RemoveObserver calls for xpcom-shutdown from inside Observe() and has helped with xperf regressions for the new search service
- mconley enabled Base Profiler for Talos startup tests and fixed the about_home_topsites_first_paint scalar probe
- mconley has also started to put together a story on egregious start-up times
mconley wrote a patch to collect Telemetry on whether or not Windows-users have Superfetch and Prefetch enabled and using the default settings
Superfetch and Prefetch are optimizations that Windows offers to try to improve application start times.
- bigiri has started to de-couple ASRouter from Activity Stream as part of the effort to speed up about:home initialization.
We’re tracking a very nice falloff in our shutdown duration probe on the Nightly channel in the 95th percentile, likely due to dthayer’s shutdown improvement efforts!
- Added WebChannel support for enabling the profiler popup. Now you can use the newer panel by clicking the enable button on https://profiler.firefox.com if you are on Firefox Nightly.
Firefox Profiler home page with the new “enable profiler menu button” button
- Removed the loupe view from the tab panel.
- Added "show active tab only" checkbox to see the active tab processes and threads only. We are trying to make the UI simpler for web developers, expect more changes soon. (example profile)
“Show active tab only” checkbox
- Storage migration for the profiler server is over now. The server was down for a while on Friday and Saturday, but it's up and running again now.
- Martin Stransky from RedHat fixed an issue where the Picture-in-Picture player window would shrink after opening on KDE desktops
- Karan Sapolia made it so that the keyboard shortcut (Ctrl-Shift-] on Linux and Windows) prioritizes selecting the first playing video in the page, rather than the first video in the markup.
- mconley has a patch up to enable usage Telemetry on the release channel
- Gijs expanded the Picture-in-Picture event Telemetry to non-Windows platforms as well
- mconley has a patch up make double-clicking fullscreen the player window
- mstriemer made it so that closing the player window with the “X” button causes the underlying video to pause
- We’re hanging around in this Matrix channel now.
Privacy/Security [read only]
- Erica has landed the initial patch to start purging cookies and site data from tracking sites that the user hasn’t interacted with for a while. This combats e.g. first-party redirect tracking.
- We’re starting to roll out DoH for a percentage of US users.
Multi-Account Containers Sync is live; people love it!
Thank you to our Outreachy intern Kendall for implementing it!
- We’re shipping Feature Policy (allow attribute on iframes) and Permission Delegation with Firefox 74
- Paul has started to implement tab-modal prompts in Bug 1615588 - Extend nsIPromptService to support tab modal system prompts (with WIP GIFs)
Remote Debugging (Chromium Protocol)
(read-only this week)
- Henrik implemented Page.getNavigationHistory to allow access to history entries of the current tab, and Page.navigateToHistoryEntry to navigate between those.
- Henrik finished off the patch from David Burns for Page.setCookie(s).
- Henrik added support for the "clip" argument in Page.captureScreenshot
- The Puppeteer project are now running their CI jobs against Firefox Nightly in addition to Chrome
Search configuration modernization
Turning the new configuration on for Nightly users in the next few days. Full roll-out currently scheduled for 76.
Please watch out for regressions, e.g. unexpectedly missing engines, or re-appearing engines.
www. prefix is now stripped from urls in results - Bug 1614957
Has been enabled in Early Beta 74
Release scheduled for Firefox 75
Many fixes landed and uplifted to stabilize the design and features, in preparation to run a full experience pref-flip experiment in Firefox 74.
Tab can again be used to move through results when there is user typed search string - Bug 1616880
Working on separating about:welcome from about:newtab to improve performance, adding JSWindowActors
Experimenting with loading remote content during first run using Normandy
- Bernard helping us with separating ASRouter/Messaging System from New Tab
- Launched Chrome Switchers experiment (New users on Windows that use Google Chrome): The onboarding card on about:home/newtab allows the user to start the import wizard
- Upgraded to node 10
- Starting up “Profile Migration Revamp” initially focusing on new users from Windows Chrome to contextually suggest importing passwords that exist in other browsers
Example import suggestion from Chromium-based Chrome + Edge
This week I learned
[mconley] You can send nsIInputStream’s over the message manager / JSWindowActors
Might be an interesting way of avoiding IPC message limits
We don’t implement nsIOutputStream, but if you need to output from process A to process B, construct an nsIInputStream in process A and hand to process B, and have process B consume the stream.
You can send Blobs too
[mconley] We now have public static class fields in Nightly
Unsure whether or not we’re okay to use these yet in production code.