- 1 Actions from last meeting
- 2 General Topics / Roundtable
- 3 Friends of the Firefox team
- 4 Project Updates
- 4.1 Add-ons
- 4.2 Activity Stream
- 4.3 Electrolysis (e10s)
- 4.4 Firefox Core Engineering
- 4.5 Form Autofill
- 4.6 Go Faster
- 4.7 Photon
- 4.8 Platform UI and other Platform Audibles
- 4.9 Privacy/Security
- 4.10 Project Mortar (PDFium)
- 4.11 Quality of Experience
- 4.12 Search
- 4.13 Sync / Firefox Accounts
- 4.14 Storage Management
- 4.15 Test Pilot
- 4.16 This week I learned
Actions from last meeting
- Select a new meeting leader for April 11th meeting. Today’s meeting leader is: felipe
- Next meeting leader is: RyanVM!
General Topics / Roundtable
(tips/tricks/FYI, productivity improvements, industry news)
- [felipe] faststripe to be removed (bug 1351258)
- [felipe] Using native async/await instead of Task.jsm
- Task.async => async
- yield => await
- [mconley] Should we be adding a section on the re-theme effort?
- [mconley] In case you didn’t notice, MozReview allows you to comment on commit messages now. 🎉 There was also a big discussion on commit messages on dev-platform, and a number of our high IC engineers expressed a desire for more clear commit messages before requesting review.
- [florian] bug 1316187: the browser_all_files_referenced.js test landed.
- It will fail whenever you remove the last reference to a chrome file and forget to remove it, or when pre-landing chrome files that aren't used anywhere yet.
- It contains a long list of exceptions with bugs on file to cleanup existing unused files. This should be an easy source of good first bugs if you are looking for mentoring opportunities.
- [florian] getComplexValue/setComplexValue should no longer be used with the nsISupportsString type for preference values with unicode characters. Instead just use the new getStringPref/setStringPref methods (bug 1345294)
- not to be confused with getCharPref/setCharPref
- eslint will report code using the old pattern
- [MattN] "skin" vs. "content" stylesheets after Complete Theme removal (Fx57+)
- Sounds like removing the concept of “skin” packages will be best
Friends of the Firefox team
(Give a shoutout/thanks to people for helping fix and test bugs. Introductions)
- Resolved bugs (excluding employees): https://mzl.la/2ocJNZA
- More than one bug fixed:
- Deepjyoti Mondal
- Federico Padua [:fedepad]
- Hrishikesh Barman[:geekodour08]
- Jan Beich
- Jan Henning [:JanH]
- Meghana Gupta
- Paavini Nanda
- Tomislav Jovanovic :zombie
- New contributors (🌟 = First Patch!)
- 🌟 Bharat Raghunathan got rid of an icon that we don’t need anymore!
- 🌟 Clinton Feng removed some unnecessary Telemetry!
- Deepa switched over some of our Telemetry code to use async and await!
- ganesh2583 fixed some glitches with our in-content focus rings!
- 🌟 Hrishikesh Barman[:geekodour08] cleaned up some of our CSS!
- 🌟 Joseph Cameron changed which Sync API version that we say we support!
- 🌟 Konstantin (:trx) beefed up our Flake8 checks for some of our Telemetry code!
- 🌟 maxim fixed a bug in about:preferences where we weren’t properly resetting custom settings when switching between history-remembering modes
- Meghana Gupta fixed a broken Learn More link for a certificate pinning error page!
- Paavini Nanda beefed up our Flake8 checks by enabling another rule!
- Prathiksha fixed a styling inconsistency in our about:neterror page!
- Subhdeep Saha switched over yet even more of our Telemetry code to use async and await!
- More than one bug fixed:
- 1.7.0 Activity Stream released (Test Pilot) https://moz-activity-streams.s3.amazonaws.com/dist/latest.html
- Experiment for improving Top Sites engagement
- Lots of customization improvements
- Re-evaluated our schedule for landing in Nightly - new estimate puts us in Fx57
- We’ve now got 4 content processes on by default on Nightly!
- The 54 e10s-multi experiment will test 4 different cohorts: 1 content process, 2 content processes, 4, and 8. 25% of users in each.
- Background tabs are being restored in the content process by default now, improving perceived session restore performance
- A reminder that sync IPC and sync messages are to be avoided at all costs
- Flash click-to-play experiment coming up on nightly SOON.
- Reminder: crash pings (both main and content) contain raw crash stacks as of 53.
- Verified that some clients did not receive updates to pushed system addons when the updated addons were included in a subsequent build (such as, say, websense-related). This has been fixed.
- Only a few remaining M1 bugs which means we will start calling for Nightly testing in a few weeks after some sanity checks and polish
- Fallback to form history if whole profiles doesn't have any data for the specific fields
- Fallback to form history if the target field doesn't have data in selected profile
- Allow manually adding an autofill profile from the management interface
- Allow deleting autofill profiles from the management interface
- In Progress
- Interface to manage autofill profiles
- Specify text color of selected profile item instead of inheriting from global autocomplete style
- Improve subdialog.js to support multiple dialogs
- [Form Autofill A utility library for handling full name and separated names]
- Notify formautofill add-on of which item is being hovered in the suggestion dropdown
- Implement label element extraction logic of an input field for filling form
- [Form Autofill Auto-create profiles based off submitted form data]
- [Form Autofill Collect information on how much time users spent on page with forms (w/wo form autofill)]
- (for next time)
Platform UI and other Platform Audibles
- Netflix just enabled support for Firefox on Linux
- jjong landed a bunch of l10n fixes for the DateTime picker!
- [johannh] Continuing permission prompts polish work:
- Nihanth changed the permission prompts for Desktop Notifications to always permanently save the permission (temporary push notifications doesn’t really make sense) instead of showing a pre-ticked checkbox by default.
- Nihanth also fixed a bug where notification and geolocation permission would not correctly swap to a new window
- Dao replaced the old fallback icon in the identity block with an SVG version
- Paolo fixed some edge cases around how PopupNotifications are displayed and hidden:
Project Mortar (PDFium)
- [evelyn] Front-end work is almost done! A few bugs remaining, but it’s pretty polish-y.
- [evelyn] Dealing with process separation work, and waiting on this bug to land which will allow us to create a special type of JS-implemented plugin
- [evelyn] Tackling the printing engine as well
- Blocked on spinning up QA help for manual testing, but we will first add more automation test and compare the result of pdf.js to understand how much improvement we gain. (Thanks to Benjamin’s suggestion!)
- Talking to release team on release to-dos
Quality of Experience
- We’re now doing off-main-thread animation on tab throbbers, which should improve perceived smoothness
- New preferences organization should land sometime this week
- Engineers now mostly segueing into Photon stuff (which should will probably get its own section in future meetings?).
- Phase 1 of the hi-res favicons work should land before the next meeting.
- The last big issue with one-off search buttons in the awesomebar is very close to landing.
- Various miscellaneous fixes for the search and location bars.
Sync / Firefox Accounts
- Push-driven sign-in confirmation is coming! Design doc in progress; should have more updates in the next meeting.
- If you’re curious…
- [fischer] The project target due date is 4/17.
- [fischer] The implementations are almost done. The remained 3 bugs are expected to be resolved before the target 4/17.
- [fischer] Bug 1312349: Hide the section of Offline Web Content and User Data in about:preferences
- Because the Storage management handles appcache as well, after the Storage management completes, the Offline(Appcache) group will be hidden.
- The pref to control hide the Offline group is browser.preferences.offlinegroup.enabled
- Firefox Screenshots (formerly Page Shot) is still on track for beta uplift in 54
- Special thanks to Mark Banner for writing the patch for Firefox, and Dave Townsend and Kris Maglione for reviewing the add-on.
- If interested in learning more, #screenshots on IRC or see our 54 tracking spreadsheet
- We are trying to track down some performance issues with the Test Pilot addon (“Test Pilot is making FF run slowly”). Any advice is welcome, ping fzzzy in #testpilot
- First ever Test Pilot QA community event happened in Bangladesh last week!
- Volunteers installed Test Pilot & did some manual testing of the Test Pilot addon and experiment addons
- Pleaseshare your ideas for new Firefox features! 🔥🦊🎉