234
edits
User:Sspitzer/GlobalFrecency: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
No edit summary |
||
| Line 78: | Line 78: | ||
like unvisited livemark items, place: queries should not show up in autocomplete results. using IsQueryURI(), I check if the place url is place:..., and if so, pass in false for isBookmark to CalculateFrecency() so that they stay hidden until visited (or in the case of place: urls, always.) because the frecency is zero (passing in PR_TRUE for isBookmark would result in non-zero frecency), we will also no recalculate frecency on idle. only upon visit. | like unvisited livemark items, place: queries should not show up in autocomplete results. using IsQueryURI(), I check if the place url is place:..., and if so, pass in false for isBookmark to CalculateFrecency() so that they stay hidden until visited (or in the case of place: urls, always.) because the frecency is zero (passing in PR_TRUE for isBookmark would result in non-zero frecency), we will also no recalculate frecency on idle. only upon visit. | ||
12) on clear all data, resetting frecency and visit count to 0 (see bug #394133) | 12) on clear all data, resetting frecency to -1 and visit count to 0 (see bug #394133) | ||
13) on expiration, I reset frecency to -1 and visit count 0, as we can't trust either anymore. in the code that recalcs frecency, if old frecency is -1, we recalc visit count and update it. | |||
'''todo''' | '''todo''' | ||
| Line 184: | Line 186: | ||
recalc on bm import / restore | recalc on bm import / restore | ||
x) | |||
XXX when removing duplicate ids, should we be resetting recency to -1? | |||