From MozillaWiki
Jump to: navigation, search

Docshell Documentation

The goal of this page is to serve as a dumping/organization ground for docshell docs. When someone finds out something, it should be added here in a reasonable way. By the time this gets unwieldy, hopefully we will have enough material for several actual docs on what docshell does and why.

Some of these sections need writing, and we may need other sections... Feel free to rearrange as needed

Interfaces Implemented by Docshell

Docshell implement the following interfaces

  • nsIDocShell LXR
  • nsIDocShellTreeItem LXR
  • nsIDocShellTreeNode LXR
  • nsIDocShellHistory LXR
  • nsIWebNavigation LXR
  • nsIBaseWindow LXR
  • nsIScrollable LXR
  • nsITextScroll LXR
  • nsIDocCharset LXR
  • nsIContentViewerContainer LXR
  • nsIInterfaceRequestor LXR
  • nsIScriptGlobalObjectOwner LXR
  • nsIRefreshURI LXR
  • nsIWebProgressListener LXR
  • nsIEditorDocShell LXR
  • nsIWebPageDescriptor LXR
  • nsIWebShellServices LXR
  • nsILinkHandler LXR
  • nsIClipboardCommands (why?) LXR

nsIContentViewerContainer and nsIScriptGlobalObjectOwner, do we really need those? nsIRefreshURI is probably something to merge into nsIDocShell (or even nsIWebNavigation?). nsIEditorDocshell also doesn't really need to be a separate interface.

Then again, do we want to just dump all sorts of stuff onto nsIDocShell? Not sure about that. Maybe we should look at who uses nsIDocShell and these other interfaces and why?

Session history (needs work)

URI loading (needs work)

Progress notifications (needs work)

Bugs that could need some Docshell cleanup (needs work)

  • bug 249751 Links whose onclick closes the window fail to trigger link
  • bug 84833 Calling self.close() right after calling submit() cancels submission

Current plans for docshell

DocShell/IRC_Logs has some IRC discussions concerning the future direction of docshell and docloader

Can we eliminate mOSHE/mLSHE in favor of just accessing the shistory's entry for mIndex/mRequestedIndex?

Window targeting

Current and proposed setup discussed at DocShell/Window targeting.

Completed Works

nsIWebShell removed. Thanks to bz! -- Bonsai

nsDocLoaderImpl (nsDocLoader.cpp) will be merged into nsDocShell; or rather, nsDocShell will become a subclass of nsDocLoaderImpl (bug 272471)

nsIWebShell and nsIWebShellContainer were eliminated (bug 273319)

bug 261086 - docshell does not need quite as many things in its GetInterface implementation