Firefox OS/Comms/Dialer/Sprint/1

Bugs

Bugs Taken in Planning

Bugzilla query error

Array ( [type] => error [message] => http-bad-status [params] => Array ( [0] => 406 [1] => Not Acceptable ) ) 1

• Does not include Bugs Taken but not Completed.

Bugs Taken but not Completed

Bugzilla query error

Array ( [type] => error [message] => http-bad-status [params] => Array ( [0] => 406 [1] => Not Acceptable ) ) 1

Bugs Taken During Sprint

Bugzilla query error

Array ( [type] => error [message] => http-bad-status [params] => Array ( [0] => 406 [1] => Not Acceptable ) ) 1

All Issues for this Sprint

Bugzilla query error

Array ( [type] => error [message] => http-bad-status [params] => Array ( [0] => 406 [1] => Not Acceptable ) ) 1

• Does not include Bugs Taken but not Completed.

Blockers Without an Assignee

Bugzilla query error

Array ( [type] => error [message] => http-bad-status [params] => Array ( [0] => 406 [1] => Not Acceptable ) ) 1

Bugs Redirected

Bugzilla query error

Array ( [type] => error [message] => http-bad-status [params] => Array ( [0] => 406 [1] => Not Acceptable ) ) 1

Daily Meetings

• Current hosts: drs, gtorodelvalle, thills
• Hosts rotate every week.

1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
2. Start by pinging everyone who should be participating.
3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
5. Move to individual updates. Go alphabetically, in descending order.
6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Day 10: July 4

Meeting Minutes

10:30 drs: ok, pretty sure everyone is here, hi 10:31 drs: so this is the end of the sprint and next sprint we will be making some additional changes, such as beginning estimations and starting to think about long-term work we can do 10:31 drs: in particular, I'd like to draw your attention to the retrospective where it would be helpful if you wrote some notes before the meeting itself: https://etherpad.mozilla.org/fxos-dialer-retrospective 10:31 drs: we can discuss them during sprint planning on monday 10:31 Rik: we will be discussing doing estimations at least :) 10:32 drs: speaking of estimations, I wrote up something on my proposed format for this: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Sprint_Planning 10:32 drs: please take a look at that and give feedback. this is based very heavily on how the SMS team does things. I figured we could start with something fairly structured and relax it as we get better at it 10:32 drs: also, do we have any takers for bug 1029581? 10:33 firebot: https://bugzil.la/1029581 — ASSIGNED, dietrich — [Dialer] Contact name is not shown in the call log after having two contacts with same number and th 10:33 drs: if not, I'll be taking it today 10:33 Rik: drs: I've started looking at it 10:33 drs: Rik: ok, so you'll take it? 10:33 Rik: but I'll leave early today (football!!!!) so I won't have a patch today 10:33 gtorodelvalle: :D 10:33 Rik: I may have one tomorrow 10:34 drs: ok, you can r? me if you want tomorrow 10:34 drs: that's it for me. etienne_s 10:34 etienne_s: same projects than yesterday, some progress : callscreen landed on 1.4 and Gabriele's USSD work landed on master 10:35 etienne_s: which is a perfection transition to... gsvelto 10:35 gsvelto: etienne_s, I'm just giving the final touches to the v1.3t uplift of the USSD patch 10:36 gsvelto: yesterday I wasted most of the day trying to fix a race in the l10n code (!) that prevented the uplifted patch from working 10:36 Rik: (LazyL10n) 10:36 gsvelto: right now I'm shedding away the promises as they shouldn't be supported on v1.3t and I don't want to risk it 10:36 etienne_s: so lazy ;) 10:36 gsvelto: yeah :) 10:36 gsvelto: there's more test coverage too 10:37 gsvelto: I wanted to do the two IMEI fix on multi-SIM devices today but I just got my flame build done so I haven't started yet 10:37 gsvelto: Maybe I'll give it a try later if I'm not too tired 10:37 gsvelto: So, who's next, gtorodelvalle maybe? 10:37 drs: yeah 10:37 gtorodelvalle: I found many issues yesterday to get https://bugzilla.mozilla.org/show_bug.cgi?id=1018283 green since I though I had broken something and it was not me (I mean the boostrap test failing and so on). Currently waiting on Travis since TBPL is OK with the patch. 10:37 firebot: Bug 1018283 — REOPENED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen 10:37 Rik: gsvelto: maybe drs can take one of those IMEI bug? 10:37 drs: (doesn't really matter, just alphabetical) 10:38 drs: Rik: I already looked into it and to be honest I don't really know what to do 10:38 drs: gsvelto: you said you were going to fix it, but it looks like a RIL issue? 10:38 gsvelto: Rik, it's a small issue and I'm familiar with the code, now that I have the build done I can fix it quickly (hopefully) 10:38 gtorodelvalle: I also removed the wallpaper showing from https://bugzilla.mozilla.org/show_bug.cgi?id=1017365 (sorry, I missed Anthony’s comment) and will ask for review in a sec. In fact, I am sending the new pull request (much simpler of course) so I guess will get the r+ soon :) 10:38 firebot: Bug 1017365 — ASSIGNED, gtorodelvalle — [V1.4][Dialer]The "Emergency number" is displayed as "Emergency nu..." 10:38 gsvelto: drs, I'm not sure yet. Either way (RIL or not RIL) it shouldn't be a big issue. 10:39 drs: gtorodelvalle: ok, I think we can land bug 1017365 pretty soon 10:39 drs: if there's any more review comments I'll just tell you over IRC 10:39 drs: Rik (if gtorodelvalle is done) 10:39 gtorodelvalle: drs: Yeah! In fact, I will join Anthony for the match :p so please do it in Github or Bugzilla so I can check my email :) 10:39 drs: gtorodelvalle: ah, okay 10:40 gtorodelvalle: :) Thanks! 10:40 Rik: I don't have anything personal to add but 10:40 Rik: there is a driver's meeting on monday morning pacific time 10:41 Rik: so closing blockers before that meeting is cool so we can look good 10:41 drs: okay. I think we can easily get down to 4 blockers if we land bug 1017365 10:41 gtorodelvalle: ;) 10:42 drs: alright, I think that's everything. thanks everyone. please check out the retrospective etherpad: https://etherpad.mozilla.org/fxos-dialer-retrospective 10:43 drs: (thills is away in case anyone was wondering, independence day in the US)

drs

• Next steps: bug 1029581 - [Dialer] Contact name is not shown in the call log after having two contacts with same number and the first one is removed
  • I'm going to take this today.
  • Nevermind, Anthony took it.
• I also want to start thinking more about long-term work that we can be doing since we're starting to really stabilize. In particular, I'm ironing out our estimations process and thinking about long-term projects.
• bug 1017365 - 1.4+ The "Emergency number" is displayed as "Emergency nu...":
  • Waiting for Germán to update this to not have the wallpaper changes, then will review.
• bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
  • This is a really gross uplift requiring some build hacks. Yuren is helping me out with this.
• bug 1030546 - 1.4+ [Emergency call] "Cancel" button is not localized
  • This is a really gross uplift requiring some build hacks. Yuren is helping me out with this.
• bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
  • Need to review this for Wei

Rik

• Helped a contributor with tablet contribution bug 1032282
• Tried to help Gabriele a bit and found a bug in the process: bug 1034279
• Fixed broken tests: bug 1032784
• Discussed MMI API design with RIL team : bug 1031193
• Started looking at bug 1029581

gsvelto

• bug 1016885 - [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background due to LMK while using Youtube app
  • The fix landed on master this morning, I'm working on the v1.3t patch which should be ready soon enough. This hasn't been nom'd for v1.4 but I have the feeling it will.
    • Rik: IMHO, when a bug is greenlit for a branch and has also landed on master, it should land on all branches up to the one it was greenlit for. We've been bitten by bug 990003 because of that. So yup, we should land it on 1.4.
  • (updated July 3rd) I landed a follow-up because of an issue on multi-SIM devices I had missed in the original patch. I've got informal approval from release management to land on 1.4 so I'll land there too. Totally agree on landing on all branches starting with the older one that got approval but hey, release management doesn't always seem to agree :-(
  • (updated July 4th) v1.3t patch is almost ready. It required some significant changes and even a fix for a bizarre race condition in the LazyL10n code. I've asked for v1.4 approval for the dependent bug and I intend to land this one on v2.0 too.
• bug 990003 - [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up
  • I had uplifted two dependencies and whipped together an almost working uplift; Etienne offered to help me out on that one to finish the uplifts.
  • (Updated July 3rd) Etienne is taking care of the final uplifts
• bug 1002327 - We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, but only one imei returns
  • No work done yet, will be starting today
  • (Updated July 3rd) No progress here yet, too busy with the other bug
  • (Updated July 4th) Finally got my Flame build working, if I'm not too tired I'll try to fix this one later today

gtorodelvalle

• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Waiting for Travis to be all green until another criteria is set for landing.
  • Yesterday I suffered from the problems with the tests failing in master since only at a late extent I noticed it was not caused by the latest version of my patch.
  • I had to ask Fernando Jiménez several times to relaunch some TBPL tasks. I just did a couple of minutes ago since there was a notification sending test failing.
• bug 1017365 - [V1.4][Dialer]The "Emergency number" is displayed as "Emergency nu...":
  • Discussing with Vicky, Anthony and Doug the fix to be implemented and the way to do it ;)
  • Sent a new pull request implementing Doug's approach but setting the wallpaper as the background as requested by Vicky.
    • Rik: I think we've been clear that the background change will NOT land in this bug. If Visual wants the background change, they need to open a bug and nominate it for 1.4.
  • Review asked from Doug.
  • Just noticed Anthony's comment so I am preparing a new version of the patch without the wallpaper fix and asked Vicky to fill a new bug for it.
• bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
  • I started working on this patch and I will send Vicky a proposal today (July, the 2nd) to try to decided on the final solution to be implemented.
  • I showed Vicky a prototype and just received Vicky's go ahead so going ahead :p
  • Launched the pull request and waiting for the test checking. Once they pass, I'll ask for review.
  • Waiting for Travis. TBPL is fine with the patch.
• Other issues:
  • I spend part of the day helping Paco with his unstable environment regarding tests. Seems to be more stable now :)

etienne

• bug 990003 and dependencies landed on 1.4, brassing for a potential backout
• Still some back and forth on Gabriele's USSD stuff, fun times

thills

• bug 1021550. need to retest on the emulator now since my new test had one tweak in the final r+ from Hsin-Yi that I want to make sure. Right now, emulator build is not working.
• bug 1030550 - Working on trying to find the root cause for this. I can repro this on the Hamachi.
  • Gecko device Build issue resolved -- Thanks drs.

Day 9: July 3

Meeting Minutes

10:31 drs: ok, let's start 10:31 drs: for starters, we're down to 6 open blockers, and all of them are having work done on them \o/ 10:32 drs: I've been looking at bug 1029581 and I think one of us should take it from dietrich because he hasn't had time to work on it 10:32 firebot: https://bugzil.la/1029581 — ASSIGNED, dietrich — [Dialer] Contact name is not shown in the call log after having two contacts with same number and th 10:32 drs: if anyone has spare cycles, it would be nice if you could take it (Rik?) 10:33 drs: anyways, that's it for me, etienne_s? 10:33 etienne_s: nothing particular, reviewing gabriele's work and waiting for the go from QA before uplifting the callscreen 10:34 drs: ok, gsvelto? 10:34 etienne_s: the window manager has 6 2.0 blockers so I'm not craving for work, next gtorodelvalle ? 10:34 etienne_s: oh gsvelto 10:34 drs: (sorry, thought you were done) 10:34 drs: (and we're just going alphabetically) 10:34 gsvelto: I've landed bug 1016885 on master 10:34 firebot: https://bugzil.la/1016885 — FIXED, gsvelto — [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background 10:34 gsvelto: It took me two tries as I had missed a particular issue on dual-SIM device but now it's good 10:34 gsvelto: And there's additional test coverage 10:35 drs: nice 10:35 gsvelto: I'm in the process of cherry-picking it to v1.3t but I'm hitting an issue where LazyL10n doesn't always invoke the initialization callback I give it when starting up 10:35 gsvelto: And I've got no clue why :-/ 10:35 gsvelto: So this is it basically 10:35 drs: maybe I can take a look, I've run into similar things before 10:35 Rik: gsvelto: I can help after the meeting for the LazyL10n 10:35 drs: ok, or Rik 10:36 gsvelto: Rik, OK, this is 1.3T only BTW 10:36 drs: ok, better if Rik looks then 10:36 drs: gtorodelvalle? 10:36 gtorodelvalle: I merged this morning the PR about the visual refresh pending issues of the call screen when the lock screen is enabled but was reverted since the tests were not passing in TBPL. Currently trying Anthony’s recommendation to substitute requireApp() by require(). Apart from this I sent the pull request about the baseline bug (already ui-reviewed+ by Vicky) and I am currently waiting for the tests to pass to 10:36 gtorodelvalle: ask for review ;) 10:36 drs: ok, please make sure you're prioritizing blockers 10:37 drs: Rik 10:37 Rik: I'll probably take Dietrich's blocker 10:37 Rik: I'm in the middle of reviews 10:38 drs: ok, thanks 10:38 Rik: for the other blocker I'm currently assigned, I'll wait for thills update and discuss with her after the meeting 10:38 drs: sure 10:38 drs: thills 10:39 thills: so, I'm having some build issues at the moment… on B2G... 10:39 thills: I am trying to sort that out. 10:39 thills: I did try to repro the BT bug 10:39 drs: would you like some help on that after the meeting? 10:39 thills: yes, gladly… :) 10:39 drs: ok, I'll help 10:40 thills: thanks, because I wanted to test once more on device before landing bug 1021550 10:40 firebot: https://bugzil.la/1021550 — ASSIGNED, thills — [Phone][Ring Tone] The ring tone is muted after first call used speaker. 10:40 Rik: drs: maybe you should help gsvelto and I'll help thills rather since I already looked at that bug 10:40 drs: Rik: I don't have my tarako handy :/ 10:41 Rik: (gtorodelvalle: Greg is also suggesting require() on the bug) 10:41 gtorodelvalle: Rik: Hopefully that’s the issue ;) 10:41 drs: ok, I think that's the end of the meeting. we're getting into discussion now 10:41 drs: thanks everyone 10:41 drs: good turnout again, btw 10:41 drs: and only 1 minute over

drs

• Next steps: bug 1029581 - [Dialer] Contact name is not shown in the call log after having two contacts with same number and the first one is removed
  • Currently assigned to Dietrich, but he hasn't worked on it for a while. I think someone should take this, so I will if nobody else wants to.
• I also want to start thinking more about long-term work that we can be doing since we're starting to really stabilize. In particular, I'm ironing out our estimations process and thinking about long-term projects.
• bug 1017365 - 1.4+ The "Emergency number" is displayed as "Emergency nu...":
  • Need to review this for Germán
• bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
  • Landed on master, but I'm not sure how this is going to get uplifted.
• bug 1030546 - 1.4+ [Emergency call] "Cancel" button is not localized
  • Landed on master, but I'm not sure how this is going to get uplifted.
• bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
  • Need to review this for Wei

Rik

• Wednesday is my "Gaia quality afternoon" so not much done on Dialer
• Reviews in progress, no bug assigned, I can help on your bugs
  • drs: Should we move bug 1030550 to Tamara?

gsvelto

• bug 1016885 - [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background due to LMK while using Youtube app
  • The fix landed on master this morning, I'm working on the v1.3t patch which should be ready soon enough. This hasn't been nom'd for v1.4 but I have the feeling it will.
    • Rik: IMHO, when a bug is greenlit for a branch and has also landed on master, it should land on all branches up to the one it was greenlit for. We've been bitten by bug 990003 because of that. So yup, we should land it on 1.4.
  • (updated July 3rd) I landed a follow-up because of an issue on multi-SIM devices I had missed in the original patch. I've got informal approval from release management to land on 1.4 so I'll land there too. Totally agree on landing on all branches starting with the older one that got approval but hey, release management doesn't always seem to agree :-(
• bug 990003 - [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up
  • I had uplifted two dependencies and whipped together an almost working uplift; Etienne offered to help me out on that one to finish the uplifts.
  • (Updated July 3rd) Etienne is taking care of the final uplifts
• bug 1002327 - We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, but only one imei returns
  • No work done yet, will be starting today
  • (Updated July 3rd) No progress here yet, too busy with the other bug

gtorodelvalle

• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Waiting for Travis to be all green until another criteria is set for landing.
• bug 1017365 - [V1.4][Dialer]The "Emergency number" is displayed as "Emergency nu...":
  • Discussing with Vicky, Anthony and Doug the fix to be implemented and the way to do it ;)
  • Sent a new pull request implementing Doug's approach but setting the wallpaper as the background as requested by Vicky.
    • Rik: I think we've been clear that the background change will NOT land in this bug. If Visual wants the background change, they need to open a bug and nominate it for 1.4.
  • Review asked from Doug.
• bug 1031257 - User can't see "multicall" name in the upper information panel:
  • I started working on this bug but when testing it many call screen issues arose which seem to be related to bug 1031227 I spent some time with Fernando González Sela providing him with the logs he needed.
  • Seems to be solved and everything back to normal. Loli will re-check tomorrow (3/7).
• bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
  • I started working on this patch and I will send Vicky a proposal today (July, the 2nd) to try to decided on the final solution to be implemented.
  • I showed Vicky a prototype and just received Vicky's go ahead so going ahead :p
  • Launched the pull request and waiting for the test checking. Once they pass, I'll ask for review.

etienne

• bug 990003 and dependencies are ready for uplift (waiting on a QA round)
• Looking at a intermittent Audio channel issue caused by the TonePlayer (bug 1029979)
• Finished reviewing Gabriele's USSD notification patch (bug 1016885)

thills

• bug 1021550. Received an r+ from Hsin-Yi on this bug. Need to find someone with level 3 permissions to help check in.
  • drs: You can add the checkin-needed keyword on Bugzilla, or I can land it for you.
• bug 1030550 Started looking at this and trying to repro with Hamachi. I tried the workaround with my BT set that does not have the conf feature.

I'm generally struggling with build issues on B2G right now that have taken up a big amount of time.

• • drs: What in particular?

Day 8: July 2

Meeting Minutes

10:31 drs: ok, hi everyone. great turnout again today 10:31 drs: I'll start. aside from the stuff I listed on the etherpad, I also investigated bug 1019783 to help take some pressure off of gsvelto 10:31 firebot: https://bugzil.la/1019783 — REOPENED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI 10:32 drs: unfortunately I couldn't repro the expected behavior so it doesn't look like a regression to me, it just never worked 10:32 drs: also I left a note of feedback I'd like from Rik on the etherpad 10:32 gsvelto: drs, yeah, I was about to address that one now that I'm done with 1016885 10:32 drs: gsvelto: ok, great 10:32 drs: also, great work everyone, the list of blockers is steadily declining 10:32 drs: I think we'll be stable by mid next sprint 10:33 drs: that's it for me 10:33 drs: etienne_s 10:33 drs: (oh and gsvelto we can talk about that bug after the meeting if you'd like) 10:33 etienne_s: reviews this morning including one that took a while because of an integration test issue (see wiki), working on the callscreen uplift this afternoon, looks like I just found the missing dependence 10:34 etienne_s: so I just opened https://github.com/mozilla-b2g/gaia/pull/21282, will comment more on the bug, next one! 10:34 gsvelto: drs, sure 10:34 drs: etienne_s: oh yeah, that reminds me, I'll be fixing up my patch to only move around the english strings (bug 1030546) and I'll ask you for review again since l10n patches are pretty delicate 10:34 firebot: https://bugzil.la/1030546 — ASSIGNED, drs+bugzilla — [Emergency call] "Cancel" button is not localized 10:34 drs: etienne_s: ok, is that everything for you? 10:35 etienne_s: drs: yes, that's why I said "next one!" :) 10:35 drs: sorry, missed that :) gsvelto 10:35 gsvelto: yeah so etienne_s offered to help me out finish bug 990003 and that alone made my day 10:35 firebot: https://bugzil.la/990003 — FIXED, etienne — [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up 10:35 gsvelto: I couldn't get a v1.4 build working yesterday so I was feeling really stressed about that 10:36 gsvelto: Anyway only two patches and a small change should be missing for the uplift 10:36 gsvelto: Bug 1016885 landed on master and I'm uplifting it to v1.3t 10:36 firebot: https://bugzil.la/1016885 — FIXED, gsvelto — [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background 10:36 drs: gsvelto: what's up with the v1.4 build? 10:36 gsvelto: My hamachi didn't like it 10:36 drs: oh :/ do you have a flame? 10:36 gsvelto: I'm now trying to get it working on a dolphin 10:36 etienne_s: gsvelto: on that note, I used B2G-flash-tool and it worked well 10:37 drs: yeah, same 10:37 gsvelto: etienne_s, thanks, I'll try to use that, wasted a lot of time on this issue 10:37 gtorodelvalle: gsvelto: Uhm... Maybe I can pass you the one generated here in Telefónica... It worked for me :) 10:37 gsvelto: Anyway I've got a flame too, but I've got master on that for bug 1002327 which is my next bug 10:37 drs: gsvelto: https://github.com/Mozilla-TWQA/B2G-flash-tool 10:37 firebot: https://bugzil.la/1002327 — FIXED, gsvelto — We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, bu 10:37 gsvelto: I'll work on it today 10:37 gsvelto: This is all for me more or less 10:37 drs: ok, thanks. gtorodelvalle 10:37 gtorodelvalle: Nothing to point out on my side apart from what I wrote in Etherpad. Maybe just mentioning that I sent a new pull request for the 1.4 blocker implementing Doug's approach and asked Doug for review ;) 10:38 drs: gtorodelvalle: yeah, the next thing I'm going to do is review that 10:38 gtorodelvalle: He, he ;) Thanks! 10:38 drs: Rik 10:38 Rik: nothing important to call out for me 10:39 drs: ok, thills 10:39 thills: ok, so only thing other than what's in etherpad… is I was planning on goign back to work on bug 1016698 10:39 firebot: https://bugzil.la/1016698 — UNCONFIRMED, thills — [Settings] When changing APN settings, data roaming is not enabled automatically 10:39 drs: gtorodelvalle: also, thanks for writing out what you wanted to say before being pinged :) 10:39 thills: which isn't a dialer bug... 10:40 thills: so, just wanted to check on priority there 10:40 drs: thills: ok, in that case, we don't really have someone to work on 1029721 10:40 drs: bug 1029721 10:40 firebot: https://bugzil.la/1029721 — NEW — CDMA call waiting call is not logged in call history 10:40 drs: did you investigate that anymore after sending the emails to the emulator people? 10:40 thills: ok, so I saw Etienne's note on that 10:40 gsvelto: drs, that's likely going to be a wontfix 10:40 thills: that it's a major undertaking and we should talk to the release people about reprioritizing 10:41 drs: should we renom it? 10:41 etienne_s: yes 10:41 gsvelto: +1 10:41 drs: ok, done 10:42 drs: alright, in that case, thills I think it's fine if you work on that 10:42 drs: is it an RIL bug? 10:42 thills: it's actually started as one... 10:42 thills: but now it's more of a setttings issue 10:43 drs: if it became a settings bug, then it's a bit out of our realm, but if it appeals to you I think we can spare the cycles 10:43 drs: (meeting over, thanks everyone!) 10:43 Rik: thills: I can recommend https://bugzilla.mozilla.org/show_bug.cgi?id=1030550#c5 10:44 firebot: Bug 1030550 — NEW, anthony — [Dialer][Bluetooth] Callscreen app sometimes calls BT command "CHLD=3" twice when it only receive on 10:44 drs: (only 3 minutes over target, btw)

drs

• Next steps: Find more blockers to work on. It looks like most of the unassigned ones have been taken and/or fixed. As usual, let me know if you need help with something.
• bug 1017365 - 1.4+ The "Emergency number" is displayed as "Emergency nu...":
  • Proposed an alternative that Germán implemented, now sitting in review. I plan on getting to this in a few hours.
• bug 1032502 - 2.0+ The phone label of an incoming call on the lockscreen is not translated.
  • Patch posted, review? to Francisco. This is a pretty simple l10n issue. I didn't understand that the l10n files are located offsite though and I made a mistake because of this, so I'll have to fix that.
• bug 1030546 - 2.0+ [Emergency call] "Cancel" button is not localized
  • Patch posted, ~review+ from Etienne. This is a pretty simple l10n issue. I didn't understand that the l10n files are located offsite though and I made a mistake because of this, so I'll have to fix that.
• bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
  • Review-, redirected to Carrie for UX question. This isn't a blocker so it's low priority.
• bug 1033127 - it will always ask user to select sim before calling in call log even if the default sim for outgoing call had been set yet
  • Feedback-. I don't think this is actually a problem and this bug is in triage for 1.4? status.
• bug 1019783 - Output from *#06# on FLAME DIALER used to return 2 IMEI
  • I was unable to repro the desired functionality which was supposedly broken some time ago. gsvelto and I believe that they may have been using different firmware. gsvelto is going to write a fix for this even though we don't believe that it's a regression.

Rik

• drs: see bug 1017365 please, I would like your feedback on my proposal
  • I'd prefer needinfos, I'm not checking this before the meeting
• bug 1030550 - Callscreen app sometimes calls BT command "CHLD=3" twice when it only receive one system message
  • It is probably a Gecko issue, needinfoed Gene on it.

gsvelto

• bug 1016885 - [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background due to LMK while using Youtube app
  • The fix landed on master this morning, I'm working on the v1.3t patch which should be ready soon enough. This hasn't been nom'd for v1.4 but I have the feeling it will.
• bug 990003 - [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up
  • I had uplifted two dependencies and whipped together an almost working uplift; Etienne offered to help me out on that one to finish the uplifts.
• bug 1002327 - We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, but only one imei returns
  • No work done yet, will be starting today

gtorodelvalle

• Weren't we suppose to update the wiki instead of using Etherpad? I do not see updates at FirefoxOS/Comms/Dialer ? Am I pointing to the wrong place? Thanks!
  • drs: We moved back to Etherpad because people prefer its ease of use. Also, we can discuss things like I'm doing now.
• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Waiting for Travis to be all green until another criteria is set for landing.
• bug 1017365 - [V1.4][Dialer]The "Emergency number" is displayed as "Emergency nu...":
  • Discussing with Vicky, Anthony and Doug the fix to be implemented and the way to do it ;)
  • Sent a new pull request implementing Doug's approach but setting the wallpaper as the background as requested by Vicky.
  • Review asked from Doug.
• bug 1031257 - User can't see "multicall" name in the upper information panel:
  • I started working on this bug but when testing it many call screen issues arose which seem to be related to bug 1031227 I spent some time with Fernando González Sela providing him with the logs he needed.
  • Seems to be solved and everything back to normal. Loli will re-check tomorrow (3/7).
• bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
  • I started working on this patch and I will send Vicky a proposal today (July, the 2nd) to try to decided on the final solution to be implemented.
  • I showed Vicky a prototype and just received Vicky's go ahead so going ahead :p

etienne

• Quick l10n related review for Doug
• Long review comment on bug 1018494 introducing Paco to the integration tests
• Working the on the uplift from hell (bug 990003)

thills

• bug 1021550. I received feedback this morning from Hsin-Yi on this patch and had some minor issues to fix. I fixed those this morning and reposted for her review again.
• Next Steps: finish of bug 1021550 once I get the r+ from Hsin-Yi. It looks like all the blockers are taken or waiting on someone else, so I will go back to working on bug 1016698 unless there is something higher priority (need feedback from team on this).
  • drs: Rik suggested taking bug 1030550.

Day 7: July 1

Meeting Minutes

10:30 drs: ok, hi everyone, looks like we have a thinner crowd today 10:30 drs: etienne_s: are you here? 10:30 thills: hello 10:30 etienne_s: drs: present 10:31 drs: ok, I'll start with my updates. I've been taking any remaining unassigned 2.0+ blockers 10:31 drs: and like yesterday if anyone needs any help with anything I can probably spare some time as my top priority is knocking down the number of blockers 10:31 drs: that's it for me 10:31 gsvelto has joined (gsvelto@A73312E.6B878F99.18F3A0C.IP) 10:31 drs: hi gsvelto 10:32 gsvelto: hi there 10:32 drs: gsvelto: here's the scrollback: https://pastebin.mozilla.org/5503714 10:32 etienne_s: reviewing gsvelto blocker patch, my window manager work is under control, will move to 2.0 dialer blocker today 10:32 CarrieW has joined (CarrieWang@9D890E88.52810896.9C245056.IP) 10:32 drs: etienne_s: do you know which one(s) you'll be able to take? 10:32 etienne_s: also I already miss the low friction of the etherpad 10:33 etienne_s: drs: Rik just took the one I had on my list actually 10:33 drs: ok :) in that case I'll probably ask you for review on bug 1030546 10:33 firebot: https://bugzil.la/1030546 — NEW, drs+bugzilla — [Emergency call] "Cancel" button is not localized 10:33 etienne_s: drs: and I don't think taking many of them is efficient, since it discourage other people from taking them 10:34 drs: do others agree about etherpad vs. wiki? 10:34 drs: (writing your daily notes into an etherpad instead of on the wiki) 10:34 Rik: etienne_s: I'll need another BT headset though, mine doesn't have the merge feature 10:34 gsvelto: I'm OK with both 10:35 thills: either is fine with me 10:35 gsvelto: though yeah, etherpad tends to be easier to deal with 10:35 drs: ok, I don't mind moving it over every day, so I think we should go back to etherpad 10:35 drs: julienw has a script for doing it too 10:35 etienne_s: cool 10:35 drs: ok next up is gsvelto (if you're done etienne_s) 10:36 etienne_s: yes 10:36 gsvelto: good news and bad news 10:36 gsvelto: on the good news front I've finished the present-unsollicited-USSD-messages-as-notifications patch and it seem to work nicely 10:36 gsvelto: I still have to prepare a version for v1.3t though 10:37 gsvelto: this is bug 1016885 10:37 firebot: https://bugzil.la/1016885 — ASSIGNED, gsvelto — [Tarako][Dolphin][LMK][Youtube][USSD] Pop-up USSD message causes Youtube being killed at background 10:37 gsvelto: On the bad news front I'm stuck with the uplift of bug 990003 10:37 firebot: https://bugzil.la/990003 — FIXED, etienne — [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up 10:37 gsvelto: I've got a patch that works up to the point when you end a call 10:37 drs: what's wrong with it? 10:37 gsvelto: Once that's done the callscreen goes away but the homescreen remains invisible 10:37 etienne_s: gsvelto: I can probably help 10:37 gsvelto: And I've got no clue why, I've checked if I was missing some dependency and I think I don't 10:38 gsvelto: And BTW I've been struggling all day to flash a working v1.4 on my hamachi which doesn't help :( 10:38 gsvelto: etienne_s, help will be much appreciated 10:38 etienne_s: gsvelto: ping me with a branch and I'll have a look 10:38 gsvelto: https://github.com/gabrielesvelto/gaia/tree/callscreen-uplift 10:39 drs: ok, anything else gsvelto? 10:39 gsvelto: I also have to work on bug 1019783, haven't started yet so if someone wants to steal it from me it's up for grabs 10:39 firebot: https://bugzil.la/1019783 — REOPENED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI 10:39 gsvelto: And this is more or less all 10:39 drs: I think everyone has something to do for now, but I might get to that if I have time 10:40 drs: ok, next up is Rik 10:40 drs: (damn we're over time already :) but not as badly as yesterday I don't think) 10:41 Rik: well, what's in the wiki + I'll need another bluetooth headset 10:41 etienne_s: drops bt headset on Rik's desk 10:41 drs: Rik: well, is there anything you want to specifically draw our attention to? 10:41 Rik: not really 10:41 drs: ok, thanks 10:41 drs: next up is thills 10:42 thills: so, what's in the wiki, plus, am looking for a new one… since am waiting for review on that 10:43 drs: thills: maybe you can work with gsvelto on the CDMA bug? (bug 1029721) 10:43 firebot: https://bugzil.la/1029721 — NEW — CDMA call waiting call is not logged in call history 10:43 thills: I did not hear back on the CDMA device from Brian Huang 10:43 drs: yeah, gsvelto has a process for doing CDMA work without a device 10:43 thills: ok… will ping him about that then 10:43 drs: my notes on this: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/CDMA 10:43 drs: and you can chat with him after 10:43 thills: great thanks. 10:44 drs: ok cool, I think that's everything. does anyone have anything else? 10:44 drs: (4 minutes overtime, 9 minutes yesterday :) ) 10:44 drs: ok, thanks everyone 10:44 thills: thanks! 10:44 gsvelto: thanks, catch you tomorrow! 10:44 Rik: actually I have something :) 10:45 Rik: if anyone is looking for bugs, https://bugzilla.mozilla.org/show_bug.cgi?id=1032784 would be good to look at 10:45 firebot: Bug 1032784 — NEW — Some MMI unit tests are broken 10:45 drs: ok, I'll add that to this sprint even though it's not a blocker

drs

• bug 1030760 - Invalid warning message after call a two digit number
  • Investigated and redirected to Hsin-Yi as it seemed like a RIL issue.
  • Hsin-Yi says that the reporter didn't test the functionality correctly. They're currently in discussion.
• bug 1030546 - [Emergency call] "Cancel" button is not localized
  • I just took this and started working on it. It seems like a pretty easy fix.

Rik

• I'm almost done with catching up.
• Investigated bug 1032784 Some MMI unit tests are broken
• I'm taking bug 1030550 Callscreen app sometimes calls BT command "CHLD=3" twice when it only receive one system message

gtorodelvalle

• Trying to help Paco with his X Files (test environment and failures) and Fernando with his bug 1031227 which seems to be causing some malfunctioning in the Call Screen app :(
• Apart from this, making progress on the baseline bug bug 1010104 discussing it with Vicky since it seems to be of “high interest” and to be nominated soon :) Cheers!

etienne

• Reviewed bug 1016885

thills

• bug 1021550 - [Phone][Ring Tone] The ring tone is muted after first call used speaker.
  • Patch in for re-review after combining the test.
  • Looking for a new bug to work on.

Day 6: June 30

Meeting Minutes

10:31 drs: ok cool, hi everyone 10:32 drs: we already have a better record than the other teams :D 10:32 gtorodelvalle: \o/ 10:32 drs: they usually have 1 person missing from their dailies 10:32 drs: anyways thanks for filling in your info on the etherpad 10:32 drs: Rik has suggested writing directly into the wiki 10:32 drs: so I think we'll do that next time, it seems like a better idea to me 10:33 drs: anyways I'll start. like I wrote on the wiki, we're not going to talk about everything we did here, just talk about anything that we think others should know about 10:33 drs: in particular I've cleared all my 2.0+ blockers and I'm taking the unassigned ones 10:33 drs: does anyone need any help with anything? I can take whatever at this point 10:34 drs: ok, I guess not. so here's the list of blockers: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/1#Blockers_Without_an_Assignee 10:34 gtorodelvalle: Just mentioning that I will be done with my bugs as soon as Travis or TBPL are also fine with them so if anyone needs help, just ping me… I will contact Mari Ángeles regarding where to focus next ;) 10:34 thills: I think I'm ok with mine. I started looking at some of the unassigned 10:34 drs: the unassigned ones look mostly like gsvelto would know about them 10:35 drs: but he's not here unfortunately so we can't really ask him about them 10:35 drs: anyways that's it for me. 10:35 drs: etienne_s: ? 10:35 drs: (alphabetically going next) 10:35 etienne_s: Almost done with reviews, next for me is bug 1023794 (windowmanager/callscreen) 2.0+ 10:35 firebot: https://bugzil.la/1023794 — NEW — Dialer][Call Screen] UI moved up when entering another apps and back to call screen 10:36 etienne_s: got pinged on a contact matching issue but not blocking so lower priority 10:36 etienne_s: next is gtorodelvalle ? 10:36 drs: etienne_s: can you take any of the unassigned? 10:36 drs: we're still at 12 open blockers 10:37 etienne_s: drs: I'll know more after the systemfe meetings today 10:37 drs: ok 10:37 drs: I've been looking at bug 1030760 btw 10:37 firebot: https://bugzil.la/1030760 — NEW — Invalid warning message after call a two digit number 10:37 drs: I suspect it may be an RIL issue though 10:37 drs: (or somewhere in platform) 10:37 drs: gtorodelvalle, you're next 10:38 gtorodelvalle: As I said, I am almost done with all the bugs assigned to me on this sprint (thanks to Doug for taking one of them ;) ) so I’ll move to unassigned ones ;) No problems or issues to raise apart from deciding about the way to proceed regarding the landing of the bugs (tests I mean :) ) 10:38 drs: ok, cool. if you need any help with tests or figuring out if something is intermittent, feel free to ask us 10:38 gtorodelvalle: Fine Thanks! 10:38 Rik: gtorodelvalle: about the emergency bug, I think we can special case the emergency case 10:39 gtorodelvalle: You mean the 1.4 blocker, right? 10:39 Rik: yup 10:39 gtorodelvalle: What do you mean about “special case”? 10:39 Rik: something like if(emergency number) { forceFontSize() } 10:40 gtorodelvalle: I prepared a patch for 1.4 :) 10:40 gtorodelvalle: And asked Etienne for review 10:40 drs: for onlookers, I believe they're referring to bug 1017365 10:40 firebot: https://bugzil.la/1017365 — NEW, gtorodelvalle — [Flame][V1.4][Dialer]The "Emergency number" is displayed as "Emergency nu..." and the text colour of 10:40 Rik: gtorodelvalle: what kind of patch is it? 10:40 gtorodelvalle: https://github.com/mozilla-b2g/gaia/pull/21180 10:40 Rik: I mean what is it doing? 10:41 Rik: because we also need to consider the risks of a patch 10:41 gtorodelvalle: Just assuring that for Emergency Calls the text “Emergency number” is displayed fine and that the wallpaper is used instead of the “ring bell” as Vicky commented in the bug 10:41 drs: do you guys mind holding this discussion for now? 10:41 gtorodelvalle: Kind of easy patch := 10:41 drs: if we get thills' update, we can come back to this 10:41 Rik: sure drs 10:41 gtorodelvalle: Sure! I can set ANthony as the reviewer ;) 10:42 drs: thills, how's it going? 10:42 thills: so, I am trying to wrap up 1021550 10:42 Rik: (my update is : if you need something, tell me on IRC) 10:42 drs: bug 1021550 10:42 firebot: https://bugzil.la/1021550 — NEW, thills — [Phone][Ring Tone] The ring tone is muted after first call used speaker. 10:42 thills: To be honest, I had a lot of troubles with the emulator last week 10:42 gsvelto has joined (gsvelto@31347ED4.2DFD46DA.6C61825E.IP) 10:42 drs: hi gsvelto 10:42 gsvelto: hiya everybody, sorry I'm late 10:43 drs: it's ok, we wanted to chat with you about the unassigned blockers though 10:43 drs: thills is in the middle of her update though 10:43 gsvelto: OK 10:43 thills: so, I finally have that going… Got an initial feedback from Hsin-Yi and going to put it as a patch as soon as my latest try run finishes 10:44 drs: nice, ok. do you have any followup work to do? 10:44 thills: so, I think that is moving along… I started looking for unassigned ones 10:44 thills: in the blocker list. I was looking at the CDMA one, and trying to figure out how we can test that. 10:45 drs: gsvelto: ^ 10:45 gsvelto: we had a quick discussion on IRC and we currently have two ways: a CDMA-enabled device (e.g. wasabi) and the appropriate network or the emulator 10:45 gsvelto: I think the emulator has support for CDMA networks in the telephony code but I'm not sure how to use it or if it's documented at all 10:45 drs: did you find anymore information about running CDMA on an emulator? 10:45 drs: ah, ok 10:46 drs: I can get in contact with the people you mentioned to me are working on the emulator 10:46 gsvelto: OK, now I can confirm it's not finished yet, bug 865957 10:46 firebot: https://bugzil.la/865957 — NEW — [meta] B2G Emulator: support CDMA 10:46 gsvelto: Still open :( 10:47 drs: that sucks. maybe if we push them we'll get some progress on it 10:47 Rik: do we want to push for the emulator or for mulet? 10:48 drs: the emulator. mulet can't really support CDMA 10:48 gsvelto: I'd push for the emulator, we've already got most of the telephony stack emulated there 10:48 gsvelto: It's just a matter of leveraging it for tests 10:48 drs: gsvelto: have you looked at the unassigned blockers? https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/1#Blockers_Without_an_Assignee 10:49 drs: gsvelto: it looks like you would know about most of them. you missed this but I cleared all my 2.0+ blockers and gtorodelvalle says he will be soon too 10:50 drs: so we can help with these, though it's not really our area of expertise 10:50 gtorodelvalle: :) 10:50 drs: (I think we can say the meeting is over at this point, we're getting into discussion now. thanks everyone!) 10:51 drs: (and we ran a few minutes over but that's ok, we'll get the hang of it)

drs

• bug 1024460 - [Dialer][Conference] In multiconference, Contact's name or phone number is duplicate.
  • Stole this because it looks like Germán is busy with other stuff.
  • Landed a fix.
• bug 1031916 - [Dialer][Conference] Conference call status bar is invisible, can't exit conference call view
  • Landed a fix.
• bug 1030980 - [Dialer] The user is unable to pull down the utility tray while in a call
  • This was caused by a bad patch to system which didn't fix the original problem, so I backed out that patch and reso duplicated this bug to that one.
• bug 1030760 - [USSD/MMI] Invalid warning message after call a two digit number
  • I started investigating this. It looks like a RIL issue, but I'm not sure yet.

Rik

• Getting back in the game, nothing major to call out
• bug 1031193 - API compatibility to unify both sendMMI() and dial
  • Proposed an alternative plan that involves less work for Gaia and I hope a small increase of work for Gecko
• Until next standup: still catching up, so not a lot of visibility and my actions will be dictated by emails/needinfos/reviews probably. If you need my attention earlier, please tell me directly on IRC.
• Leaving early today to watch France kick some ass in the world cup

gtorodelvalle

• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Implemented the latest specs provided by Pau.
  • Obtained the ui-review+ by Vicky.
  • Travis is red due tu a test case of the Music app failing. As mentioned by Doug in IRC, it is OK to land it :p
• bug 1017365 - [Flame][V1.4][Dialer]The "Emergency number" is displayed as "Emergency nu..." and the text colour of "Connecting" and "via SIM1" is close to the background when you MO an Emergency call
  • Just started working on this bug. Since it is a 1.4 blocker, we will try to find a compromised solution with UX since trying to cherry-pick the adaptable font size patch could be risky.
  • ui-review+ by Vicky
  • Under review and Travis checking.

etienne

• Reviewing Doug's patches
• Feedbacking Gabriele's USSD + notification work
• Discussing cert-automation on bug 997248
• Trying to make sense of partner bug 1031652

thills

• bug 1021550 - [Phone] [RingTone] The ring tone is muted after first use of the speaker.
  • I had initial feedback from Hsin-Yi on this that it looks good. I lost quite a bit of time last week getting the marionette emulator to work on the Mac so I could run the marionette-webapi tests. That is finally resolved, so I was able to modify the test based on the fix. Hope to wrap this up in next day or so.

Day 5: June 27

No meeting minutes (there was no meeting).

drs

• bug 1019546 - Dialpad and Contacts are overlapped when switching between them
  • Landed and uplifted.

Rik

• on PTO until June 30

gsvelto

• bug 993018 - Make the "place new call" feature independent of the callscreen->appwindow message channel
  • Prepared a cherry-picked patch for uplifting to v1.4
• bug 992948 - Use the telephony-call-ended system message to fill call log
  • Likewise
• bug 990003 - [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up
  • Likewise, this required some modifications, I'm now testing the functionality of the three aggregated patches on a device
• bug 1019370 - [dolphin] dolphin always shows SIM 1's USSD message for Sim 2.
  • The fix is already available in bug 1002327 and I've cooked up a v1.4-specific patch but I'm waiting for the three previous bugs to land on v1.4 before landing this
• bug 970187 - [Dialer] Support CDMA 3-way (conference) calls
  • I did the final review for this bug, it's waiting for agreen Travis run to land

gtorodelvalle

• bug 1007709 - [Dialer][Call Screen] Create fluid size for contact name in the upper information panel:
  • Landed in master and v2.0 after being some days in quarantine as a consequence of some intermittent tests observed in TBPL.
• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Implemented the latest specs provided by Pau.
  • Obtained the ui-review+ by Vicky.
  • Currently waiting for Travis verdict.
• bug 1017365 - [Flame][V1.4][Dialer]The "Emergency number" is displayed as "Emergency nu..." and the text colour of "Connecting" and "via SIM1" is close to the background when you MO an Emergency call
  • Just started working on this bug. Since it is a 1.4 blocker, we will try to find a compromised solution with UX since trying to cherry-pick the adaptable font size patch could be risky.

etienne

• Landed bug 1028039 (window manager issue) which was blocking Gabriele's USSD work.
• Feedbacking audio compete issues (re: loop) in bug 1016277
• Nth review round for the airplane mode lag patch bug 996863
• Review for the call log APZC issue (building block related) bug 1022746

Day 4: June 26

No meeting minutes (there was no meeting).

drs

• bug 1007709 - Create fluid size for contact name in the upper information panel
  • Reviewed and landed after some problems with intermittents
• bug 1022746 - The call log isn't using APZC anymore :/
  • Ready to land, but waiting for Germán to answer a ni? before that

Retrospective

• We need to organize ourselves better.