Gaia/New-Architecture-Program/Contacts/FxOS-S3(24 Jul)

From MozillaWiki
Jump to: navigation, search

General info

  • Members
    • Borja Salguero (DEV)
    • Fernando Campo (DEV)
    • Jorge Prudencio (DEV)
    • Manuel Casas (DEV)
    • Alberto Villena (QA)
    • Maria Oteo (EPM)
  • Meetings:
    • Daily happening everyday in Mumble at 10:30 CEST
    • Sprint Planning, on Monday (every two weeks)
  • Links of interest:

Sprint objectives

As part of the cycle 2 in the porting of Contacts app to the NGA, our main targets are:

  • Integrate #new within Contacts app in master:
    • Ensuring that all is working fine via windows.open
      • Moving all the logic related to 'curtain' to a Panel (currently is a separate <iframe>) (Bug 1182484) Done
      • Create a 'matching' view in a separated .html (matching_contacts.html) to remove all the dependencies (Bug 1181996) Done
      • Open contacts_matching with window.open instead of an i-frame. (Bug 1182509)
    • Final version of the navigation (gaia component) ready
    • Include #new in Contacts app using navigation (merged in /shared folder)
  • Merge #update activity in master as a self contained view (Bug 1183728
  • First version of #open and #import activities agreed during last sprint, they will be merged to unify the code and the offered UI. First tasks division:
    • MetaBug: Either to normalize behaviour (make import and open do the same things) or to Support IMPORT activity (depending on Francisco's feedback). We can morph the bug's description if we start working on it before we have an answer.
    • Modify manifest to use Independent html for vcard (load.html?import.html?) and mozContact (details.html)
    • [trivial] Modify activity handler to call same code for import and open vcard.
    • Modify activity_vcard to stop differentiating one or many contacts on vcard
  • Crazy ideas & Improvements: propose ideas for the NGA ww for Contacts or other Gaia applications. It's a nice to have in the sprint.

Bugs for this sprint

Full Query
ID Summary Status Resolution Assigned to Depends on Blocks Whiteboard Feature b2g Blocking b2g Target milestone
1178418 When importing a multiple contacts vcard, if a contact does not have Company field, "false" is shown in the import contacts list VERIFIED FIXED Manuel Casas Barrado [:mancas] [NG Gaia Contacts][patch] --- 2.5+ FxOS-S3 (24Jul)
1181996 Create basic 'matching' view in a separate .html RESOLVED FIXED Manuel Casas Barrado [:mancas] 1169191, 1182509, 1186869 [NG Gaia Contacts][patch] --- --- FxOS-S3 (24Jul)
1182484 [Contacts][NGA] Move curtain from <iframe> to a panel in 'Matching' RESOLVED FIXED Borja Salguero [:borjasalguero] 1169191, 1184483, 1182509 [NG Gaia Contacts][patch] --- --- FxOS-S3 (24Jul)
1183566 [Contacts][NGA] Fix loader.js when path is not specified RESOLVED FIXED Jorge Prudencio [:jorgep] 1169191 [NG Gaia Contacts][patch] --- --- FxOS-S3 (24Jul)
1184020 [Contacts][NGA] Import curtain.html element when we use gaia-install or reset-gaia RESOLVED FIXED Jorge Prudencio [:jorgep] 1169191 [NG Gaia Contacts][patch] --- --- FxOS-S3 (24Jul)
1186869 [Contacts][NGA] Fix styles in 'Matching' view RESOLVED FIXED Borja Salguero [:borjasalguero] 1181996 1169191 [NG Gaia Contacts][patch] --- --- FxOS-S3 (24Jul)

6 Total; 0 Open (0%); 5 Resolved (83.33%); 1 Verified (16.67%);


Other bugs to pay attention

As in this sprint we are going to work with the importing functionality when merging "import" and "open" activities, here there's a selection of bugs related to this feature. It would be great if we could fix some of them, but only if we have bandwidth (specially the 2.5+)

2.5+ bugs related to import functionality

  • Bug 1178241 - [vCard] 'undefined' is displayed when a field exist but there's no value in: Francisco has just assigned to himself
  • Bug 1178418 - When importing a multiple contacts vcard, if a contact does not have Company field, "false" is shown in the import contacts list (Manu) Resolved
  • Bug 1178529 - [Contacts] Contacts list will be dismissed when user attempts to import contacts the second time from an email account that didnt have any on the first attempt
  • Bug 1179923 - Wrong total count when importing a vcard with several contacts via Bluetooth

other non-blocking bugs related to import functionality

  • Bug 1152986 - Contact Last Name is repeated in Name field when viewing an attached vcard with Last Name and without Name fields
  • Bug 1152237 - [Flame][Message]Device will enter contacts list page when you tap the .vcf (without name and last name) to view
  • Bug 1124095 - Incorrect message when receiving contacts via Bluetooth

Daily meetings

Issues during the sprint

  • First version for removing Contacts from Communications.
  • When analyzing the needed work for merging "import" and "open" activities, two extra functionalities raised, that are not part of the NGA as they are not implemented yet so they would be only nice to have.
    • Multiple select really select-able. If accepted, would imply visual changes that will probably need agreement with UX.
    • Multiple select clickable (show details). Still not sure if easily doable, since we won't have the contact on database (just on js memory) as it is done before importing.
  • First version for a new functionality (ideation) so when long-pressing on a contact in the list, three options are shown (call, share, and delete).
  • Some important bugs have been blocking our testing:
    • Bug 1183301 - [B2G] Can't open a new attention window: Resolved
    • Bluetooth failures: many bugs have been reported:
      • Bug 1122177 - [Bluetooth] pairing fails while device is searching for other devices
      • Bug 1175955 - passive pairing not work when fresh flash
      • Bug 1182644 - [Bluetooth] When transferring a file to laptop, device restarts upon completion of transfer.
  • Regressions introduced by our NGA work:
    • Bug 1185143 - [Contacts] Backing out of selecting an emergency/ICE contact brings user to blank page in Contacts
    • Bug 1186869 - [Contacts][NGA] Fix styles in 'Matching' view Resolved
    • Bug 1185090 - [Contacts] Cannot send MMS to email address from contact page.
  • Other regressions:
    • Bug 1186108 - [Contacts] Cannot share contact via MMS (regression of an old patch from Adrian)
  • Borja prepared a first version of the #update activity, some considerations to be taken into account:
    • There is no navigation in the patch (will be added in a separate patch), and it needs all changes in Gecko about pre-render and Back&Forward Cache (we need to increase the memory from 1 element to 5 as we agreed in Whistler).
    • Detected this issue: Bug 1184953 - [Web Components] Document's element registry is not persisted in the BF Cache. William Cheng has a ni but no answer from him.

Demos

Retrospective

Actions taken from last sprint

See this link for more info

  • Raptor vs Marionette:
    • AP1:Check Alberto repos to verify the performance measures extracted and printed using marionette. The idea is sharing it with Raptor team.
    • AP2 (Maria):Follow-up meeting with Eli to share with Raptor team, NGA Contacts's needs and also check the progress of bug 1169775
      • Eli has provided a first version, still under revision, so we can test it and provide feedback.
  • Development Synchronization is necessary: weekly meetings, or weekly mails so everybody is aware of the changes and progress in the NGA libraries.
    • AP3 (Maria):Vivien sent a complete update via dev-gaia list last 19th June but we need to ensure that this sync continues after Whistler ww.
  • AP4 (Borja):Create a demo branch where we can play/test the ongoing work (no for QA testing) that can help us to:
    • We have agreed creating two repos:
      • Production one: we will wait to create it when all the bugs pending to be landed in this sprint (FxOS-S1) are merged in master (specially the relative to open and new activities)
      • Development one: it will be based on Whistler demo branch: https://github.com/borjasalguero/gaia/tree/demo
  • AP5 (Maria):Plan QA testing from a functionality point of view. what are we going to land in this sprint? necessary functionalities to be tested to avoid regressions?
  • AP6 (Maria): Aries devices, try to get them for our team.

Things that went well

Things that went not that well

Actions for this sprint (apart of the Sprint Objectives)