QA/Fennec/ Replace super toasts with snackbar
Overview
Purpose
The purpose of this wiki is to serve as a general test plan for verifying that super toasts and non-buttons are replaced with snackbars.
Ownership
- Developer contacts: Sebastian Kaspari irc:sebastian
Overall Status
[LANDED] Nightly 45: first landed on - 15-11-2015
[LANDED] Aurora 44: first landed on - 15-12-2015
[LANDED] Beta 45: first landed on - 28-01-2016
Testing Summary
Scope of testing
The testing will be focus on
- verifying that super toasts are replaced with snackbars
- verifying that non-buttons are replaced with snackbars
- veryfying that Toast.makeText() calls are replaced with snackbars
Environments
Testing will be performed on following devices:
- Phones
- 4.x
- 5.x
- 6.0
- Tablet
- 4.x
- 5.x
- 6.0
Specifications
- Snackbar screenshot spec
- Updating design to avoid display issues / overlay with tabs tray and the toast.
User Stories
- As a user, I want to remain being informed about actions I take in the browser, e.g. add bookmark, close tab
Acceptance Criteria
- When closing tabs in tabs tray, toast notification is replaced with snackbar
- When adding a bookmark, toast notification is replaced with snackbar
Testing details
Test Cases
- Replace super toasts with snackbar
- Display snackbar instead on non-buttons toasts
- Display snackbar for Toast.makeText() calls
Testing Days
Date: 26-11-2015
Open a page/link in "Open in New Tab"
Open a page/link in "Open in Private Tab"
Install an add-on
Add to reading list
Unblock image
Close a tab
Add a bookmark
Date: 08-12-2015
A snackbar is displayed for non-button in these scenarios: Copy a text
Download add-on
Fullscreen video
Download starts
Add search engine
Print page
No snackbar is displayed for Toast.makeText() calls
Remove page from reading list
Remove bookmark
Update bookmark
Remove page from homepanels
Add link as bookmark
Duplicate bookmarks
Date: 21-12-2015
- Snackbar is displayed for Toast.makeText() calls
Remove page from reading list
Remove bookmark
Update bookmark
Remove page from homepanels
Add link as bookmark
Duplicate bookmarks
Bug Work
Tracking bugs
- bugs to track the updates for replacing super toasts with snackbar
ex:
| ID | Summary | Priority | Status |
|---|---|---|---|
| 1189306 | Integration of Android Design Support library | -- | RESOLVED |
| 1204760 | Undo close tab toast covers tab bar | -- | RESOLVED |
| 1215026 | Create JSM snackbar API | -- | RESOLVED |
| 1216051 | Deprecate NativeWindow.toast or delegate calls to Snackbar API | -- | RESOLVED |
| 1223048 | Consider adding CoordinatorLayout to the view hierarchy | -- | RESOLVED |
| 1224521 | Replace non-button toasts with snackbars | -- | RESOLVED |
| 1224523 | Deprecate API for button toasts | -- | RESOLVED |
| 1224530 | Replace button toasts created with getButtonToast().show() with snackbars | -- | RESOLVED |
8 Total; 0 Open (0%); 8 Resolved (100%); 0 Verified (0%);
Still Issues
[NEW] Bug 1223048 - Consider adding CoordinatorLayout to the view hierarchy
[NEW] Bug 1231655 - Remove GeckoApp.showButtonToast()
[NEW] Bug 1233465 - Add swipe-to-dismiss to snackbar
[NEW] Bug 1237538 - UI test covering showing snackbars in GeckoPreferences
[NEW] Bug 1239146 - Toast alert for unknown download file action
Bugs fixed
[RESOLVED FIXED] Bug 1215026 - Create JSM snackbar API
[RESOLVED FIXED] Bug 1224530 - Replace button toasts created with getButtonToast().show() with snackbars
- ↳ 2015-11-23 : verified fixed on Firefox for Android 45.0a1 (2015-11-22) using Nexus 4 Moto X (Android 4.4);
[RESOLVED FIXED] Bug 1224521 - Replace non-button toasts with snackbars
- ↳ 2015-12-04 : verified fixed on Firefox for Android 45.0a1 (2015-12-04) using Nexus 4 (Android 5.1.1);
[RESOLVED FIXED] Bug 1216051 - Deprecate NativeWindow.toast or delegate calls to Snackbar API
[RESOLVED FIXED] Bug 1215026 - Create JSM snackbar API
[RESOLVED FIXED] Bug 1204760 - Undo close tab toast covers tab bar s
[RESOLVED FIXED] Bug 1189306 - Integration of Android Design Support library
[RESOLVED FIXED] Bug 1228414 - Replace remaining Toast.makeText() calls with snackbar
- ↳ 2015-12-23: verified fixed on Firefox for Android 45.0a2 and 46.0a1 (2015-12-22) using Nexus 6 (Android 6.0);
[RESOLVED FIXED] Bug 1233467 - Dismiss snackbar when user taps outside
- ↳ 2016-01-07: verified fixed on Firefox for Android 46.0a1 (2016-01-06) using Nexus 7 (Android 5.1.1);
[RESOLVED FIXED] Bug 1228414 - Replace remaining Toast.makeText() calls with snackbar
- ↳ 2015-12-23: verified fixed on Firefox for Android 45.0a2 and 46.0a1 (2015-12-22) using Nexus 6 (Android 6.0);
[RESOLVED FIXED] Bug 1233440 - Replace toast in HelperAppDialog.js with Snackbar.
[RESOLVED FIXED] Bug 1234295 - MasterPassword snackbar is not visible
Sign off
Criteria
- All test cases should be executed
- All blockers, criticals must be fixed and verified or have an agreed-upon timeline for being fixed
Results
Nightly testing
- There were no blockers found while testing this feature.
- Currently a snackbar is displayed instead of a toast notification after:
- choosing to open a page in "Open in New Tab" / "Open in Private Tab"
- installing an add-on
- adding a page to reading list
- unblocking image
- closing a tab and adding a bookmark
- Currently a snackbar is displayed instead of non-buttons toasts when:
- a text is copied
- an add-on is downloaded
- a video enters full screen
- a download begins
- a search engine is added
- a page is printed
- Currently a snackbar is displayed for Toast.makeText() calls
- page is removed from reading list
- a bookmark is removed
- bookmark is updated
- a link is bookmarked
- an already bookmark is added as bookmark
- page is removed from home panels
- Issues:
- Remove GeckoApp.showButtonToast()
- Add swipe-to-dismiss to snackbar
- Consider adding CoordinatorLayout to the view hierarchy
Aurora testing
- There were no blockers found while testing this feature.
- Currently a snackbar is displayed instead of a toast notification after:
- choosing to open a page in "Open in New Tab" / "Open in Private Tab"
- installing an add-on
- adding a page to reading list
- unblocking image
- closing a tab and adding a bookmark
- Currently a snackbar is displayed instead of non-buttons toasts when:
- a text is copied
- an add-on is downloaded
- a video enters full screen
- a download begins
- a search engine is added
- a page is printed
- Currently a snackbar is displayed for Toast.makeText() calls
- page is removed from reading list
- a bookmark is removed
- bookmark is updated
- a link is bookmarked
- an already bookmark is added as bookmark
- page is removed from home panels
- Issues:
- Remove GeckoApp.showButtonToast()
- Add swipe-to-dismiss to snackbar
- Consider adding CoordinatorLayout to the view hierarchy
- Toast alert for unknown download file action
Beta testing
- There were no blockers found while testing this feature.
- Issues
- Remove GeckoApp.showButtonToast()
- Add swipe-to-dismiss to snackbar
- Consider adding CoordinatorLayout to the view hierarchy
- Toast alert for unknown download file action
- Currently a snackbar is displayed instead of a toast notification after:
- choosing to open a page in "Open in New Tab" / "Open in Private Tab"
- installing an add-on
- adding a page to reading list
- unblocking image
- closing a tab and adding a bookmark
- Currently a snackbar is displayed instead of non-buttons toasts when:
- a text is copied
- an add-on is downloaded
- a video enters full screen
- a download begins
- a search engine is added
- a page is printed
- Currently a snackbar is displayed for Toast.makeText() calls
- page is removed from reading list
- a bookmark is removed
- bookmark is updated
- a link is bookmarked
- an already bookmark is added as bookmark
- page is removed from home panels
