Confirmed users
291
edits
Gaia/SMS/Scrum/2.1S4: Difference between revisions
Jump to navigation
Jump to search
→Day 7: 10th September
Steveck324 (talk | contribs) |
Steveck324 (talk | contribs) |
||
| Line 252: | Line 252: | ||
=== Day 7: 10th September === | === Day 7: 10th September === | ||
Steve | ====Steve==== | ||
* Bug 1048841 - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup) | * {{Bug|1048841}} - [Messages] investigate performance hit from IndexedDB at startup (eg: Contact lookup) | ||
** Ongoing, but not the top priority | ** Ongoing, but not the top priority | ||
* Bug 983172 - Parsing jpeg header information for downsampling the image for thumbnail | * {{Bug|983172}} - Parsing jpeg header information for downsampling the image for thumbnail | ||
** Patch updated and waiting for VD reply | ** Patch updated and waiting for VD reply | ||
* Bug 1058459 - [SMS] Data shared from other applications are not shown as Drafts until the app is killed and open again | * {{Bug|1058459}} - [SMS] Data shared from other applications are not shown as Drafts until the app is killed and open again | ||
** Will review the patch later | ** Will review the patch later | ||
* Bug 1061417 - [SMS] We don't properly discard the draft in some occasions | * {{Bug|1061417}} - [SMS] We don't properly discard the draft in some occasions | ||
** I could reproduce that but the STR is a little bit complicate, will spend some time on it to find out why the draft is not deleted in certain scenario. | ** I could reproduce that but the STR is a little bit complicate, will spend some time on it to find out why the draft is not deleted in certain scenario. | ||
Bunch of review | Bunch of review | ||
| Line 265: | Line 265: | ||
* Some other minor issue reply | * Some other minor issue reply | ||
Today: | Today: | ||
* Land | * Land {{Bug|983172}} and investigate draft discarding issue. | ||
* Review draft saving issue first and clean up the review/ni queue | * Review draft saving issue first and clean up the review/ni queue | ||
====Oleg==== | |||
* {{Bug|1063970}} - [Messages][Refresh] Update styles of phone and url links located inside messages | |||
Oleg | |||
* Bug 1063970 - [Messages][Refresh] Update styles of phone and url links located inside messages | |||
** Got new VD, will prepare small patch today (in progress). | ** Got new VD, will prepare small patch today (in progress). | ||
* Bug 1058459 - [SMS] Data shared from other applications are not shown as Drafts until the app is killed and open again | * {{Bug|1058459}} - [SMS] Data shared from other applications are not shown as Drafts until the app is killed and open again | ||
** Improved localStorage PoC patch a bit, talked to Sasikala about her concerns (awaiting info from partner). Looks like it works as she wants. Regarding the last concern, I can only suspect that asynStorage actually saved draft later then new app was opened, so I moved firing "drafts-changed" event in asyncStorage.setItem success callback. Still hesitating if that hacky solution is acceptable... | ** Improved localStorage PoC patch a bit, talked to Sasikala about her concerns (awaiting info from partner). Looks like it works as she wants. Regarding the last concern, I can only suspect that asynStorage actually saved draft later then new app was opened, so I moved firing "drafts-changed" event in asyncStorage.setItem success callback. Still hesitating if that hacky solution is acceptable... | ||
* Bug 918970 - [B2G][SMS] Conversation history does not appear when sending a SMS through the contacts app | * {{Bug|918970}} - [B2G][SMS] Conversation history does not appear when sending a SMS through the contacts app | ||
** Spent some time reviewing this patch, looks like it doesn't cover cases when we have threads with error/sending/not-downloaded messages only, asked advice from Steve on Github. | ** Spent some time reviewing this patch, looks like it doesn't cover cases when we have threads with error/sending/not-downloaded messages only, asked advice from Steve on Github. | ||
**: (Oleg) Steve, could you please look into my advise request once you have some time? :) | **: (Oleg) Steve, could you please look into my advise request once you have some time? :) | ||
**: (Steve) Sure, will reply later | **: (Steve) Sure, will reply later | ||
**: (Oleg) Thanks, it's not urgent :) | **: (Oleg) Thanks, it's not urgent :) | ||
* Bug 1048717 - [Messages][Refresh] Display call button at the header of single recipient thread | * {{Bug|1048717}} - [Messages][Refresh] Display call button at the header of single recipient thread | ||
** Fixed review nits and landed (landed). | ** Fixed review nits and landed (landed). | ||
* Bug 1053952 - [Messages][Refactoring] Delete all messages at once when deleting threads | * {{Bug|1053952}} - [Messages][Refactoring] Delete all messages at once when deleting threads | ||
** Fixed review comments and asked for review (in review). | ** Fixed review comments and asked for review (in review). | ||
Today: | Today: | ||
* Will handle review comments for the patches that currently in review; | * Will handle review comments for the patches that currently in review; | ||
* Will probably pick up new blocker | * Will probably pick up new blocker | ||
====Julien==== | |||
* on PTO till 9//15 | |||
=== Day 8: 11th September === | === Day 8: 11th September === | ||