Confirmed users
821
edits
Gaia/SMS/Scrum/2.1S5: Difference between revisions
Jump to navigation
Jump to search
→Day 4: 19th September
| Line 143: | Line 143: | ||
=== Day 4: 19th September === | === Day 4: 19th September === | ||
====Steve==== | |||
* {{Bug|1058459}} - [SMS] Data shared from other applications are not shown as Drafts until the app is killed and open again | |||
** Reviewing the SharedWorker patch(and it's brilliant!) will leave some comments later and give it a try | |||
* {{Bug|1059233}} - [SMS] User cannot view the cropped image in SMS application and ActivityCanceled error was shown when try to view | |||
** Having a integration tests for this case might be an idea to avoid possible regression(removing the workaround without gecko fixed first) like this. I've checked 1.4 and this issue exist since workaround was removed from v1.4 and later. | |||
**: (Julien) yeah it's strange that the branch checks said that it works in v1.4. I'll look closer today... | |||
* {{Bug|1067232}} - [SMS] Avoid to make a private memory copy for file based blob | |||
** No update yet. | |||
**: (Julien) please wait that I sort out the issue in the platform; I think I'll just back out the workaround in SMS and we'll either add it back in Gallery or find the fix in the platform. :asuth thinks that even with the current workaround we can fail in some cases. | |||
**: (Steve) Hmm, not sure which case will make the blob copy workaround failed, I thought both workaround have similar approach. | |||
**: (Julien) not sure either. Nope, the gallery workaround is: copy the blob to a temporary file so that we get a file-backed blob and do not have the issue in SMS. | |||
**: (Steve) Ah, I see. Just check the gallery's patch. | |||
**: (Julien) I haven't looked at the patch though, I may be wrong here, I just take what djf told me :) Anyway we'll know more today ! | |||
**: (Steve) I could agree it's better to workaround in gallery then in messaging in general like asuth said, if they(gallery) agrees to do so. I just confused that why we need messaging workaround in 1.2f and 1.3t if gallery already got the workaround as well... | |||
**: (Julien) the gallery workaround is in v1.3t only, as far as I know. | |||
* {{Bug|1021608}} - [Messages] Consider adding a "resend" button in the message report page, if there is an error, and other visual refresh | |||
** Start to implement report panel refresh. | |||
* {{Bug|1068564}} - When CMAS alert are deleted in notifications panel, device closes utility try | |||
** Checking with current master and other notification case. It's weird and seems not a CMAS app wise issue. | |||
**: (Oleg) It looks like what I saw previously https://bugzilla.mozilla.org/show_bug.cgi?id=1051793#c8 | |||
**: (Steve) Thanks! I almost forgot this. It was worked on emulator, but I haven't revisit again | |||
**: (Oleg) Maybe I'm wrong but as I remember when I swiped notification it got activated and our app reacted... don't remember exactly :) | |||
**: (Julien) it's probably a system front-end bug. (but probably from my code from {{Bug|1051788}} :D) | |||
**: (Steve) Hmm, will take a look about this then, thanks too! | |||
Today: | |||
* Investigate {{Bug|1068564}} and start {{Bug|1021608}} | |||
====Julien==== | |||
* {{Bug|1061417}} (draft is not discarded in some occasions): landed | |||
* {{Bug|1054989}} (DSDS send button refresh): | |||
** got a patch, waiting for fang's ui-review and maybe image updates (because the new ones are larger for apparently no reason) | |||
** also added a missing l10n string | |||
** might ask for an approval to land on v2.1 if not too late | |||
* did some reviews for Oleg especially :) | |||
* looked into the strange blob-related issue that appeared while I was in holidays ({{Bug|1059233}}); should have been fixed in gecko... ({{Bug|1063658}} might be this) | |||
** looks like there is something deeper than just SMS. Will look further today, especially see how it works in the various versions. The regression window just points to the workaround removal in Gallery which does _and_ doesn't make sense ;) | |||
Other: | |||
* resumed work on {{Bug|874510}} (upgrade mocha) (my "subway" project :) ); fixed some unit tests but there are more failing. | |||
Today: | |||
* will continue working on {{Bug|1059233}} for the blob related issue | |||
* will do reviews | |||
* will start another sprint bug (don't know which one yet) | |||
====Oleg==== | |||
* {{Bug|1067228}} - [Messages][Refactoring] Move subject management to a separate component | |||
** Almost finished unit tests, will wait for {{Bug|1061215}} first(in progress, almost finished); | |||
* {{Bug|1061215}} - [Messages][Refactoring] Improve handling of remaining chars counter | |||
** Got second round of review comments, fixed, will ask review in a few! (in progress). | |||
* {{Bug|1050416}} - [Messages][Build] Add build script to ignore the desktop-only folder for production build | |||
** Got first round of review comments, working on it (in progress). | |||
Other: | |||
* Reviewed Luke's patch to fix cursor glitch, left some suggestion on selection managment and unit test; | |||
* Reviewed small patch on draft discard. | |||
Today: | |||
* Will handle review comments for the patches that currently in review; | |||
* Will handle review requests. | |||
=== Day 5: 22th September === | === Day 5: 22th September === | ||
=== Day 6: 23th September === | === Day 6: 23th September === | ||