Confirmed users
525
edits
Firefox OS/Comms/Dialer/Sprint/v2.1-S6/20141002-StandupNotes: Difference between revisions
Jump to navigation
Jump to search
m
Firefox OS/Comms/Dialer/Sprint/v2.1-S6/20141002-StandupNotes (view source)
Revision as of 14:48, 2 October 2014
, 2 October 2014no edit summary
(Created page with "====Blockers==== * 2.1+ {{Bug|1070066}} - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls ** Assigned to Tamara...") |
mNo edit summary |
||
| Line 14: | Line 14: | ||
** Write MVC proposal. | ** Write MVC proposal. | ||
*** I wanted to do this yesterday, but I got sidetracked by tons of reviews and my patches. | *** I wanted to do this yesterday, but I got sidetracked by tons of reviews and my patches. | ||
** {{Bug|1067883}} - [ partner confidential ] | |||
*** I got asked for help here, will need to provide info on how to do something and probably provide a patch. | |||
*** <Rik> Is it possible to open a public bug? | |||
*** I just got ni'd on it this morning, I'll always ask for that if I can. | |||
* My Patches: | * My Patches: | ||
** {{Bug|1060451}} - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js | ** {{Bug|1060451}} - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js | ||
| Line 28: | Line 32: | ||
*** cleared r? Anthony did a drive-by f- on this so I'm not going to review it until those comments are addressed. | *** cleared r? Anthony did a drive-by f- on this so I'm not going to review it until those comments are addressed. | ||
** {{Bug|1062799}} - Call information is not updated on the fly after creating a contact | ** {{Bug|1062799}} - Call information is not updated on the fly after creating a contact | ||
*** r- | *** r-. New patch up that I need to review today. | ||
** {{Bug|1061398}} - Incall keypad layout needs adjustment | ** {{Bug|1061398}} - Incall keypad layout needs adjustment | ||
*** r+ | *** r+ | ||
| Line 50: | Line 54: | ||
** {{Bug|1069499}} - [Dialer] [User Story] It should be possible to easily delete single entry from the call log list | ** {{Bug|1069499}} - [Dialer] [User Story] It should be possible to easily delete single entry from the call log list | ||
*** Helped via PM with setting up the simulator, testing changes, and answering questions about our code. | *** Helped via PM with setting up the simulator, testing changes, and answering questions about our code. | ||
====Rik==== | |||
* Admin | |||
** Will be on PTO tomorrow afternoon | |||
* Posted two patches for {{Bug|831974}} User has to press 1 for a long time before Voicemail is reached | |||
* Tried to get some help on {{Bug|1069286}}, I'll post a WIP patch to get more help | |||
* Got a lot of needinfos/reviews, need to take a look at them | |||
* Received a thank you note from the graphics team on how we handled {{Bug|1070993}} | |||
* Reviews | |||
** {{Bug|106045}} | |||
====gtorodelvalle==== | |||
* Administrative: | |||
** Jorge has been requested by our Push team to start collaborating with them. Anyhow, he will finish the Comms bugs he is currently working on. | |||
** I have a meeting now at 16:00. Hopefully I will be out before 16:30, but just in case I am not able to join you guys today. | |||
* {{Bug|977588}} - [Dialer] The Active call screen does not have the option to place calls on hold: | |||
** Really weird stuff (sometimes it connects, sometimes it does not, etc.) going on connecting the BT headset to the device and managing calls. I have never used one of this BT devices before and it is not of my own so maybe that is the reason of the weird behaviour I observed. | |||
** We have included additional changes into the patch and a new review has been requested from Anthony. | |||
* {{Bug|977056}} - [Dialer] Visual discrepancies: Call ended view under conference call participants list: | |||
** I am trying to get a detailed picture of the way we currently manage call changes events in the Call Screen app since it is kind of scattered among many areas and some times the observed results are not the desired ones such as the one mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=977056#c26 | |||
** This is probably a good input for Doug's MVC proposal to try to clean things up :) | |||
** I'll keep you posted. | |||
** <drs> Thanks, will take this into account. | |||
====thills==== | |||
* {{Bug|1024341}} - Wakeup the device after call hangs up | |||
** We split this into several bugs. Right now, I'm working on one of the child bugs of this. | |||
* {{Bug|1068109}} to restore the 2s delay before the call screen goes away. | |||
** New patch for review with fix for contact image. I incorporated drs latest comments and then my PR got closed and I was asked to rebase and open a new one. I've done that and now just retesting and waiting for try to finish. | |||
* {{Bug|1070066}} - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls | |||
** We talked about this and decided to let 1068109 fix this temporarily and then document that settings team will have a patch for this for a new API. | |||
* {{Bug|1068093}} - Remove legacy transition code from the callscreen | |||
** Started looking at this with 1068109 applied. | |||
* {{Bug|1074379}} - I spent some time trying to repro this yesterday and was able to after many successive calls. Updated the bug with my findings of where i saw errors. | |||
====pacorampas==== | |||
* Absent/no report | |||
====jpruden92==== | |||
* Absent/no report | |||