Confirmed users
329
edits
Javascript:Hazard Builds: Difference between revisions
Jump to navigation
Jump to search
updated to current reality
(updated to current reality) |
|||
| Line 9: | Line 9: | ||
== Static Rooting Analysis == | == Static Rooting Analysis == | ||
Tbpl can run two static analysis builds, one for the full browser (linux64-br-haz) and one for just the JS shell (linux64-sh-haz). | Tbpl can run two static analysis builds, one for the full browser (linux64-br-haz) and one for just the JS shell (linux64-sh-haz). They show up on treeherder as '''H'''. | ||
These builds are performed as follows: | These builds are performed as follows: | ||
| Line 32: | Line 28: | ||
The far easier way to run an analysis is to push to try with the trychooser line |try: -b do -p linux64-br-haz -u none| (or, if the hazards of interest are contained entirely within js/src, use |try: -b do -p linux64-sh-haz -u none| for a much faster result). The expected turnaround time for linux64-br-haz is just under 2 hours. | The far easier way to run an analysis is to push to try with the trychooser line |try: -b do -p linux64-br-haz -u none| (or, if the hazards of interest are contained entirely within js/src, use |try: -b do -p linux64-sh-haz -u none| for a much faster result). The expected turnaround time for linux64-br-haz is just under 2 hours. | ||
The output will be uploaded | The output will be uploaded and a link will be placed into the build summary info pane on treeherder. If the analysis fails, you will see the number of failures (and the number of expected failures, which should usually be zero.) | ||
If the analysis fails, you will see | |||
=== Analysis output === | === Analysis output === | ||
| Line 97: | Line 76: | ||
The most common way to fix a hazard is to change the variable to be a Rooted type, as described in http://dxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h#l21 | The most common way to fix a hazard is to change the variable to be a Rooted type, as described in http://dxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h#l21 | ||
For more complicated cases, ask on #jsapi. If you don't get a response, ping sfink, terrence, or jonco | For more complicated cases, ask on #jsapi. If you don't get a response, ping sfink, terrence, or jonco. | ||