Confirmed users
329
edits
Javascript:Hazard Builds: Difference between revisions
Jump to navigation
Jump to search
terrence gone.
(→Static Analysis for Rooting Hazards: put useful stuff at top) |
(terrence gone.) |
||
| Line 77: | Line 77: | ||
=== So you broke the analysis by adding a hazard. Now what? === | === So you broke the analysis by adding a hazard. Now what? === | ||
Backout, fix the hazard, or (final resort) update the expected number of hazards in js/src/devtools/rootAnalysis/expect.browser.json. | Backout, fix the hazard, or (final resort) update the expected number of hazards in js/src/devtools/rootAnalysis/expect.browser.json (but don't do that). | ||
The most common way to fix a hazard is to change the variable to be a Rooted type, as described in http://dxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h#l21 | The most common way to fix a hazard is to change the variable to be a Rooted type, as described in http://dxr.mozilla.org/mozilla-central/source/js/public/RootingAPI.h#l21 | ||
For more complicated cases, ask on #jsapi. If you don't get a response, ping sfink | For more complicated cases, ask on #jsapi. If you don't get a response, ping sfink or jonco. | ||