Changes

* '''Compiler warnings''': all of our compilers have a number of warnings;we . We try to turn on as many as we can, and make warnings on most Mozillacode fatal, i.e. your build will fail if the compiler warns. Wegenerally turn off fatal warnings for third-party code, and sometimesattempt to get fixes for the warnings pushed upstream.

* '''Custom static analyses''': We have a clang plugin with a number ofGecko-specific checks. There's terse documentation on the attributeswe use to drive some of the checks [https://dxr.mozilla.org/mozilla-central/source/mfbt/Attributes.h#341 here]. Some checks are just good hygiene (e.g. MOZ_IMPLICIT), some checks exist to help you do the right thing (e.g. MOZ_MUST_OVERRIDE, MOZ_RAII, MOZ_MUST_USE), and some checks exist to prevent security bugs (e.g. MOZ_NON_MEMMOVABLE and related attributes). The checker currently runs on every push we do, on Windows, Mac, and Linux.

Some checks are just good hygiene (e.g. MOZ_IMPLICIT), some checksexist to help you do the right thing (e.g. MOZ_MUST_OVERRIDE,MOZ_RAII, MOZ_MUST_USE), and some checks exist to prevent securitybugs (e.g. MOZ_NON_MEMMOVABLE and related attributes). The checker currently runs on every push we do, on Windows, Mac, andLinux. * '''[http://www.coverity.com/ Coverity]''' () : runs their code checker onFirefox every couple of days and throws all the problems into a nicelysearchable database.