12
edits
Phabricator/TestPlan: Difference between revisions
Jump to navigation
Jump to search
Rewording a few things to make the instructions more clear.
DaveLawrence (talk | contribs) No edit summary |
(Rewording a few things to make the instructions more clear.) |
||
| Line 121: | Line 121: | ||
# The diff and information of the revision are as expected. | # The diff and information of the revision are as expected. | ||
# The revision has a "Custom Policy" attached to it. | # The revision has a "Custom Policy" attached to it. | ||
# Click "Edit Revision" and then click on the "Visible To" drop down, and select the "Custom Policy" choice. | |||
#* It should read "Allow members of projects", followed by the names of projects corresponding to all Bugzilla groups the private bug is categorized under. For example, a bug private to core-security, should have the project name "bmo-core-security". | |||
# The revision has a "secure-revision" project tag added. | # The revision has a "secure-revision" project tag added. | ||
# The revision has a warning titled "This is a secure revision.". | # The revision has a warning titled "This is a secure revision.". | ||
| Line 148: | Line 149: | ||
====Results==== | ====Results==== | ||
# The revision has a "Custom Policy" attached to it. | # The revision has a "Custom Policy" attached to it. | ||
# Click "Edit Revision" and then click on the " | # Click "Edit Revision" and then click on the "Visible To" drop down, and select the "Custom Policy" choice. | ||
#* It should read "Allow members of projects", followed by the names of projects corresponding to all Bugzilla groups the private bug is categorized under. For example, a bug private to core-security, should have the project name "bmo-core-security". | |||
# The revision has a "secure-revision" project tag added. | # The revision has a "secure-revision" project tag added. | ||
# The revision has the creator and the second Bugzilla user as subscribers. | # The revision has the creator and the second Bugzilla user as subscribers. | ||
| Line 280: | Line 282: | ||
# Code is sucessfully patched using the Diff. | # Code is sucessfully patched using the Diff. | ||
=== | === T15 - Verify the private revisions deliver emails that does not contain any sensitive content === | ||
Your Bugzilla user must belong to a security group, e.g. core-security. | Your Bugzilla user must belong to a security group, e.g. core-security. | ||
====Test Plan==== | ====Test Plan==== | ||
# Login to Phabricator (after creating account in Bugzilla) using an account that can have email delivered to it such as your own email address. | # Login to Phabricator (after creating account in Bugzilla) using an account that can have email delivered to it, such as your own email address. | ||
# At the top right of Phabricator, click on your initial or gravatar image drop down menu and select "Settings". | # At the top right of Phabricator, click on your initial or gravatar image to open the drop down menu and select "Settings". | ||
# Click on "Email Delivery". | # Click on "Email Delivery". | ||
# Select "Enable Self Action Mail" for the "Self Action" drop down. | # Select "Enable Self Action Mail" for the "Self Action" drop down. | ||
# Click "Save Changes". | # Click "Save Changes". | ||
# Go to | # Go to Bugzilla and create a security bug: | ||
#* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug". | #* Click "Edit Bug", open the "Security" panel, and check one of the security-sensitive boxes, e.g. "Security-Sensitive Core Bug". | ||
# Create a new hg commit. | # Create a new hg commit. | ||
| Line 301: | Line 303: | ||
# The revision has a "Custom Policy" attached to it. | # The revision has a "Custom Policy" attached to it. | ||
# The revision has a "secure-revision" project tag added. | # The revision has a "secure-revision" project tag added. | ||
# The revision has a warning titled "This is a secure revision | # The revision has a warning titled "This is a secure revision". | ||
# Check | # Check to see if you received an email about the new object (Revision) that was just created. | ||
# The email should not contain any information about the revision other than a link to Phabricator. | # The email should not contain any information about the revision other than a link to Phabricator. | ||
# Clicking on the link in the email should take you to the Phabricator page that displays the full unfiltered email contents. | # Clicking on the link in the email should take you to the Phabricator page that displays the full unfiltered email contents. | ||
# The email contents should contain the title, summary, test plan, reviewers, etc. of the new revision. | # The email contents should contain the title, summary, test plan, reviewers, etc. of the new revision. | ||
# Submitting a public revision should instead show the full contents in the email similar to what was displayed on the Phabricator mail page. | # Submitting a public revision should instead show the full contents in the email similar to what was displayed on the Phabricator mail page. | ||