Confirmed users
360
edits
DOM/Engineering: Difference between revisions
Jump to navigation
Jump to search
add structure around code reviews and phabricator to be filled-in
m (→Performance / Validation: are we fast yet, etc.) |
(add structure around code reviews and phabricator to be filled-in) |
||
| Line 88: | Line 88: | ||
You can also be granted privileges after agreeing to privacy guidelines in order to download Windows-style "minidump" files created by breakpad that contain more details than can be found on the public crash report page. The information includes details like the contents of stack memory (which may include data that has privacy implications, hence the privacy agreement). | You can also be granted privileges after agreeing to privacy guidelines in order to download Windows-style "minidump" files created by breakpad that contain more details than can be found on the public crash report page. The information includes details like the contents of stack memory (which may include data that has privacy implications, hence the privacy agreement). | ||
* [https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Crash_reporting/Understanding_crash_reports MDN's Debugging a minidump page] | * [https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Crash_reporting/Understanding_crash_reports MDN's Debugging a minidump page] | ||
== Writing Patches and asking for Code Reviews == | |||
=== Pushing to Try === | |||
=== Updating Tests === | |||
=== Writing Tests === | |||
=== Preparing Your Patch For Review === | |||
=== Submitting Code Reviews === | |||
We use Phabricator for code reviews. Check out the [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html user guide]. | |||
== Doing Code Reviews == | |||
== Debugging == | == Debugging == | ||
| Line 94: | Line 109: | ||
=== Using rr to record and replay (on linux) === | === Using rr to record and replay (on linux) === | ||
[ | [https://rr-project.org/ rr] is a magic super tool that can record the execution of Firefox, logging all the non-determinism so that you can replay the exact execution later with support for reverse execution. Once you reproduce a bug, you can revisit that execution endlessly. Note that it only runs on linux. | ||
* [https://github.com/mozilla/rr/wiki/Building-And-Installing Build and Install RR] | * [https://github.com/mozilla/rr/wiki/Building-And-Installing Build and Install RR] | ||
* [https://github.com/mozilla/rr/wiki/Recording-Firefox Recording Firefox] | * [https://github.com/mozilla/rr/wiki/Recording-Firefox Recording Firefox] | ||