Sheriffing/How To/Landing patches: Difference between revisions

Jump to navigation Jump to search
→‎Landing patches from the console - Inbound: added abstract about checking reviewer
(→‎Landing patches from the console - Inbound: added abstract about checking reviewer)
Line 42: Line 42:
# '''Needinfo''' the developer
# '''Needinfo''' the developer
# '''Remove''' the checkin-needed tag
# '''Remove''' the checkin-needed tag
== Checking the reviewer ==
We have to check if that the person who reviewed the patch has the authority to grant the permission to get the code changes added. The list of allowed reviewers broken down by module can be found at https://wiki.mozilla.org/Modules/All If the module can't be identified, it's possible to check if a person is a Mozilla employee at https://phonebook.mozilla.org/ and land it if that is true.


== Landing patches from the console - Inbound ==
== Landing patches from the console - Inbound ==
We will have to identify the person that added the patch, and the one that reviewed the patch. For this, you can use: https://wiki.mozilla.org/Modules/All or https://phonebook.mozilla.org/ or https://mozillians.org/en-US/
These are the steps that you should follow:
These are the steps that you should follow:
# '''cd mozilla-unified'''
# '''cd mozilla-unified'''
Confirmed users
622

edits

Navigation menu