Sheriffing/How To/Landing patches: Difference between revisions

Sheriffing/How To/Landing patches (view source)

61 bytes removed , 30 August 2018

move and merge review related information

Confirmed users

622

edits

@@ Line 9: / Line 9: @@
 = How to land check-in needed patches =
-* <u><b>Verify that the patch has proper review before doing anything else</b></u>
+* <u><b>Verify that the patch has proper review before doing anything else</b></u>. We have to check if that the person who reviewed the patch has the authority to grant the permission to get the code changes added. The list of allowed reviewers broken down by module can be found at
 ** [https://wiki.mozilla.org/Modules Module information]
+** If the module can't be identified, it's possible to check if a person is a Mozilla employee at https://phonebook.mozilla.org/ and land it if that is true.
 * Saving the attachment from the bug.
 * Apply the patch to the appropriate repository using <code>hg import</code> (preferred) or <code>patch</code>.
@@ Line 42: / Line 44: @@
 # '''Needinfo''' the developer
 # '''Remove''' the checkin-needed tag
-== Checking the reviewer ==
-We have to check if that the person who reviewed the patch has the authority to grant the permission to get the code changes added. The list of allowed reviewers broken down by module can be found at https://wiki.mozilla.org/Modules/All If the module can't be identified, it's possible to check if a person is a Mozilla employee at https://phonebook.mozilla.org/ and land it if that is true.
 == Landing patches from the console - Inbound ==