Confirmed users
33
edits
JavaScript:SpiderMonkey:Coding Style: Difference between revisions
Jump to navigation
Jump to search
JavaScript:SpiderMonkey:Coding Style (view source)
Revision as of 06:21, 12 September 2018
, 12 September 2018Update braces style per bug 1488698
(link to directories) |
(Update braces style per bug 1488698) |
||
| Line 71: | Line 71: | ||
if(condition) /* bad */ | if(condition) /* bad */ | ||
if (condition) /* OK */ | if (condition) /* OK */ | ||
* | * Always use braces for conditionals, even if the condition and consequent occupy single lines. | ||
if ( | |||
if (!foo) { | |||
return false; | |||
} | |||
if (canSwingFromWeb) { | if (canSwingFromWeb) { | ||
p->swingFromWeb(); | p->swingFromWeb(); | ||
| Line 122: | Line 122: | ||
doStuff(); | doStuff(); | ||
} | } | ||
for (int i = 0; i < 5; i++) /* OK */ | for (int i = 0; i < 5; i++) { /* OK */ | ||
doStuff(); | doStuff(); | ||
} | |||
for (size_t ind = JSObject::JSSLOT_DATE_COMPONENTS_START; | for (size_t ind = JSObject::JSSLOT_DATE_COMPONENTS_START; | ||
ind < JSObject::DATE_FIXED_RESERVED_SLOTS; ind++) { /* bad */ | ind < JSObject::DATE_FIXED_RESERVED_SLOTS; ind++) { /* bad */ | ||
| Line 148: | Line 149: | ||
MyFunction(int n) | MyFunction(int n) | ||
{ | { | ||
if (!n) | if (!n) { | ||
return; /* OK */ | return; /* OK */ | ||
} | |||
... | ... | ||
} | } | ||
| Line 186: | Line 188: | ||
* Avoid using && or || to mix deciding-whether-to-do-something with error-checking. | * Avoid using && or || to mix deciding-whether-to-do-something with error-checking. | ||
if (obj->hasProblems() && !obj->rectify()) | if (obj->hasProblems() && !obj->rectify()) { /* bad */ | ||
return false; | return false; | ||
} | |||
if (obj->hasProblems()) { /* OK */ | if (obj->hasProblems()) { /* OK */ | ||
if (!obj->rectify()) | if (!obj->rectify()) { | ||
return false; | return false; | ||
} | |||
} | } | ||