CI Automation: Difference between revisions

Jump to navigation Jump to search
Line 64: Line 64:


Find a string in Firefox (e.g in one of the menus or preference dialogs) and make sure that it's fairly unique. Then try and use [https://searchfox.org/mozilla-central/source searchfox] to find where that string is defined. Change the value to something else and re-run a build. Then use '''./mach run''' to see if your change is there!
Find a string in Firefox (e.g in one of the menus or preference dialogs) and make sure that it's fairly unique. Then try and use [https://searchfox.org/mozilla-central/source searchfox] to find where that string is defined. Change the value to something else and re-run a build. Then use '''./mach run''' to see if your change is there!


==== Fixing the Bug ====
==== Fixing the Bug ====
Line 71: Line 70:


Once you have your fix commit it with a message that follows [https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment Mozilla's guidelines]. Be sure to test your patch (ask your mentor if instructions for testing weren't included in the bug). You should also run '''./mach lint --outgoing''' to make sure you didn't cause any lint errors. If the patch is complicated enough, your mentor might also want to do a [https://firefox-source-docs.mozilla.org/tools/try/index.html try push] (you won't have permission to do this on your own, so they'll do it on your behalf).
Once you have your fix commit it with a message that follows [https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities#Checkin_comment Mozilla's guidelines]. Be sure to test your patch (ask your mentor if instructions for testing weren't included in the bug). You should also run '''./mach lint --outgoing''' to make sure you didn't cause any lint errors. If the patch is complicated enough, your mentor might also want to do a [https://firefox-source-docs.mozilla.org/tools/try/index.html try push] (you won't have permission to do this on your own, so they'll do it on your behalf).


==== The Review Cycle ====
==== The Review Cycle ====
Line 93: Line 91:


Once you have the requested changes amended to the proper commits, you can re-submit them to phabricator and the process will repeat itself.
Once you have the requested changes amended to the proper commits, you can re-submit them to phabricator and the process will repeat itself.


==== What to Expect After Landing ====
==== What to Expect After Landing ====
Line 104: Line 101:


If all the builds and tests pass on the integration branch, your patch will eventually be merged into mozilla-central (these merges typically happen twice a day). At this point you're in the clear! The next time someone pulls in the latest changes from central, your changes will be included. Congratulations!
If all the builds and tests pass on the integration branch, your patch will eventually be merged into mozilla-central (these merges typically happen twice a day). At this point you're in the clear! The next time someone pulls in the latest changes from central, your changes will be included. Congratulations!


== [[Glossary]] ==
== [[Glossary]] ==


Mozillians use a dizzying amount of terminology that can make any new contributor's head spin. You'll often be able to find what you're looking for in the [[Glossary]]. If you come across something not mentioned there, feel free to ask us in IRC (and remind us to add it to the list).
Mozillians use a dizzying amount of terminology that can make any new contributor's head spin. You'll often be able to find what you're looking for in the [[Glossary]]. If you come across something not mentioned there, feel free to ask us in IRC (and remind us to add it to the list).
Confirmed users
656

edits

Navigation menu