Auto-tools/Projects/Stockwell/disable-recommended: Difference between revisions

Jump to navigation Jump to search

Auto-tools/Projects/Stockwell/disable-recommended (view source)

Revision as of 01:31, 16 July 2019

1,131 bytes added ,  16 July 2019
Removed deprecated info about making a patch with mq and added info about moz-phab patches.
(→‎Requesting review: - webrender)
(Removed deprecated info about making a patch with mq and added info about moz-phab patches.)
Line 157: Line 157:


== Making a patch ==
== Making a patch ==
To actually disable a test, we need to update the manifest file in mozilla-central. Before doing that, create a mercurial patch containing the change, and upload the patch to bugzilla for review.
To actually disable a test, we need to update the manifest file in mozilla-central. Before doing that, create a patch using [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html?highlight=moz-phab#mozilla-phabricator-user-guide moz-phab] containing the change and upload the patch to bugzilla for review.


Some useful mercurial commands for creating a patch with "mq":
For info about [https://github.com/mozilla-conduit/review/blob/master/README.md#installation installing] and [https://github.com/mozilla-conduit/review/blob/master/README.md#configuration configuring] moz-phab and implicitly arcanist see this [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html#setting-up-arcanist page]
  hg qseries        # see what patches are in your queue / what is applied
 
  hg qdiff          # see the file changes in the current patch
After moz-phab setup you need to follow these steps to upload your patch to Phabricator:
  hg qnew            # create a new patch
nano/gedit file_path                                                                    //edit the file you want to disable
  hg qrefresh        # update your patch with local file changes
  hg commit                                                                              //add commit message
  hg qrefresh -e    # edit the commit message associated with your patch
<inside editor add comment |Bug 1234567 - disable <test> for frequent failures. r=gbrown/jmaher| and save>
  hg add <filename> # add a new file to source control
  hg diff -c .                                                                          //see the changes you made to the files and self review
moz-phab                                                                              //will submit the changes in phabricator
 
If you want to update an existing phabricator patch, you need to be the owner of the revision or to [https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html?highlight=commandeer#other-revision-actions commandeer] it. Then do the following steps:
 
  moz-phab patch patch_id --apply-to .                        //applies the patch locally to the active repo
  nano/gedit file_path                                        //edit the file you need to change
  hg commit --amend                                          //update or change the commit
  hg diff -c .                                                //see the changes you made to the files and self review
  moz-phab                                                    //upload the changes to phabricator


I typically follow this workflow:
hg qnew bug1234567.patch
<edit> <manifest>.ini
hg qrefresh
hg qdiff # self review
hg qrefresh -e
<inside editor add comment |Bug 1234567 - disable <test> for frequent failures. r=gbrown| and save>
hg qrefresh -u "Joel Maher <jmaher@mozilla.com>"  # adds my username to the patch
cp .hg/patches/bug1234567.patch ~/
hg qpop


NOTE: the self review is a great time to make sure:
NOTE: the self review is a great time to make sure:
Csabou
Confirmed users
24

edits

Retrieved from "https://wiki.mozilla.org/Special:MobileDiff/1215101"

Navigation menu