Confirmed users
1,201
edits
| Line 112: | Line 112: | ||
Phabricator has a limit of 32MB on patches. If your patch exceed this size you should ''seriously'' consider splitting the patch into multiple commits (e.g. bumping versions of vendored rust crates one at a time rather an in a single commit). Your reviewers will thank you for this - massive patches are harder to review. Note if you use Lando to land your stack, each commit will land as part of the same push - you won't end up in a partially landed stack. | Phabricator has a limit of 32MB on patches. If your patch exceed this size you should ''seriously'' consider splitting the patch into multiple commits (e.g. bumping versions of vendored rust crates one at a time rather an in a single commit). Your reviewers will thank you for this - massive patches are harder to review. Note if you use Lando to land your stack, each commit will land as part of the same push - you won't end up in a partially landed stack. | ||
If your patch makes small changes to multiple files, try submitting with the <code>--less-context</code> switch. Phabricator works by submitting the complete contents of each file modified; when touching many files it can be easy to exceed the 32MB limit. Note <code>--less-context</code> disables the ability to show more context when viewing a patch on Phabricator. | |||
== Command-line tools: moz-phab and arc == | == Command-line tools: moz-phab and arc == | ||