Firefox/Python 3 Migration: Difference between revisions

Firefox/Python 3 Migration (view source)

614 bytes added , 28 August 2019

Confirmed users

656

edits

@@ Line 52: / Line 52: @@
 # Set one of callek, ahal, or catlee as the code reviewer
-==== Run all python source tests with Python 3 and see what breaks ====
+==== Enable Python 3 on more Python unittests ====
-Make sure each of the tasks listed in https://searchfox.org/mozilla-central/source/taskcluster/ci/source-test/python.yml has Python 3 specified, and do a try push, enabling all the python source tests.
+Python unittests are run with `./mach python-test` and are (usually) defined in `python.ini` files. To get a test running against Python 3:
-See what breaks, then fix it!
+# Find a test that is skipped with Python 3, you can use [https://searchfox.org/mozilla-central/search?q=.*(skip|fail)-if.*python+%3F%3D%3D+%3F3&case=true&regexp=true&path=.ini%24 this query] to find these tests.
+# Edit the manifest and remove the Python 3 skip-if annotation.
+# Run the test with `./mach python-test --python 3 path/to/test`.
+# Fix any errors and repeat the previous step.
+# Once it is passing locally, test it out on try. If there is no Python 3 task running this manifest already, you'll need to add one by adding `3` to the `python-version` key in [https://searchfox.org/mozilla-central/source/taskcluster/ci/source-test/python.yml python.yml].
+# Push the task to try on all platforms it is configured for.
 ==== Port a Mach Command ====