Phabricator/TestPlan/ExpectationT15: Difference between revisions

Jump to navigation Jump to search

Phabricator/TestPlan/ExpectationT15 (view source)

Revision as of 20:42, 9 October 2020

5,750 bytes added ,  9 October 2020
Updates expected phab-email data to include comments-as-HTML data, improved reviewer action-ability detection
(Update newChangesLink due to erroneous later updates to patch)
(Updates expected phab-email data to include comments-as-HTML data, improved reviewer action-ability detection)
Line 1: Line 1:
<syntaxhighlight lang="bash">
<syntaxhighlight lang="json">
{
{
   "data": {
   "data": {
Line 76: Line 76:
         "body": {
         "body": {
           "mainComment": null,
           "mainComment": null,
          "mainCommentMessage": null,
           "inlineComments": [],
           "inlineComments": [],
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57822",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57822",
Line 112: Line 113:
         "body": {
         "body": {
           "mainComment": null,
           "mainComment": null,
          "mainCommentMessage": null,
           "inlineComments": [],
           "inlineComments": [],
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57823",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57823",
Line 203: Line 205:
             {
             {
               "name": "phab-email-qa-reviewer-1",
               "name": "phab-email-qa-reviewer-1",
               "isActionable": true,
               "isActionable": false,
               "status": "unreviewed",
               "status": "unreviewed",
               "metadataChange": "added",
               "metadataChange": "added",
Line 250: Line 252:
         "body": {
         "body": {
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57827",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57827",
           "mainComment": "Main comment",
           "mainComment": "Main comment\n",
          "mainCommentMessage": {
            "asText": "Main comment\n",
            "asHtml": "<p>Main comment</p>"
          },
           "inlineComments": [
           "inlineComments": [
             {
             {
               "fileContext": "README:1",
               "fileContext": "README:1",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20973",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20973",
               "text": "Inline code comment",
               "text": "Inline code comment\n",
              "message": {
                "asText": "Inline code comment\n",
                "asHtml": "<p>Inline code comment</p>"
              },
               "contextKind": "code",
               "contextKind": "code",
               "context": {
               "context": {
Line 323: Line 333:
         "body": {
         "body": {
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57829",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57829",
           "mainComment": "Other main comment",
           "mainComment": "Other main comment\n",
          "mainCommentMessage": {
            "asText": "Other main comment\n",
            "asHtml": "<p>Other main comment</p>"
          },
           "inlineComments": [
           "inlineComments": [
             {
             {
               "fileContext": "README:1",
               "fileContext": "README:1",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20975",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20975",
               "text": "Inline reply comment",
               "text": "Inline reply comment\n",
              "message": {
                "asText": "Inline reply comment\n",
                "asHtml": "<p>Inline reply comment</p>"
              },
               "contextKind": "reply",
               "contextKind": "reply",
               "context": {
               "context": {
                 "otherAuthor": "phab-email-qa-author",
                 "otherAuthor": "phab-email-qa-author",
                 "otherDateUtc": "2020-07-24T17:08:59+00:00",
                 "otherDateUtc": "2020-07-24T17:08:59+00:00",
                 "otherComment": "Inline code comment"
                 "otherComment": "Inline code comment\n",
                "otherCommentMessage": {
                  "asText": "Inline code comment\n",
                  "asHtml": "<p>Inline code comment</p>"
                }
               }
               }
             }
             }
Line 377: Line 399:
         "body": {
         "body": {
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57831",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57831",
           "mainComment": "@phab-email-qa-reviewer-2 Main comment ping",
           "mainComment": "@phab-email-qa-reviewer-2 Main comment ping\n",
          "mainCommentMessage": {
            "asText": "@phab-email-qa-reviewer-2 Main comment ping\n",
            "asHtml": "<p><a href=\"/p/phab-email-qa-reviewer-2/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_4\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-reviewer-2</span></a> Main comment ping</p>"
          },
           "inlineComments": [],
           "inlineComments": [],
           "reviewers": [
           "reviewers": [
Line 425: Line 451:
           },
           },
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57831",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57831",
           "pingedMainComment": "@phab-email-qa-reviewer-2 Main comment ping",
           "pingedMainComment": "@phab-email-qa-reviewer-2 Main comment ping\n",
          "pingedMainCommentMessage": {
            "asText": "@phab-email-qa-reviewer-2 Main comment ping\n",
            "asHtml": "<p><a href=\"/p/phab-email-qa-reviewer-2/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_4\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-reviewer-2</span></a> Main comment ping</p>"
          },
           "pingedInlineComments": []
           "pingedInlineComments": []
         },
         },
Line 447: Line 477:
         "body": {
         "body": {
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57832",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57832",
           "mainComment": "Main ping @phab-email-qa-author ",
           "mainComment": "Main ping @phab-email-qa-author\n",
          "mainCommentMessage": {
            "asText": "Main ping @phab-email-qa-author\n",
            "asHtml": "<p>Main ping <a href=\"/p/phab-email-qa-author/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_5\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-author</span></a></p>"
          },
           "inlineComments": [
           "inlineComments": [
             {
             {
               "fileContext": "README:1",
               "fileContext": "README:1",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20978",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20978",
               "text": "Reply ping @phab-email-qa-pingee ",
               "text": "Reply ping @phab-email-qa-pingee\n",
              "message": {
                "asText": "Reply ping @phab-email-qa-pingee\n",
                "asHtml": "<p>Reply ping <a href=\"/p/phab-email-qa-pingee/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_6\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-pingee</span></a></p>"
              },
               "contextKind": "reply",
               "contextKind": "reply",
               "context": {
               "context": {
                 "otherAuthor": "phab-email-qa-reviewer-1",
                 "otherAuthor": "phab-email-qa-reviewer-1",
                 "otherDateUtc": "2020-07-24T17:09:34+00:00",
                 "otherDateUtc": "2020-07-24T17:09:34+00:00",
                 "otherComment": "Inline reply comment"
                 "otherComment": "Inline reply comment\n",
                "otherCommentMessage": {
                  "asText": "Inline reply comment\n",
                  "asHtml": "<p>Inline reply comment</p>"
                }
               }
               }
             },
             },
Line 463: Line 505:
               "fileContext": "new_file:1",
               "fileContext": "new_file:1",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20979",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20979",
               "text": "Code ping @phab-email-qa-pingee ",
               "text": "Code ping @phab-email-qa-pingee\n",
              "message": {
                "asText": "Code ping @phab-email-qa-pingee\n",
                "asHtml": "<p>Code ping <a href=\"/p/phab-email-qa-pingee/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_7\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-pingee</span></a></p>"
              },
               "contextKind": "code",
               "contextKind": "code",
               "context": {
               "context": {
Line 522: Line 568:
           },
           },
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57832",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57832",
           "pingedMainComment": "Main ping @phab-email-qa-author ",
           "pingedMainComment": "Main ping @phab-email-qa-author\n",
          "pingedMainCommentMessage": {
            "asText": "Main ping @phab-email-qa-author\n",
            "asHtml": "<p>Main ping <a href=\"/p/phab-email-qa-author/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_5\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-author</span></a></p>"
          },
           "pingedInlineComments": []
           "pingedInlineComments": []
         },
         },
Line 551: Line 601:
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57832",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57832",
           "pingedMainComment": null,
           "pingedMainComment": null,
          "pingedMainCommentMessage": null,
           "pingedInlineComments": [
           "pingedInlineComments": [
             {
             {
               "fileContext": "README:1",
               "fileContext": "README:1",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20978",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20978",
               "text": "Reply ping @phab-email-qa-pingee ",
               "text": "Reply ping @phab-email-qa-pingee\n",
              "message": {
                "asText": "Reply ping @phab-email-qa-pingee\n",
                "asHtml": "<p>Reply ping <a href=\"/p/phab-email-qa-pingee/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_6\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-pingee</span></a></p>"
              },
               "contextKind": "reply",
               "contextKind": "reply",
               "context": {
               "context": {
                 "otherAuthor": "phab-email-qa-reviewer-1",
                 "otherAuthor": "phab-email-qa-reviewer-1",
                 "otherDateUtc": "2020-07-24T17:09:34+00:00",
                 "otherDateUtc": "2020-07-24T17:09:34+00:00",
                 "otherComment": "Inline reply comment"
                 "otherComment": "Inline reply comment\n",
                "otherCommentMessage": {
                  "asText": "Inline reply comment\n",
                  "asHtml": "<p>Inline reply comment</p>"
                }
               }
               }
             },
             },
Line 566: Line 625:
               "fileContext": "new_file:1",
               "fileContext": "new_file:1",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20979",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20979",
               "text": "Code ping @phab-email-qa-pingee ",
               "text": "Code ping @phab-email-qa-pingee\n",
              "message": {
                "asText": "Code ping @phab-email-qa-pingee\n",
                "asHtml": "<p>Code ping <a href=\"/p/phab-email-qa-pingee/\" class=\"phui-tag-view phui-tag-type-person \" data-sigil=\"hovercard\" data-meta=\"0_7\"><span class=\"phui-tag-core phui-tag-color-person\">@phab-email-qa-pingee</span></a></p>"
              },
               "contextKind": "code",
               "contextKind": "code",
               "context": {
               "context": {
Line 599: Line 662:
         "body": {
         "body": {
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57836",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57836",
           "mainComment": "Comment summarizing why changes are requested",
           "mainComment": "Comment summarizing why changes are requested\n",
          "mainCommentMessage": {
            "asText": "Comment summarizing why changes are requested\n",
            "asHtml": "<p>Comment summarizing why changes are requested</p>"
          },
           "inlineComments": [
           "inlineComments": [
             {
             {
               "fileContext": "README:2",
               "fileContext": "README:2",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20981",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20981",
               "text": "Comment requesting changes",
               "text": "Comment requesting changes\n",
              "message": {
                "asText": "Comment requesting changes\n",
                "asHtml": "<p>Comment requesting changes</p>"
              },
               "contextKind": "code",
               "contextKind": "code",
               "context": {
               "context": {
Line 662: Line 733:
         "body": {
         "body": {
           "mainComment": null,
           "mainComment": null,
          "mainCommentMessage": null,
           "inlineComments": [
           "inlineComments": [
             {
             {
               "fileContext": "README:2",
               "fileContext": "README:2",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20983",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20983",
               "text": "Comment expressing counter-point",
               "text": "Comment expressing counter-point\n",
              "message": {
                "asText": "Comment expressing counter-point\n",
                "asHtml": "<p>Comment expressing counter-point</p>"
              },
               "contextKind": "reply",
               "contextKind": "reply",
               "context": {
               "context": {
                 "otherAuthor": "phab-email-qa-reviewer-1",
                 "otherAuthor": "phab-email-qa-reviewer-1",
                 "otherDateUtc": "2020-07-24T17:10:15+00:00",
                 "otherDateUtc": "2020-07-24T17:10:15+00:00",
                 "otherComment": "Comment requesting changes"
                 "otherComment": "Comment requesting changes\n",
                "otherCommentMessage": {
                  "asText": "Comment requesting changes\n",
                  "asHtml": "<p>Comment requesting changes</p>"
                }
               }
               }
             }
             }
Line 783: Line 863:
         },
         },
         "body": {
         "body": {
           "mainComment": "Looks good",
           "mainComment": "Looks good\n",
          "mainCommentMessage": {
            "asText": "Looks good\n",
            "asHtml": "<p>Looks good</p>"
          },
           "inlineComments": [
           "inlineComments": [
             {
             {
               "fileContext": "README:2",
               "fileContext": "README:2",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20984",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4558#inline-20984",
               "text": "Comment acknowledging how revision was updated to address concerns",
               "text": "Comment acknowledging how revision was updated to address concerns\n",
              "message": {
                "asText": "Comment acknowledging how revision was updated to address concerns\n",
                "asHtml": "<p>Comment acknowledging how revision was updated to address concerns</p>"
              },
               "contextKind": "reply",
               "contextKind": "reply",
               "context": {
               "context": {
                 "otherAuthor": "phab-email-qa-author",
                 "otherAuthor": "phab-email-qa-author",
                 "otherDateUtc": "2020-07-24T17:10:51+00:00",
                 "otherDateUtc": "2020-07-24T17:10:51+00:00",
                 "otherComment": "Comment expressing counter-point"
                 "otherComment": "Comment expressing counter-point\n",
                "otherCommentMessage": {
                  "asText": "Comment expressing counter-point\n",
                  "asHtml": "<p>Comment expressing counter-point</p>"
                }
               }
               }
             },
             },
Line 799: Line 891:
               "fileContext": "new_file:1",
               "fileContext": "new_file:1",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4559#inline-20985",
               "link": "https://phabricator-dev.allizom.org/D2942?id=4559#inline-20985",
               "text": "Appreciation of code quality here",
               "text": "Appreciation of code quality here\n",
              "message": {
                "asText": "Appreciation of code quality here\n",
                "asHtml": "<p>Appreciation of code quality here</p>"
              },
               "contextKind": "code",
               "contextKind": "code",
               "context": {
               "context": {
Line 913: Line 1,009:
         "body": {
         "body": {
           "mainComment": null,
           "mainComment": null,
          "mainCommentMessage": null,
           "inlineComments": [],
           "inlineComments": [],
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57852",
           "transactionLink": "https://phabricator-dev.allizom.org/D2942#57852",
Line 1,117: Line 1,214:
             {
             {
               "name": "phab-email-qa-reviewer-1",
               "name": "phab-email-qa-reviewer-1",
               "isActionable": true,
               "isActionable": false,
               "status": "unreviewed",
               "status": "unreviewed",
               "metadataChange": "added",
               "metadataChange": "added",
Mhentges
26

edits

Retrieved from "https://wiki.mozilla.org/Special:MobileDiff/1231509"

Navigation menu