Safe Browsing: Difference between revisions

Jump to navigation Jump to search
No edit summary
Line 53: Line 53:
== Other Bugs or Potential Improvements ==
== Other Bugs or Potential Improvements ==


* Should probably check for memory leaks
Are filed as bugs under [https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&product=Firefox&component=Safe+Browsing&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0= Firefox / Safe Browsing]
* Should update install.rdf to be more appropriate
* Should probably update the archaic loader.js with the newer, more generic version (still in-house here at Google)
* We need a real js unittesting framework
* ListManager should be cleaned up -- for example, we need a better way of adding new lists. We hsould just be able to add a name into the listmanager and it should figure out what to do with it. Also, we should just pass URLs to the listmanager from the warden instead of having to know about the lists it manages.
* Displayer should be generalized
* Maybe rename all the prefixes we're using? We have lots of G_, SB_, and PROT_
* Use the transparency-based displayer on Windows (if it will be supported?)
* Wireformat utils could use some clean up
* We probably need more consistent semantics for errors (return values, exceptions, etc)
* "I just got thiis very odd alert from my antivirus at home: goog-black-url.sst  was identified as having a signature PHISH.Ebayfraud.AX. The antivirus is AntiVir Free Personal Edition (http://www.free-av.com/ ). "
* "Turns out we can read the profile directory much earlier thanonprofileafterchange. Darin says use "ProfDS" instead of "ProfD" to read the profile directory at xpcom-startup (or anytime really). So we can potentially move profile directory-dependant code earlier. "
* Check for leaks
* Fix the fragment attack
* Phishing alert with sidebar open is broken
* Respect user's pref to open new windows in new tabs
* Clean up problem queue interface
 
'''TODO: expand, file bugs'''

Navigation menu