Confirm, emeritus
812
edits
Changes
Created page with ''''Code Review Policy for Weave''' Code review prior to landing is now required for _all_ changes to all production-oriented Weave code. This includes the Weave Sync client c…'
'''Code Review Policy for Weave'''
Code review prior to landing is now required for _all_ changes to all production-oriented Weave code. This includes the Weave Sync client code, the Sync server code, and the user registration code. Future parts of the Weave client will fall under this policy once they move past the experimental phase.
=== Reviewers ===
{| cellpadding="5"
|-
|[http://hg.mozilla.org/labs/weave/ Sync Client]
|[mailto:edilee@mozilla.com Ed Lee], [mailto:mconnor@mozilla.com Mike Connor]
|-
|[http://hg.mozilla.org/labs/weaveserver-sync/ Sync Server]
|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
|-
|[http://hg.mozilla.org/labs/weaveserver-registration/ User Registration Server]
|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
|}
=== System-review ===
System-review (similar to super-review in core Mozilla code) is designed to ensure the overall coherence and stability of the Weave ecosystem. Changes to any Weave code covered under this policy that impacts APIs, scalability, or client performance must receive system-review, in addition to primary review. This review will generally not cover the details of the code, but will focus on the overall system performance aspects of the patches.
Mike Hanson (mhanson@mozilla.com) is the only current system-reviewer
Code review prior to landing is now required for _all_ changes to all production-oriented Weave code. This includes the Weave Sync client code, the Sync server code, and the user registration code. Future parts of the Weave client will fall under this policy once they move past the experimental phase.
=== Reviewers ===
{| cellpadding="5"
|-
|[http://hg.mozilla.org/labs/weave/ Sync Client]
|[mailto:edilee@mozilla.com Ed Lee], [mailto:mconnor@mozilla.com Mike Connor]
|-
|[http://hg.mozilla.org/labs/weaveserver-sync/ Sync Server]
|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
|-
|[http://hg.mozilla.org/labs/weaveserver-registration/ User Registration Server]
|[mailto:telliott@mozilla.com Toby Elliott], [mailto:lmorchard@mozilla.com Les Orchard], [mailto:mhanson@mozilla.com Mike Hanson]
|}
=== System-review ===
System-review (similar to super-review in core Mozilla code) is designed to ensure the overall coherence and stability of the Weave ecosystem. Changes to any Weave code covered under this policy that impacts APIs, scalability, or client performance must receive system-review, in addition to primary review. This review will generally not cover the details of the code, but will focus on the overall system performance aspects of the patches.
Mike Hanson (mhanson@mozilla.com) is the only current system-reviewer
