Account confirmers, Anti-spam team, Confirmed users, Bureaucrats and Sysops emeriti
4,925
edits
Drumbeat/Website/Hacking: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
No edit summary |
||
| Line 11: | Line 11: | ||
Someone else will check the patch in for you when it's done. | Someone else will check the patch in for you when it's done. | ||
* Mark the bug RESOLVED FIXED | |||
* When you have seen the change pushed to production and working, mark the bug VERIFIED FIXED | |||
== Bugs == | == Bugs == | ||
| Line 27: | Line 30: | ||
* Don't touch the Drupal core. | * Don't touch the Drupal core. | ||
* Don't touch the Drupal core. (Yes, worth repeating!) | * Don't touch the Drupal core. (Yes, worth repeating!) | ||
== SVN Access == | |||
If you have SVN access, there are some additional things you need to know. | |||
When checking in, please follow standard Mozilla procedure: | |||
* Make sure you have attached a copy of the patch to the bug (if your change doesn't have a bug associated with it, it should have) | |||
* When writing checkin comments: | |||
** Always include the bug number | |||
** Always include a description of what you changed and why | |||
** Include the names of your reviewer(s), if any | |||
* Paste the checkin output into the bug comment when you mark the bug RESOLVED | |||
A good checkin comment looks like this: | |||
Bug 125643 - removed code in foo_bar module which displays "the admin is an | |||
idiot" in the header on the 13th of every month. r=gerv. | |||
Do not move the 'production' tag without the consent of mhaggerty. | |||
== Pushing to Production == | |||
==Fixing Drupal Itself== | ==Fixing Drupal Itself== | ||
We are trying to avoid forking Drupal. So, if the bug fixes a problem with a contributed module on drupal.org then create a patch and submit to the module maintainer for review, via its project page on drupal.org. As soon as the patch is accepted and the module updated on drupal.org then update the bug on mozilla.org with the name of the module and the tag attached to the new release so that the module can be updated on Drumbeat. | We are trying to avoid forking Drupal. So, if the bug fixes a problem with a contributed module on drupal.org then create a patch and submit to the module maintainer for review, via its project page on drupal.org. As soon as the patch is accepted and the module updated on drupal.org then update the bug on mozilla.org with the name of the module and the tag attached to the new release so that the module can be updated on Drumbeat. | ||