Services/Process/Code Review: Difference between revisions

Services/Process/Code Review (view source)

Revision as of 03:33, 12 January 2011

127 bytes removed , 12 January 2011

no edit summary

Mconnor

Confirmed users, Bureaucrats and Sysops emeriti

812

edits

@@ Line 1: / Line 1: @@
 '''Code Review Policy for Mozilla Services Code'''
-Code review prior to landing is now required for _all_ changes to all  production-oriented Mozilla Services code.  This includes the Firefox Sync client  code, the various pieces of server code, and anything else living in [http://hg.mozilla.org/services http://hg.mozilla.org/services].
+Code review prior to landing is now required for _all_ changes to all  production-oriented Mozilla Services code.  This includes the Firefox Sync client code, the various pieces of server code, and anything else living in [http://hg.mozilla.org/services http://hg.mozilla.org/services].
+All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers.  Where it is unclear, the first reviewer should determine that a second review would be appropriate.
 == Code Areas ==
@@ Line 13: / Line 15: @@
 * [mailto:philipp@weitershausen.de Philipp von Weitershausen]
 * [mailto:mconnor@mozilla.com Mike Connor]
-* [mailto:edilee@mozilla.com Ed Lee]
+* [mailto:edilee@mozilla.com Richard Newman]
 === Server Code (PHP) ===
@@ Line 25: / Line 27: @@
 * [mailto:telliott@mozilla.com Toby Elliott]
 * [mailto:tarek@mozilla.com Tarek Ziade]
+* [mailto:jconlin@mozilla.com JR Conlin]
 * [mailto:mconnor@mozilla.com Mike Connor]
-=== Primary Server Code (Python) ===
+=== Sync/Reg Server Code (Python) ===
 '''Repositories'''
@@ Line 48: / Line 51: @@
 '''Reviewers'''
 * [mailto:tarek@mozilla.com Tarek Ziade]
+* [mailto:telliott@mozilla.com Toby Elliott]
+* [mailto:jconlin@mozilla.com JR Conlin]
 * [mailto:ianb@mozilla.com Ian Bicking]
-= System-review =
-System-review  (similar to super-review in core Mozilla code) is designed to ensure  the overall coherence and stability of the Weave ecosystem.  Changes to  any Weave code covered under this policy that impacts APIs, scalability,  or client performance may require system-review, in addition to  primary review.  This review will generally not cover the details of the  code, but will focus on the overall system performance aspects of the  patches.
-Mike Connor (mconnor@mozilla.com) is  the only current system-reviewer