Changes

Jump to: navigation, search

Services/Process/Code Review

127 bytes removed, 03:33, 12 January 2011
no edit summary
'''Code Review Policy for Mozilla Services Code'''
Code review prior to landing is now required for _all_ changes to all production-oriented Mozilla Services code. This includes the Firefox Sync client code, the various pieces of server code, and anything else living in [http://hg.mozilla.org/services http://hg.mozilla.org/services]. All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers. Where it is unclear, the first reviewer should determine that a second review would be appropriate.
== Code Areas ==
* [mailto:philipp@weitershausen.de Philipp von Weitershausen]
* [mailto:mconnor@mozilla.com Mike Connor]
* [mailto:edilee@mozilla.com Ed LeeRichard Newman]
=== Server Code (PHP) ===
* [mailto:telliott@mozilla.com Toby Elliott]
* [mailto:tarek@mozilla.com Tarek Ziade]
* [mailto:jconlin@mozilla.com JR Conlin]
* [mailto:mconnor@mozilla.com Mike Connor]
=== Primary Sync/Reg Server Code (Python) ===
'''Repositories'''
'''Reviewers'''
* [mailto:tarek@mozilla.com Tarek Ziade]
* [mailto:telliott@mozilla.com Toby Elliott]
* [mailto:jconlin@mozilla.com JR Conlin]
* [mailto:ianb@mozilla.com Ian Bicking]
 
= System-review =
 
System-review (similar to super-review in core Mozilla code) is designed to ensure the overall coherence and stability of the Weave ecosystem. Changes to any Weave code covered under this policy that impacts APIs, scalability, or client performance may require system-review, in addition to primary review. This review will generally not cover the details of the code, but will focus on the overall system performance aspects of the patches.
 
Mike Connor (mconnor@mozilla.com) is the only current system-reviewer
Confirm, emeritus
812
edits

Navigation menu