canmove, Confirmed users, Bureaucrats and Sysops emeriti
2,776
edits
Security/Reviews/Firefox5/ReviewNotes/CSSAni: Difference between revisions
Jump to navigation
Jump to search
Security/Reviews/Firefox5/ReviewNotes/CSSAni (view source)
Revision as of 23:22, 28 April 2011
, 28 April 2011no edit summary
(Created page with "201104.28 CSS Animations https://bugzilla.mozilla.org/show_bug.cgi?id=435442 : reviewed by bz Not adding things that could not be done before - adding an API to do things you c...") |
No edit summary |
||
| Line 1: | Line 1: | ||
201104.28 | Date of Review: 201104.28 | ||
====Item Reviewed:==== | |||
CSS Animations | CSS Animations | ||
{{bug|435442}} | |||
* This change did not add things that could not be done before | |||
** Added an API to do things you could do with script before | |||
* All about getting time correct, does not affect safety | |||
* | * Don't want to redo work asynch faster than refresh | ||
* | |||
* animations vs transitions | * animations vs transitions | ||
** Transitions let you cause computed-style changes to happen slowly (and then finish) | |||
** Animations are different in that they activally cause animation | |||
example: | example: | ||
@-moz-keyframes mymove { | @-moz-keyframes mymove { | ||
0% { margin-left: 50px } | |||
25% { margin-left: 100px } | |||
100% { margin-left: 200px } | |||
} | } | ||
p { -moz-animation: mymove 2s linear infinite; } | p { -moz-animation: mymove 2s linear infinite; } | ||
issues: | issues: | ||
* possible perf issues for some corner cases (see refresh driver + iframes below), not of sec concern | * possible perf issues for some corner cases (see refresh driver + iframes below), not of sec concern | ||
| Line 24: | Line 25: | ||
* ?{dbaron,bz} to look into whether we have performance issues with iframe navigation in bfcache getting high-frequency refresh driver notifications | * ?{dbaron,bz} to look into whether we have performance issues with iframe navigation in bfcache getting high-frequency refresh driver notifications | ||
* dbaron to look into adding assertions that ~CommonElementAnimationData is only called through Destroy() | * dbaron to look into adding assertions that ~CommonElementAnimationData is only called through Destroy() | ||
* [blocks release] dbaron to file and fix bug about not overriding UA style sheets (hacky fix is to just put them between author !important and user !important) | * '''[blocks release]''' dbaron to file and fix bug about not overriding UA style sheets (hacky fix is to just put them between author !important and user !important) | ||
* [maybe blocks release] dbaron to look at handling of properties with value range restrictions interacting with cubic-bezier() that goes wider that 0%/100% (and raise as a spec issue) | * '''[maybe blocks release]''' dbaron to look at handling of properties with value range restrictions interacting with cubic-bezier() that goes wider that 0%/100% (and raise as a spec issue) | ||