49
edits
No edit summary |
|||
| Line 4: | Line 4: | ||
*Display timestamps use a preference with % replacements for y/m/d/h/n/s, defaulting to ''[%h:%n]''. They're displayed using CSS generated content. | *Display timestamps use a preference with % replacements for y/m/d/h/n/s, defaulting to ''[%h:%n]''. They're displayed using CSS generated content. | ||
*Log timestamps use [http://lxr.mozilla.org/seamonkey/find?string=nsDateTimeFormat native date/time formatting], hardcoded to use short date and time with no seconds. | *Log timestamps use [http://lxr.mozilla.org/seamonkey/find?string=nsDateTimeFormat native date/time formatting], hardcoded to use short date and time with no seconds. | ||
*''View | *''View →�Show Timestamps'' toggles timestamp status for the current view and all child views. | ||
==Problems== | ==Problems== | ||
| Line 14: | Line 14: | ||
==Existing code== | ==Existing code== | ||
*ReadMe's [https://bugzilla.mozilla.org/attachment.cgi?id=213994&action=edit JS strftime()]. | *ReadMe's [https://bugzilla.mozilla.org/attachment.cgi?id=213994&action=edit JS strftime()]. | ||
*Silver's ex-0.9.68.6 stuff | *Silver's ex-0.9.68.6 stuff. | ||
==Proposed changes== | ==Proposed changes== | ||
*Stop using generated content. '''✓''' | |||
*Stop using generated content. | *Make both log and display timestamps use the native formatter by default. '''✓''' | ||
*Make both log and display timestamps use the native formatter by default. | **Log timestamps should use the same settings they do currently. '''✓''' | ||
**Log timestamps should use the same settings they do currently. | **Display timestamps should use time only. '''✓''' | ||
**Display timestamps should use time only with | *Move default timestamp formatting to its own function that plugins can mess with if necessary. | ||
*Add prefs to allow native formatting to be overridden with strftime. | *Add prefs to allow native formatting to be overridden with strftime. '''✓''' | ||
**If possible, make sure old custom timestampFormat prefs are compatible. If not, change the pref name. | **If possible, make sure old custom timestampFormat prefs are compatible. If not, change the pref name and migrate. '''✓''' | ||
*Make ''View | *Make ''View →�Show Timestamps'' apply globally, retaining the prefs for people who want it different from view to view. | ||
==Questions== | ==Questions== | ||
*What should the format prefs look like? Two options: | *What should the format prefs look like? Two options: | ||
**A pref for logs, and a pref for display. | **A pref for logs, and a pref for display. '''✓''' | ||
**A pref for time, and a pref for date. Logs use both, display uses time only. | **A pref for time, and a pref for date. Logs use both, display uses time only. '''✗''' | ||
*Which of the prefs discussed should be hidden? | *Which of the prefs discussed should be hidden? | ||
**"All of them"'s fine by me, maybe hide the formatting ones but keep the ones for ''timestamps''? | **"All of them"'s fine by me, maybe hide the formatting ones but keep the ones for ''timestamps''? | ||
**Show display, hide logs. | |||
**Show all on client, but hide on others. | |||
*What should ''/timestamps'' do? What should ''/timestamp-format'' do? | *What should ''/timestamps'' do? What should ''/timestamp-format'' do? | ||
*Should duplicate timestamps get "collapsed"? | *Should duplicate timestamps get "collapsed"? | ||
** | **Silver already implemented this. | ||
**Maybe overload on the ''collapseMsgs'' pref? | **Maybe overload on the ''collapseMsgs'' pref? '''✓''' | ||
*Should we attempt to add a timestamp format "marker" to logs? | *Should we attempt to add a timestamp format "marker" to logs? | ||
**Probably overkill. | **Probably overkill. | ||
**Tell people who use log analyzers to use custom prefs. | **Tell people who use log analyzers to use custom prefs. | ||
edits