Confirm
455
edits
Changes
no edit summary
Any person with level 3 commit access can become a Firefox reviewer given the recommendation of 3 other reviewers.
== What does r+ mean? ==
Or, "what to expect when you're expecting a review".
Review being granted in Firefox means:
* I don't believe that this patch does harm. Areas of focus include:
** security concerns, especially where content and chrome touch each other;
** significant performance issues, especially on key paths like startup and page load;
** localization and accessibility issues.
* If it does cause problems, I will help make it right.
* The patch has test coverage appropriate to the change.
* '''Thank you''' for your patch!
Review in Firefox '''is not''' conditional on:
* The patch being the best possible way that the reviewer can envision of achieving its aim.
* The patched code reads as if it were written by a single person. Style should be ''consistent'', but it need not be ''identical''.
== Making a good patch ==
There are some things that make it easier to get a good, prompt review, and to improve the quality of the patch you submit. Help your reviewers help you, and don't be surprised if you get asked about one of the below. (Don't be ashamed either, this stuff is complicated and everyone forgets now and then.)
* small patches, functionally divided;
* description of any security concerns, especially where content and chrome touch each other;
* significant performance issues, especially on key paths like startup and page load;
* localization and accessibility issues;
* some tests;
* descriptive commit messages including your name for attribution.
== Help, my patch isn't being reviewed ==
The reviewer list might look long, but these are busy people and there can be a lot of patches to review. Sometimes patches fall through the cracks, for which we are all quite sorry.
A poke in the bug can help, or direct email to the designated reviewer. If that doesn't work, please mail the module owner for assistance: Mike Shaver (shaver@mozilla.org).
