Confirmed users
183
edits
No edit summary |
(Batch update of design, status, open issues and feedback) |
||
| Line 21: | Line 21: | ||
I've read all bug comments, and updated this page accordingly, up to this point: | I've read all bug comments, and updated this page accordingly, up to this point: | ||
* [https://bugzilla.mozilla.org/show_bug.cgi?id=564934# | * [https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c354 Bug 564934, comment 354]. | ||
It's possible that some of the latest comments are not yet reflected in this page. See below for detailed tracking of individual items. | It's possible that some of the latest comments are not yet reflected in this page. See below for detailed tracking of individual items. | ||
| Line 61: | Line 61: | ||
** <span style="color: orange; font-size: 80%; font-weight: bold">[INPUT]</span> Maybe, also shown after the last download is removed from the panel, giving access to downloads history only. | ** <span style="color: orange; font-size: 80%; font-weight: bold">[INPUT]</span> Maybe, also shown after the last download is removed from the panel, giving access to downloads history only. | ||
* {{done|When there are no active downloads, shows the classic button icon (downwards arrow).}} | * {{done|When there are no active downloads, shows the classic button icon (downwards arrow).}} | ||
* {{done|When there are active downloads, shows | * {{done|When there are active downloads, shows a progress bar and a compact indication of the remaining time, if known.}} | ||
Provides visual indication of new downloads or completed downloads. | Provides visual indication of new downloads or completed downloads. | ||
* {{done|New downloads | * {{done|New downloads are notified with a brief animation near the indicator.}} | ||
* {{done|Finished or failed downloads make the indicator | * {{done|Finished or failed downloads make the indicator glow until the panel is displayed.}} | ||
* {{done|If the indicator is removed from the toolbars, or moved to an invisible toolbar, the usual screen-level notification is shown when all downloads are completed.}} | * {{done|If the indicator is removed from the toolbars, or moved to an invisible toolbar, the usual screen-level notification is shown when all downloads are completed.}} | ||
| Line 86: | Line 85: | ||
* {{done|The panel should be shown automatically for the first download of the browsing session.}} | * {{done|The panel should be shown automatically for the first download of the browsing session.}} | ||
** <span style="color: orange; font-size: 80%; font-weight: bold">[INPUT]</span> Maybe show the panel automatically only for the first few sessions, not for the first download of every session. | |||
* {{done|The panel can be fixed-width.}} | * {{done|The panel can be fixed-width.}} | ||
** Resizeability is not as much of an issue with the downloads panel as it is with the bookmarks panel, because the downloads panel is less of a "management" interface. The full title of a download is shown in a tooltip. | ** Resizeability is not as much of an issue with the downloads panel as it is with the bookmarks panel, because the downloads panel is less of a "management" interface. The full title of a download is shown in a tooltip. | ||
| Line 95: | Line 95: | ||
* Notifications should disappear as soon as the user is done with them. We can't know the exact moment, so we use a set of heuristics. | * Notifications should disappear as soon as the user is done with them. We can't know the exact moment, so we use a set of heuristics. | ||
** | ** <span style="color: orange; font-size: 80%; font-weight: bold">[INPUT]</span> Opening the target file or folder makes the notification disappear. | ||
** {{done|Canceling a running download makes the notification disappear.}} | ** {{done|Canceling a running download makes the notification disappear.}} | ||
** {{done|Completed downloads are removed from the list when the session ends, but are restored when the session is restored.}} | ** {{done|Completed downloads are removed from the list when the session ends, but are restored when the session is restored.}} | ||
*** Active downloads have no session boundary. When the browser is closed and reopened, they're paused and resumed automatically whenever possible. | *** Active downloads have no session boundary. When the browser is closed and reopened, they're paused and resumed automatically whenever possible. | ||
** {{done|Manually removing a download from the list is possible, but not a top-level interaction.}} | ** {{done|Manually removing a download from the list is possible, but not a top-level interaction.}} | ||
*** <span style="color: orange; font-size: 80%; font-weight: bold">[INPUT]</span> | *** <span style="color: orange; font-size: 80%; font-weight: bold">[INPUT]</span> Understand if we might want a top-level remove button for completed downloads, that would be the same button that cancels running downloads. | ||
* There are no actions that make sense on more than one notification at a time. | * There are no actions that make sense on more than one notification at a time. | ||
| Line 113: | Line 113: | ||
** {{done|The context menu has commands to pause, open containing folder, go to download page, copy download link.}} | ** {{done|The context menu has commands to pause, open containing folder, go to download page, copy download link.}} | ||
* When the download is paused: | * When the download is paused: | ||
** {{done|The button | ** {{done|The button cancels the download.}} | ||
** {{done|The context menu has commands to | ** {{done|The context menu has commands to resume, open containing folder, go to download page, copy download link.}} | ||
* When the download has finished: | * When the download has finished: | ||
** {{done|Clicking the main area opens the file.}} | ** {{done|Clicking the main area opens the file.}} | ||
| Line 139: | Line 139: | ||
<td style="font-weight: bold; background: #ddd;">Description</td> | <td style="font-weight: bold; background: #ddd;">Description</td> | ||
<td style="font-weight: bold; background: #ddd;">Status</td> | <td style="font-weight: bold; background: #ddd;">Status</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td>{{bug|591289}}</td> | <td>{{bug|591289}}</td> | ||
<td>Save chosen download file name and other metadata in Places history.</td> | <td>Save chosen download file name and other metadata in Places history.</td> | ||
<td> | <td>Completed</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td>{{bug|564900}}</td> | <td>{{bug|564900}}</td> | ||
<td>Add folder to Library sidebar specifically for downloads.</td> | <td>Add folder to Library sidebar specifically for downloads.</td> | ||
<td> | <td>Completed</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td>{{bug|669905}}</td> | <td>{{bug|669905}}</td> | ||
<td>Searching in the new Downloads folder should limit the search to downloads.</td> | <td>Searching in the new Downloads folder should limit the search to downloads.</td> | ||
<td> | <td>Completed</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
| Line 185: | Line 180: | ||
<td style="font-weight: bold; background: #ddd;">Blocking?</td> | <td style="font-weight: bold; background: #ddd;">Blocking?</td> | ||
<td style="font-weight: bold; background: #ddd;">People</td> | <td style="font-weight: bold; background: #ddd;">People</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
| Line 206: | Line 194: | ||
<td class="yes">Yes</td> | <td class="yes">Yes</td> | ||
<td>d=Paolo, r=Marco</td> | <td>d=Paolo, r=Marco</td> | ||
</tr> | |||
<tr> | |||
<td>Sometimes clicking certain areas of the indicator does not work, for example when it is placed in the title bar of the window.</td> | |||
<td>[https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c290 Bug 564934, comment 290]</td> | |||
<td class="no">No</td> | |||
<td class="yes">Yes</td> | |||
<td>r=?</td> | |||
</tr> | |||
<tr> | |||
<td>The panel's arrow should be able to point near the screen edge and move without the panel itself also moving.</td> | |||
<td>[https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c347 Bug 564934, comment 347]</td> | |||
<td class="yes">Yes</td> | |||
<td class="yes">Yes</td> | |||
<td>ui=?,d=?,r=?</td> | |||
</tr> | |||
<tr> | |||
<td>The preference "Show the Downloads windows when downloading a file" should be removed from the user interface, and should have no effect on the new panel.</td> | |||
<td></td> | |||
<td class="no">No</td> | |||
<td class="yes">Yes</td> | |||
<td>ui=?,d=?,r=?</td> | |||
</tr> | </tr> | ||
<tr> | <tr> | ||
| Line 212: | Line 221: | ||
<td class="maybe">Maybe</td> | <td class="maybe">Maybe</td> | ||
<td class="yes">Yes</td> | <td class="yes">Yes</td> | ||
<td>ui= | <td>ui=?</td> | ||
</tr> | |||
<tr> | |||
<td>Define whether download items should keep the same height when they change state.</td> | |||
<td></td> | |||
<td class="no">No</td> | |||
<td class="no">No</td> | |||
<td>ui=?</td> | |||
</tr> | </tr> | ||
<tr> | <tr> | ||
<td>Accessibility review</td> | <td>Accessibility review</td> | ||
<td> | <td></td> | ||
<td class="yes">Yes</td> | <td class="yes">Yes</td> | ||
<td class="yes">Yes</td> | <td class="yes">Yes</td> | ||
<td> | <td>r=?</td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
| Line 227: | Line 243: | ||
<td class="no">No</td> | <td class="no">No</td> | ||
<td></td> | <td></td> | ||
</tr> | </tr> | ||
<tr> | <tr> | ||
| Line 244: | Line 253: | ||
</table> | </table> | ||
==== Other feedback received ==== | |||
* The indicator jumps from 1 minute to 30 seconds left, by design, though this can be confusing ([https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c315 Bug 564934, comment 315] and [https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c317 comment 317]). | |||
* "Search" icon on completed items doesn't convey the idea of "Open containing folder" ([https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c348 comment 348]). | |||
* No X button to delete an entry from the panel (comment 348). | |||
* Indicator does not appear immediately on startup (comment 348). | |||
* Indicator has no hover effect like other buttons in Tab bar (comment 348). | |||
==== Follow-ups ==== | ==== Follow-ups ==== | ||
| Line 268: | Line 285: | ||
<td>Move original <tt>nsDownloadManagerUI.js</tt> to <tt>mozapps/downloads</tt>.</td> | <td>Move original <tt>nsDownloadManagerUI.js</tt> to <tt>mozapps/downloads</tt>.</td> | ||
<td>[https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c192 Bug 564934, comment 192]</td> | <td>[https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c192 Bug 564934, comment 192]</td> | ||
</tr> | |||
<tr> | |||
<td><tt>NetUtil.newURI</tt> should <tt>QueryInterface</tt> to <tt>nsIFileURL</tt> automatically.</td> | |||
<td>[https://bugzilla.mozilla.org/show_bug.cgi?id=564934#c86 Bug 564934, comment 286]</td> | |||
</tr> | </tr> | ||
<tr> | <tr> | ||