3,035
edits
Webtools:Mozparty: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
|||
| Line 4: | Line 4: | ||
= Issues Found/Fixed = | = Issues Found/Fixed = | ||
* | * Session method should be database, not php. See line: 78 | ||
78 define('CAKE_SESSION_SAVE', 'php'); | |||
* There needs to be a README with | * <strike>/config/database.php shouldn't be in the repository. IT prefers a .default or -dist file. (Same goes for config/bootstrap.php if you expect IT to change values in it)</strike> | ||
* <strike>There needs to be a README with | |||
** description of project | ** description of project | ||
** any special server requirements | ** any special server requirements | ||
** steps to install | ** steps to install</strike> | ||
** steps to test (verify that things are working) | ** steps to test (verify that things are working) -- there isn't a solid way to test all of this -- so even after it's set up, what are the criteria to test it by to make sure it works end-to-end? | ||
* Line 288 of controllers/user_controller.php has a hardcoded link in it that isn't going to work. | * <strike>Line 288 of controllers/user_controller.php has a hardcoded link in it that isn't going to work.</strike> | ||
* Going to /user/activate/<random characters> inserts new rows in the database | * <strike>Going to /user/activate/<random characters> inserts new rows in the database</strike> | ||
* When updating a profile, if the passwords don't match the error just says "There was an error in your submission..." but doesn't say what it was | * '''When updating a profile, if the passwords don't match the error just says "There was an error in your submission..." but doesn't say what it was''' -- There is still a problem here. There is a JS alert, then it'll just change it without any error now. | ||
* When updating a profile, if input is "<'name" it is saved/returned as "<'name". Each time the profile is updated, the entities are re-encoded again. | * When updating a profile, if input is "<'name" it is saved/returned as "<'name". Each time the profile is updated, the entities are re-encoded again. | ||