canmove, Confirmed users, Bureaucrats and Sysops emeriti
2,798
edits
Fennec/NativeUI: Difference between revisions
Jump to navigation
Jump to search
→Other
MarkFinkle (talk | contribs) (→Other) |
|||
| Line 106: | Line 106: | ||
=== Other === | === Other === | ||
Things I (mfinkle) noticed that I'd like to see addressed: | Things I (mfinkle) noticed that I'd like to see addressed: | ||
* The current helpers in browser.js are wrong or inadequate. This should be easy to fix. The code is also designed for a single <browser>. We need to add tab support (coming) and see that it works well in the XUL/Java setup. | * <strike>The current helpers in browser.js are wrong or inadequate. This should be easy to fix. The code is also designed for a single <browser>. We need to add tab support (coming) and see that it works well in the XUL/Java setup.</strike> - mostly done in multiple changesets | ||
* We are not using any Gecko session history (back/forward). I think this is a mistake. We should be capturing as much session in Gecko as possible. Any reason not to? | * <strike>We are not using any Gecko session history (back/forward). I think this is a mistake. We should be capturing as much session in Gecko as possible. Any reason not to?</strike> done - cd8813d5469d | ||
* We are not using favicons in awesomebar. Just missing? or intentional? | * We are not using favicons in awesomebar. Just missing? or intentional? | ||
* <strike>URL edit box is not of "URL" type. The keyboard should change to show URL keys.</strike> done - b4bbaa96238a | * <strike>URL edit box is not of "URL" type. The keyboard should change to show URL keys.</strike> done - b4bbaa96238a | ||
* I like the JSON messaging from XUL to Java, but I think we need the reverse too. Also, GeckoAppShell.handleGeckoMessage could use a good refactor. It's already too big. | * <strike>I like the JSON messaging from XUL to Java, but I think we need the reverse too.</strike> done - ca107c8ed542 | ||
* Also, GeckoAppShell.handleGeckoMessage could use a good refactor. It's already too big. | |||
* Plans for splitting the work between non-visual Java components (like a History or Bookmark object), the visual Java UI (dialogs or buttons that use the non-visual components) and the XUL/JS helpers used to send/receive messages to Java. These seem to be the basic areas of coding. Planning how to attack any particular feature will help make sure we don't have coders stepping on each other and will make the work go faster IMO. | * Plans for splitting the work between non-visual Java components (like a History or Bookmark object), the visual Java UI (dialogs or buttons that use the non-visual components) and the XUL/JS helpers used to send/receive messages to Java. These seem to be the basic areas of coding. Planning how to attack any particular feature will help make sure we don't have coders stepping on each other and will make the work go faster IMO. | ||