Add-ons/Reviewers/MiscCannedResponses: Difference between revisions

Add-ons/Reviewers/MiscCannedResponses (view source)

979 bytes removed , 28 December 2011

no edit summary

canmove, Confirmed users

1,448

edits

@@ Line 9: / Line 9: @@
 Thank you
 </blockquote>
-== Altering DOM by textually modifying innerHTML  ==
-I find I'm using this more often than I could have expected:
-<blockquote>
-You alter the markup of documents by textually modifying their innerHTML. This causes the entire document to be re-parsed, which aside from the inefficiency has critical drawbacks, including invalidating any JavaScript reference to replaced DOM nodes, clearing any JavaScript properties and event listeners on replaced DOM nodes, re-executing any script tags in the changed markup, and causing said scripts to fail if they rely on document.write. Please create and alter DOM nodes with DOM methods such as createElement and replaceChild, and the textContent rather than innerHTML property.
-</blockquote>
 == Miscellaneous Quoting Issues  ==
@@ Line 39: / Line 34: @@
 <blockquote>
 Your add-on makes it impossible for a user to permanently remove its toolbar button, which we can't allow. Inserting your toolbar button at first run is fine, and recommended, but doing so at every startup or making it impossible to move or remove it is not.
-</blockquote>
-== Synchronous XMLHttpRequests  ==
-<blockquote>
-Your add-on makes remote, synchronous XMLHttpRequests which have the ability to lock-up the browser UI and are not allowed in public add-ons. Please use asynchronous requests instead.
 </blockquote>
 == setTimeout/setInterval  ==