AMO:Editors/EditorGuide/AddonReviews: Difference between revisions

==== Policies and actions ====

 

{| width="700" cellspacing="0" cellpadding="1" border="0"

! style="border-bottom: 2px solid black" scope="col" | Policy  

! style="border-bottom: 2px solid black" scope="col" | Action  

! style="border-bottom: 2px solid black" scope="col" | Notes

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Security violations  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Reject  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Adding HTTP content to secure pages. Visit HTTPS sites like addons.mozilla.org and make sure the identity button is unchanged. This is specially important for add-ons that insert scripts into sites.  

[[Image:Identity-button.png|center|Identity button]]

 

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | [https://addons.mozilla.org/en-US/developers/docs/policies/reviews#section-defaults No Surprises] violation  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Changing homepage, default search provider, including unexpected ads or content changes without explicit user opt-in.

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Privacy violations  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Incorrect or insufficient privacy policies, not respecting Private Mode.

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Showing a modal dialog at startup  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Many add-ons open dialogs or new tabs at startup, mostly offering information on getting started. This is useful, but it shouldn't block the user from using the browser. Opening modal (blocking) dialogs at startup is not allowed. Non-modal dialogs, separate windows or new tabs are allowed.

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Errors in the Error Console  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" |

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Add-on is very hard to use without instructions  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | If the add-on is difficult to use, there should be instructions included in the add-on descriptions, or in a startup page or window.

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Toolbar buttons are not customizable  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" |

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Memory leaks from content

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | If an add-on touches the content in any way, we need to test the add-on on a page where it works, close the page, and then look in about:memory. Remaining compartments related to the page indicate a memory leak. More details [https://developer.mozilla.org/en/Extensions/Performance_best_practices_in_extensions#Avoid_Creating_Memory_Leaks here] and

[https://developer.mozilla.org/en/Zombie_Compartments#Proactive_checking_of_add-ons here].

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Affiliate linking  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | See details below.

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Uses Geolocation without asking the user  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Preliminary Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" |

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Requires third party software or paid registration  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Admin Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | This excludes add-ons that require other add-ons to function, like Firebug extensions.

|- style="vertical-align: top;"

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Inserts ads into content  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | Admin Review  

| style="padding: .5ex 1ex 1ex 0; border-bottom: 1px solid black;" | The rules in these cases are complex. They need to be clearly labeled as coming from the add-on (otherwise Prelim). They can't remove or replace existing ads (otherwise Reject). They need to follow No Surprises (otherwise Prelim). And there are also security concerns (Reject) and privacy concerns (Prelim).

 

Other tests to perform:  

 

*Visit a very simple website like example.org and inspect its DOM, looking for any changes. Again, this is particularly important for extensions that insert scripts or make DOM changes.  

*Open the add-on's preferences window, from the Add-ons Manager and elsewhere, and verify that preference changes apply properly. Make sure the window fits all of its contents (a common problem in Mac OS).  

*Test all add-on features, within reason. If there too many, focus on the main features.

*Remove all added toolbar buttons, disable all added toolbars, and restart the browser. Make sure that buttons and toolbars are all removable and do not reappear on restart. Make sure that missing toolbar buttons to not cause errors to appear in the Error Console.

*Affiliate linking. Some add-ons add affiliate codes to Amazon links (or similar) in order to make money. At the moment we allow this as long as (1) the add-on follows the No Surprises policy, (2) the feature doesn't replace or remove any existing affiliate codes, (3) the affiliate codes aren't inserted in the merchant website's links (inserting Amazon affiliate codes in Amazon.com pages).