Confirmed users
512
edits
Per-window Private Browsing: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
No edit summary |
||
| Line 84: | Line 84: | ||
=== Downloads === | === Downloads === | ||
Proposed changes: the download manager is given an optional nsILoadContext argument when adding downloads which is used to determine whether the download is private. All download databases (private and non-private) get an extra GUID column, and methods that refer to downloads by ID change to accept GUIDs instead. The download manager window is left alone and only displays non-private downloads; the forthcoming download panel is modified to display private downloads in private windows. | |||
== Implementation concerns == | == Implementation concerns == | ||
=== Channels === | === Channels === | ||
The design which requires access to docshells is fundamentally broken for e10s, where networking occurs in the parent process and the relevant docshell is in a content process. [http://hg.mozilla.org/users/josh_joshmatthews.net/pb-per-window/file/352685cd7155/pb-httpchannel This patch] demonstrates a correct implementation for HTTP channels, whereby a concrete nsHttpChannel object can be reliably queried as to its PB usage, regardless of process. Possible solutions: | The design which requires access to docshells is fundamentally broken for e10s, where networking occurs in the parent process and the relevant docshell is in a content process. [http://hg.mozilla.org/users/josh_joshmatthews.net/pb-per-window/file/352685cd7155/pb-httpchannel This patch] demonstrates a correct implementation for HTTP channels, whereby a concrete nsHttpChannel object can be reliably queried as to its PB usage, regardless of process. Possible solutions: | ||