Marketplace/Reviewers/Apps/Testing: Difference between revisions

Jump to navigation Jump to search
Line 59: Line 59:
== Testing Procedure - Packaged Apps ==
== Testing Procedure - Packaged Apps ==


These should only be reviewed by Marketplace Staff currently.  Testing procedure coming soon...
These should only be reviewed by Marketplace Staff currently as packaged apps can be privileged as well as unprivileged.   


[https://wiki.mozilla.org/Marketplace/Reviewers/Apps/Permissions Security Checklist]
The procedure is similar to [[#Testing_Procedure_-_Hosted_webapps|hosted apps]].  Currently packaged apps are only supported on FirefoxOS.
 
See the [https://developer.mozilla.org/docs/Apps/Marketplace_review_criteria Marketplace Review Criteria] for details of what we allow and don't allow in Apps for listing on Marketplace.  The steps below outline the brief procedure, not the policy.
 
* Check the app has a sensible name, summary, description and icon.  The description should be extensive enough for a user to understand what the app does (you may need to revisit this after launching the app). If not, reject.
* The manifest url (view) link only contains some details from the actual manifest, which is inside the (zip) package.  To download the package for offline inspection, etc, click the 'package_path' link - this shouldn't be routinely necessary.
* In the version table at the bottom of the view load the validation report and inspect any warnings/errors.
* Then inspect the app contents via the 'contents' link.
* The first file should be the manifest. 
* Check the type entry.  If there is no type entry in the manifest, or its 'web', the app should be treated the same as a hosted one so it is not necessary to check the js code.
* If the type is 'privileged' then the app has access to extra APIs and all code needs to be inspected before approval.  (See subsequent steps)
* Take note of any requested permissions in the manifest.  There is a [Marketplace/Reviewers/Apps/Permissions|Security Checklist] of available APIs and what they might be used/abused for. 
* Check all the files, in particular the .js files (thankfully inline js and external files aren't allowed by the CSP), paying attention to how any permissions requested are used. **Need to expand here a little**
* Launch the app on the device and give the app a quick try and see what experience a new user would have. 
* Some apps require a login.  If its straightforward you should register as a new user (to see what experience an actual user would have).  If the app requires paid credentials; specific details; or isn't in a language you can understand sufficiently you can request a username & password - there is a canned response - with Request Information.
* Its important to note that we don't make any relevance or quality judgements about how the app ''looks'' in an App Review, only that it functions correctly.  The [https://developer.mozilla.org/docs/Apps/Marketplace_review_criteria review criteria] document should be consulted. You can make suggestions about how to improve the app though if you notice anything that would make it better.


== Communication with other App Reviewers / Admins / Platform Developers / Marketplace Developers ==
== Communication with other App Reviewers / Admins / Platform Developers / Marketplace Developers ==
Confirmed users
448

edits

Navigation menu