272
edits
Thunderbird:CodeCleanup: Difference between revisions
Jump to navigation
Jump to search
no edit summary
No edit summary |
No edit summary |
||
| Line 6: | Line 6: | ||
First, familiarize yourself with: http://developer.mozilla.org/en/docs/XPCOM:Strings#Common_Patterns | First, familiarize yourself with: http://developer.mozilla.org/en/docs/XPCOM:Strings#Common_Patterns | ||
Bad: | |||
nsCString someString | |||
PL_strcase(someString.get(), "imap://") | |||
Good: | |||
StringBeginsWith(someString, NS_LITERAL_CSTRING("imap://"); | |||
Bad: | |||
nsString fullName; | |||
nsCString realName; | |||
fullName.Assign(NS_ConvertASCIItoUTF16(realName)); | |||
Good: | |||
CopyASCIItoUTF16(realName, fullName); | |||
Bad: | |||
nsCString uri; | |||
PL_strchr(uri.get(), ' ') | |||
Good: | |||
uri.FindChar(' '); (kNotFound) | |||
Bad: | |||
nsCString uri; | |||
PL_strcasecmp(uri.get(), "nocopy://") | |||
Good: | |||
uri.LowerCaseEqualsLiteral("nocopy://") | |||
== nsCOMPtr == | == nsCOMPtr == | ||