Calendar:Hacking: Difference between revisions

Jump to navigation Jump to search
Fix outdated content
m (add adapted DOM Inspector extensions)
(Fix outdated content)
Line 112: Line 112:
4.) Go to the bug you've been working on and choose 'Create an Attachment'.  Put the path to the file that CVS diff created in the proper box, and give your patch a short title describing your changes.  Describe in detail the changes that you've made in the Description box.  Check the 'Patch' checkbox under content type.
4.) Go to the bug you've been working on and choose 'Create an Attachment'.  Put the path to the file that CVS diff created in the proper box, and give your patch a short title describing your changes.  Describe in detail the changes that you've made in the Description box.  Check the 'Patch' checkbox under content type.


5.) '''Important:''' Ask for a review!  In the dropdown menu next to 'first-review', choose the '?', since you're asking for the review.  In the textbox next to the '?' place the email address of one of the calendar developers, but '''not''' one of the calendar peers. Do the same for 'second-review', but select one of the peers.
5.) '''Important:''' Ask for a review!  In the dropdown menu next to 'review', choose the '?', since you're asking for the review.  In the textbox next to the '?' place the email address of one of the calendar developers.


Calendar peers (and therefore second-reviewers):
Adequate reviewers can be found on the [[Module:Ownership]] page.
*Joey Minta - <tt>jminta@gmail.com</tt>
*Michiel van Leeuwen - <tt>mvl@exedo.nl</tt>
*Dan Mosedale - <tt>dmose@mozilla.org</tt>


If your patch involves changes to the user interface (UI), set the 'ui-review' flag to '?' as well, and attach a screenshot (.gif, .jpg, or .png) of your proposed change.
If your patch involves changes to the user interface (UI), set the 'ui-review' flag to '?' as well, place the email address of the UI module owner or peer in the textbox, and attach a screenshot (.gif, .jpg, or .png) of your proposed change.


6.) Wait for the review.  If you haven't heard anything in 5 days, please 'poke' the review.  (Ideally, talk to them on IRC.  At a minimum, post a comment in the bug.)  If you haven't heard anything in 10 days, please choose a different reviewer.
6.) Wait for the review.  If you haven't heard anything in 5 days, please 'poke' the review.  (Ideally, talk to them on IRC.  At a minimum, post a comment in the bug.)  If you haven't heard anything in 10 days, please choose a different reviewer.
287

edits

Navigation menu