canmove, Confirmed users
345
edits
Bugzilla:Simple Patches: Difference between revisions
Jump to navigation
Jump to search
→Longer Explanation
No edit summary |
|||
| Line 9: | Line 9: | ||
It is a good idea to split your changes up into multiple simple patches. Simple patches are easier to review, because: | It is a good idea to split your changes up into multiple simple patches. Simple patches are easier to review, because: | ||
* there is more locality between similar changes, meaning less scrolling and hunting for code | |||
* the whole patch can be dedicated to just one issue, making reviewing a simpler mental task by reducing the number of mental context switches and improving the likelihood of finding problems with the patches | |||
* they can be reviewed and checked in separately, meaning only one part has to be remade if it gets a negative review, and meaning less code will get stale waiting around for a subsequent review | |||
* simple patches can be easily reviewed in small blocks of time, if that's all the reviewer has at the time | |||
Not splitting patches into separate simple patches is very tempting for all developers. They have completed our work, and they attach it. It is the easiest thing to do. | Not splitting patches into separate simple patches is very tempting for all developers. They have completed our work, and they attach it. It is the easiest thing to do. | ||