Changes

Jump to: navigation, search

Bugzilla:Review

689 bytes added, 05:24, 12 July 2007
Who Fixes The Patch?
=== Who Fixes The Patch? ===
'''The author of the patch''' is always usually the one who revises the patch if it gets a "-" on its review. The reviewer probably ''could'' fix your patch, but every Bugzilla reviewer is very busy and doesn't have the time or the desire to do so.
Also, it's a better learning experience for ''you'' to fix the patch, not to mention we tend to assume that most people want to take sole credit for their work, and many of us feel that we'd be stepping on your toes if we took over working on it.
Basically, we look at your patches as your responsibility. Once they are attached, it's up to you to revise them until we accept them.
 
If you really want to just contribute what you've done so far and let someone else clean it up and push it through the review process, say so on the bug. There's no guarantee someone else will pick it up and run with it, and you're greatly decreasing the chances of the patch making it into our code repository by doing so, but announcing that you'd like someone else to take it over is much better than a patch sitting there for 6 months because everyone is assuming the patch author will be back to fix it.
=== What If I'm Waiting Too Long for My Review? ===
Confirm, emeritus
674
edits

Navigation menu