Confirmed users
1,345
edits
JavaScript:SpiderMonkey:Coding Style: Difference between revisions
Jump to navigation
Jump to search
JavaScript:SpiderMonkey:Coding Style (view source)
Revision as of 01:38, 26 April 2013
, 26 April 2013→Other whitespace
Nnethercote (talk | contribs) |
Nnethercote (talk | contribs) |
||
| Line 83: | Line 83: | ||
if(condition) /* bad */ | if(condition) /* bad */ | ||
if (condition) /* OK */ | if (condition) /* OK */ | ||
* | * In a conditional, if the consequent (and, if present, the alternate) is a single statement, no braces are used. | ||
if ( | if (today == "Tuesday") | ||
puts("I don't have my wallet on me."); | |||
else | |||
puts("I would gladly pay you on Tuesday for a hamburger today."); | |||
However, if ''either'' the consequent or alternate is a block of multiple statements, braces are used on both. | |||
if (canSwingFromWeb) { | |||
p->swingFromWeb(); | |||
} else { | |||
JS_ASSERT(p->isSpiderPig()); | |||
p->doWhateverSpiderPigDoes(); | |||
if ( | |||
} | } | ||
* Conditions with multi-line tests should put the brace on the new line to provide a visual separation between the condition and the body. | |||
types::TypeSet *types = frame.extra(lhs).types; | |||
if (JSOp(*PC) == JSOP_SETPROP && id == types::MakeTypeId(cx, id) && | |||
types && !types->unknownObject() && | |||
types->getObjectCount() == 1 && | |||
types->getTypeObject(0) != NULL && | |||
!types->getTypeObject(0)->unknownProperties()) | |||
{ | |||
JS_ASSERT(usePropCache); | |||
types::TypeObject *object = types->getTypeObject(0); | |||
types::TypeSet *propertyTypes = object->getProperty(cx, id, false); | |||
... | |||
} else { | |||
... | |||
} | |||
However, if there is already a visual separation between the condition and the body, putting the { on a new line isn't necessary: | |||
if (forHead->pn_kid1 && NewSrcNote2(cx, cg, SRC_DECL, | |||
(forHead->pn_kid1->isOp(JSOP_DEFVAR)) | |||
? SRC_DECL_VAR | |||
: SRC_DECL_LET) < 0) { | |||
return false; | |||
} | |||
* <code>for</code> loop heads go on one line where possible; when not possible, initializer part, update, and termination parts each go on separate lines | * <code>for</code> loop heads go on one line where possible; when not possible, initializer part, update, and termination parts each go on separate lines | ||
for (int i = 0; | for (int i = 0; | ||